From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dilger, Andreas" Subject: Re: RFC: [PATCH] staging/lustre/llite: fix O_TMPFILE/O_LOV_DELAY_CREATE conflict Date: Tue, 11 Feb 2014 00:37:09 +0000 Message-ID: References: <20140210212929.GF18016@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , "Drokin, Oleg" , Peng Tao , Al Viro To: "greg@kroah.com" Return-path: Received: from mga03.intel.com ([143.182.124.21]:15232 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbaBKAhR convert rfc822-to-8bit (ORCPT ); Mon, 10 Feb 2014 19:37:17 -0500 In-Reply-To: <20140210212929.GF18016@ZenIV.linux.org.uk> Content-Language: en-US Content-ID: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2014/02/10, 2:29 PM, "Al Viro" wrote: >On Mon, Feb 10, 2014 at 08:16:52PM +0000, Dilger, Andreas wrote: >> >>Instead of trying to find a non-conflicting O_LOV_DELAY_CREATE flag >> >>or define a Lustre-specific flag that isn't of use to most/any other >> >>filesystems, use (O_NOCTTY|FASYNC) as the new value. These flag >> >>are not meaningful for newly-created regular files and should be >> >>OK since O_LOV_DELAY_CREATE is only meaningful for new files. > >*shrug* > >I can live with that; it's a kludge, but it's less broken than that >explicit constant - that one is a non-starter, since O_... flag >values are arch-dependent. Greg, could you please merge the original patch. We'd like to get this into our pending release of the Lustre user tools and into the releases for older kernels (which will support both the old and new flags until the support for older kernels is removed). Cheers, Andreas -- Andreas Dilger Lustre Software Architect Intel High Performance Data Division