Re: [meta-ivi][PATCH] weston: Add weston.ini config file

[Billie Alsup <billie.alsup@ericsson.com>]

[-- Attachment #1: Type: text/plain, Size: 2498 bytes --]

I know nothing about yocto recipes, but why would you invoke sed 4 times, rather than once with 4 different -e arguments?
this kind of approach really adds up in large build systems.


From: sujith h <sujith.h@gmail.com<mailto:sujith.h@gmail.com>>
Date: Thursday, April 24, 2014 2:18 PM
To: "Behrens, Holger" <holger.behrens@windriver.com<mailto:holger.behrens@windriver.com>>, Florin Sarbu <florin.sarbu@windriver.com<mailto:florin.sarbu@windriver.com>>
Cc: "yocto@yoctoproject.org<mailto:yocto@yoctoproject.org>" <yocto@yoctoproject.org<mailto:yocto@yoctoproject.org>>, Sujith H <Sujith_Haridasan@mentor.com<mailto:Sujith_Haridasan@mentor.com>>
Subject: Re: [yocto] [meta-ivi][PATCH] weston: Add weston.ini config file

Hi,

Any comments for this patch?


On Wed, Apr 23, 2014 at 12:42 PM, Sujith H <sujith.h@gmail.com<mailto:sujith.h@gmail.com>> wrote:
Adding weston.ini to /etc/xdg. With this change
user can login and launch weston with ivi-shell.

Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com<mailto:Sujith_Haridasan@mentor.com>>
---
 recipes-graphics/wayland/weston_1.4.0.bbappend | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/recipes-graphics/wayland/weston_1.4.0.bbappend b/recipes-graphics/wayland/weston_1.4.0.bbappend
index 7a8ba6f..b839be4 100644
--- a/recipes-graphics/wayland/weston_1.4.0.bbappend
+++ b/recipes-graphics/wayland/weston_1.4.0.bbappend
@@ -12,3 +12,17 @@ PR = "r1"

 FILES_${PN} += "${libdir}/weston/*"
 FILES_${PN}-dbg += "${libdir}/weston/.debug/*"
+
+do_install_append() {
+   WESTON_INI_CONFIG=${sysconfdir}/xdg/weston
+   install -d ${D}${WESTON_INI_CONFIG}
+   install -m 0644 ${S}/ivi-shell/weston.ini.in<http://weston.ini.in> ${D}${WESTON_INI_CONFIG}/weston.ini
+   sed -i -e  's/hmi-controller.so/hmi-controller.so<http://hmi-controller.so/hmi-controller.so>, ivi-controller.so/<http://ivi-controller.so/>' ${D}${WESTON_INI_CONFIG}/weston.ini
+   sed -i -e 's|\@libexecdir\@|${libexecdir}|' ${D}${WESTON_INI_CONFIG}/weston.ini
+   sed -i -e 's|\@abs_top_builddir\@\/data|${datadir}\/weston|' ${D}${WESTON_INI_CONFIG}/weston.ini
+   sed -i -e 's|\@abs_top_builddir\@\/clients|${bindir}|' ${D}${WESTON_INI_CONFIG}/weston.ini
+}
+
+PACKAGES += "${PN}-ini"
+
+FILES_${PN}-ini = "${sysconfdir}/xdg"
--
1.8.4




--
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info

[-- Attachment #2: Type: text/html, Size: 4665 bytes --]