From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH 2/2] clkdev: Export clk_register_clkdev Date: Mon, 02 Jun 2014 08:16:08 -0700 Message-ID: References: <1401738379-4107-1-git-send-email-chiau.ee.chew@intel.com> <1401738379-4107-3-git-send-email-chiau.ee.chew@intel.com> <20140602123522.GB31751@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Cc: Eric Miao , Russell King , Haojian Zhuang , Grant Likely , Rob Herring , Mika Westerberg , LKML , , , To: Mark Brown , Chew Chiau Ee Return-path: In-Reply-To: <20140602123522.GB31751-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-spi.vger.kernel.org On 6/2/14, 5:35, "Mark Brown" wrote: >On Tue, Jun 03, 2014 at 03:46:19AM +0800, Chew Chiau Ee wrote: >> From: Darren Hart >> >> Allow spi-pxa2xx-pci with common clock framework support to build as a >> module by exporting clk_register_clkdev. > >This needs to be patch 1 in the series not patch 2 since the change to >the driver to use the exported symbol depends on this rather than the >other way around. > That was going to be my only comment as well. It's important to ensure things build consistently through the git history. Git bisect is a key use case here, breaking that makes for very cranky kernel engineers :-) Dependencies first, new mechanisms second. -- Darren Hart Open Source Technology Center darren.hart-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: dvhart@linux.intel.com (Darren Hart) Date: Mon, 02 Jun 2014 08:16:08 -0700 Subject: [PATCH 2/2] clkdev: Export clk_register_clkdev In-Reply-To: <20140602123522.GB31751@sirena.org.uk> References: <1401738379-4107-1-git-send-email-chiau.ee.chew@intel.com> <1401738379-4107-3-git-send-email-chiau.ee.chew@intel.com> <20140602123522.GB31751@sirena.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 6/2/14, 5:35, "Mark Brown" wrote: >On Tue, Jun 03, 2014 at 03:46:19AM +0800, Chew Chiau Ee wrote: >> From: Darren Hart >> >> Allow spi-pxa2xx-pci with common clock framework support to build as a >> module by exporting clk_register_clkdev. > >This needs to be patch 1 in the series not patch 2 since the change to >the driver to use the exported symbol depends on this rather than the >other way around. > That was going to be my only comment as well. It's important to ensure things build consistently through the git history. Git bisect is a key use case here, breaking that makes for very cranky kernel engineers :-) Dependencies first, new mechanisms second. -- Darren Hart Open Source Technology Center darren.hart at intel.com Intel Corporation From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH 2/2] clkdev: Export clk_register_clkdev Date: Mon, 02 Jun 2014 08:16:08 -0700 Message-ID: References: <1401738379-4107-1-git-send-email-chiau.ee.chew@intel.com> <1401738379-4107-3-git-send-email-chiau.ee.chew@intel.com> <20140602123522.GB31751@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140602123522.GB31751-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown , Chew Chiau Ee Cc: Eric Miao , Russell King , Haojian Zhuang , Grant Likely , Rob Herring , Mika Westerberg , LKML , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 6/2/14, 5:35, "Mark Brown" wrote: >On Tue, Jun 03, 2014 at 03:46:19AM +0800, Chew Chiau Ee wrote: >> From: Darren Hart >> >> Allow spi-pxa2xx-pci with common clock framework support to build as a >> module by exporting clk_register_clkdev. > >This needs to be patch 1 in the series not patch 2 since the change to >the driver to use the exported symbol depends on this rather than the >other way around. > That was going to be my only comment as well. It's important to ensure things build consistently through the git history. Git bisect is a key use case here, breaking that makes for very cranky kernel engineers :-) Dependencies first, new mechanisms second. -- Darren Hart Open Source Technology Center darren.hart-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755005AbaFBPP5 (ORCPT ); Mon, 2 Jun 2014 11:15:57 -0400 Received: from mga09.intel.com ([134.134.136.24]:41410 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbaFBPPz (ORCPT ); Mon, 2 Jun 2014 11:15:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,957,1392192000"; d="scan'208";a="521497928" User-Agent: Microsoft-MacOutlook/14.4.1.140326 Date: Mon, 02 Jun 2014 08:16:08 -0700 Subject: Re: [PATCH 2/2] clkdev: Export clk_register_clkdev From: Darren Hart To: Mark Brown , Chew Chiau Ee CC: Eric Miao , Russell King , Haojian Zhuang , Grant Likely , Rob Herring , Mika Westerberg , LKML , , , Message-ID: Thread-Topic: [PATCH 2/2] clkdev: Export clk_register_clkdev References: <1401738379-4107-1-git-send-email-chiau.ee.chew@intel.com> <1401738379-4107-3-git-send-email-chiau.ee.chew@intel.com> <20140602123522.GB31751@sirena.org.uk> In-Reply-To: <20140602123522.GB31751@sirena.org.uk> Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/2/14, 5:35, "Mark Brown" wrote: >On Tue, Jun 03, 2014 at 03:46:19AM +0800, Chew Chiau Ee wrote: >> From: Darren Hart >> >> Allow spi-pxa2xx-pci with common clock framework support to build as a >> module by exporting clk_register_clkdev. > >This needs to be patch 1 in the series not patch 2 since the change to >the driver to use the exported symbol depends on this rather than the >other way around. > That was going to be my only comment as well. It's important to ensure things build consistently through the git history. Git bisect is a key use case here, breaking that makes for very cranky kernel engineers :-) Dependencies first, new mechanisms second. -- Darren Hart Open Source Technology Center darren.hart@intel.com Intel Corporation