From: "Luca Weiss" <luca.weiss@fairphone.com>
To: <dvander@google.com>
Cc: <Luca.Boccassi@microsoft.com>, <darrick.wong@oracle.com>,
<dsterba@suse.com>, <hubcap@omnibond.com>, <jack@suse.cz>,
<jlayton@kernel.org>, <kernel-team@android.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-security-module@vger.kernel.org>,
<linux-unionfs@vger.kernel.org>, <paulmoore@microsoft.com>,
<salyzyn@android.com>, <sds@tycho.nsa.gov>,
<selinux@vger.kernel.org>
Subject: Re: [PATCH v19 1/4] Add flags option to get xattr method paired to __vfs_getxattr
Date: Fri, 25 Mar 2022 12:02:06 +0100 [thread overview]
Message-ID: <CISWB5OO4TSD.1YIUVDSVYSIF0@otso> (raw)
In-Reply-To: <20211117015806.2192263-2-dvander@google.com>
Hi David,
this patch doesn't compile with CONFIG_SECURITY=n:
./include/linux/security.h: In function 'security_inode_need_killpriv':
./include/linux/security.h:893:40: error: passing argument 1 of 'cap_inode_need_killpriv' from incompatible pointer type [-Werror=incompatible-pointer-types]
893 | return cap_inode_need_killpriv(dentry);
| ^~~~~~
| |
| struct dentry *
./include/linux/security.h:153:52: note: expected 'struct user_namespace *' but argument is of type 'struct dentry *'
153 | int cap_inode_need_killpriv(struct user_namespace *mnt_userns,
| ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
I applied the patch on linux-next tag next-20220318, but the relevant part
doesn't seem to have changed lately.
Regards
Luca
next prev parent reply other threads:[~2022-03-25 11:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 1:58 [PATCH v19 0/4] overlayfs override_creds=off & nested get xattr fix David Anderson
2021-11-17 1:58 ` [PATCH v19 1/4] Add flags option to get xattr method paired to __vfs_getxattr David Anderson
2021-11-17 16:13 ` kernel test robot
2021-11-17 16:13 ` kernel test robot
2022-03-25 11:02 ` Luca Weiss [this message]
2022-03-25 14:44 ` Paul Moore
2021-11-17 1:58 ` [PATCH v19 2/4] overlayfs: handle XATTR_NOSECURITY flag for get xattr method David Anderson
2021-11-17 1:58 ` [PATCH v19 3/4] overlayfs: override_creds=off option bypass creator_cred David Anderson
2021-11-17 1:58 ` [PATCH v19 4/4] overlayfs: inode_owner_or_capable called during execv David Anderson
2021-11-17 2:18 ` [PATCH v19 0/4] overlayfs override_creds=off & nested get xattr fix Casey Schaufler
2021-11-18 7:59 ` David Anderson
2021-11-17 7:36 ` Amir Goldstein
2021-11-18 9:53 ` David Anderson
2021-11-18 10:20 ` Amir Goldstein
2021-11-18 20:15 ` David Anderson
2021-11-18 20:32 ` Amir Goldstein
2025-02-25 19:26 ` Paul Lawrence
2025-02-25 22:14 ` Paul Moore
2021-12-03 15:37 ` Vivek Goyal
2021-12-03 16:04 ` Paul Moore
2021-12-03 16:31 ` Amir Goldstein
2021-12-03 18:34 ` Vivek Goyal
2022-03-01 1:09 ` Paul Moore
[not found] ` <CA+FmFJA-r+JgMqObNCvE_X+L6jxWtDrczM9Jh0L38Fq-6mnbbA@mail.gmail.com>
2022-03-09 21:13 ` Paul Moore
2022-03-10 22:11 ` Paul Moore
2022-03-11 4:09 ` Amir Goldstein
2022-03-11 14:01 ` Vivek Goyal
2022-03-11 20:52 ` Paul Moore
2023-03-22 7:28 ` Johannes Segitz
2023-03-22 12:48 ` Amir Goldstein
2023-03-22 14:07 ` Paul Moore
2023-03-22 14:05 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CISWB5OO4TSD.1YIUVDSVYSIF0@otso \
--to=luca.weiss@fairphone.com \
--cc=Luca.Boccassi@microsoft.com \
--cc=darrick.wong@oracle.com \
--cc=dsterba@suse.com \
--cc=dvander@google.com \
--cc=hubcap@omnibond.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=paulmoore@microsoft.com \
--cc=salyzyn@android.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.