All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Job Noorman" <job@noorman.info>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Cc: "Henrik Rydberg" <rydberg@bitmath.org>,
	"Luca Weiss" <luca@z3ntu.xyz>, <linux-kernel@vger.kernel.org>,
	<linux-input@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] Input: add driver for Himax hx83112b touchscreen devices
Date: Mon, 17 Oct 2022 11:25:57 +0200	[thread overview]
Message-ID: <CNO39RACPFL9.13SXHBXOMYMT2@ancom> (raw)
In-Reply-To: <Y0zX0e6WbLaRuTqv@penguin>

Hi Dmitry,

Thanks for your review! I've addressed all your comments and will send an
update momentarily. I just have a small reply below.

On Mon Oct 17, 2022 at 6:19 AM CEST, Dmitry Torokhov wrote:
> > +struct himax_event {
> > +	struct himax_event_point points[HIMAX_MAX_POINTS];
> > +	u8 majors[HIMAX_MAX_POINTS];
> > +	u8 pad0[2];
> > +	u8 num_points;
> > +	u8 pad1[2];
> > +	u8 checksum_fix;
> > +} __packed;
> > +
> > +static_assert(sizeof(struct himax_event) == 56);
>
> Is this different from BUILD_BUG_ON()?

Their intent is the same but BUILD_BUG_ON() cannot be used at the global
scope. Hence, static_assert() is necessary here.

Best regards,
Job

  reply	other threads:[~2022-10-17  9:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-16 10:27 [PATCH v3 0/3] Add Himax hx83112b touchscreen driver Job Noorman
2022-10-16 10:27 ` [PATCH v3 1/3] dt-bindings: touchscreen: add Himax hx83112b bindings Job Noorman
2022-10-16 15:00   ` Krzysztof Kozlowski
2022-10-16 15:09     ` Job Noorman
2022-10-16 10:27 ` [PATCH v3 2/3] Input: add driver for Himax hx83112b touchscreen devices Job Noorman
2022-10-17  4:19   ` Dmitry Torokhov
2022-10-17  9:25     ` Job Noorman [this message]
2022-10-16 10:27 ` [PATCH v3 3/3] arm64: dts: qcom: sdm632: fairphone-fp3: add touchscreen Job Noorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CNO39RACPFL9.13SXHBXOMYMT2@ancom \
    --to=job@noorman.info \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@z3ntu.xyz \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.