From: "Job Noorman" <job@noorman.info>
To: "Jeff LaBundy" <jeff@labundy.com>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Henrik Rydberg" <rydberg@bitmath.org>,
"Luca Weiss" <luca@z3ntu.xyz>, <linux-kernel@vger.kernel.org>,
<linux-input@vger.kernel.org>
Subject: Re: [PATCH v5 2/3] Input: add driver for Himax hx83112b touchscreen devices
Date: Mon, 24 Oct 2022 16:03:30 +0200 [thread overview]
Message-ID: <CNU7K2WVE8IR.3400IWODUPYYK@ancom> (raw)
In-Reply-To: <Y1We8NgutWBbbNpV@nixie71>
Hi Jeff,
On Sun Oct 23, 2022 at 10:07 PM CEST, Jeff LaBundy wrote:
> Hi Job,
>
> Looks great; just a few tiny nits that I missed last time. Sorry
> about that!
No problem!
> > + ts->regmap = devm_regmap_init_i2c(client, &himax_regmap_config);
> > + error = PTR_ERR_OR_ZERO(ts->regmap);
> > + if (error) {
> > + dev_err(&client->dev,
>
> We already have a locally declared dev pointer which at this point is
> equal to &client->dev as well as &ts->client->dev, so we can just use
> that here instead.
Nice catch! Fixed this one and all others in v6.
> With those remaining points resolved:
>
> Reviewed-by: Jeff LaBundy <jeff@labundy.com>
Thanks! Added in v6.
Kind regards,
Job
next prev parent reply other threads:[~2022-10-24 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 16:30 [PATCH v5 0/3] Add Himax hx83112b touchscreen driver Job Noorman
2022-10-23 16:30 ` [PATCH v5 1/3] dt-bindings: touchscreen: add Himax hx83112b bindings Job Noorman
2022-10-23 16:30 ` [PATCH v5 2/3] Input: add driver for Himax hx83112b touchscreen devices Job Noorman
2022-10-23 20:07 ` Jeff LaBundy
2022-10-24 14:03 ` Job Noorman [this message]
2022-10-23 16:30 ` [PATCH v5 3/3] arm64: dts: qcom: sdm632: fairphone-fp3: add touchscreen Job Noorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CNU7K2WVE8IR.3400IWODUPYYK@ancom \
--to=job@noorman.info \
--cc=dmitry.torokhov@gmail.com \
--cc=jeff@labundy.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.