From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Laurent Dufour" <ldufour@linux.ibm.com>,
<linuxppc-dev@lists.ozlabs.org>, <mpe@ellerman.id.au>,
<christophe.leroy@csgroup.eu>
Subject: Re: [PATCH] pseries/mobility: reset the RCU watchdogs after a LPM
Date: Mon, 28 Nov 2022 13:59:59 +1000 [thread overview]
Message-ID: <CONMN2ANFF1X.32AFVTS82UR2X@bobo> (raw)
In-Reply-To: <20221125173204.15329-1-ldufour@linux.ibm.com>
On Sat Nov 26, 2022 at 3:32 AM AEST, Laurent Dufour wrote:
> The RCU watchdog timer should be reset when restarting the CPU after a Live
> Partition Mobility operation.
>
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
Looks okay to me. xmon touches the softlockup watchdog explicitly but
is that for architectures with unsynchronized clocks maybe.
Acked-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> arch/powerpc/platforms/pseries/mobility.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
> index 634fac5db3f9..9e10f38dd9ad 100644
> --- a/arch/powerpc/platforms/pseries/mobility.c
> +++ b/arch/powerpc/platforms/pseries/mobility.c
> @@ -636,8 +636,10 @@ static int do_join(void *arg)
> }
> /*
> * Execution may have been suspended for several seconds, so
> - * reset the watchdog.
> + * reset the watchdogs.
> */
> + rcu_cpu_stall_reset();
> + /* touch_nmi_watchdog() also touch the soft lockup watchdog */
> touch_nmi_watchdog();
> return ret;
> }
> --
> 2.38.1
next prev parent reply other threads:[~2022-11-28 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 17:32 [PATCH] pseries/mobility: reset the RCU watchdogs after a LPM Laurent Dufour
2022-11-28 3:59 ` Nicholas Piggin [this message]
2022-12-08 12:40 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CONMN2ANFF1X.32AFVTS82UR2X@bobo \
--to=npiggin@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=ldufour@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.