All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Daniel Henrique Barboza" <danielhb413@gmail.com>, <qemu-ppc@nongnu.org>
Cc: <qemu-devel@nongnu.org>,
	"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>
Subject: Re: [PATCH v3 2/9] target/ppc: Fix PMU MMCR0[PMCjCE] bit in hflags calculation
Date: Tue, 16 May 2023 20:44:05 +1000	[thread overview]
Message-ID: <CSNN2JCJ9ZUZ.3U1FM12NO5AIQ@wheely> (raw)
In-Reply-To: <4b7c4c7b-d374-766b-48f1-c6769805f0bc@gmail.com>

On Tue May 16, 2023 at 7:32 PM AEST, Daniel Henrique Barboza wrote:
>
>
> On 5/15/23 06:26, Nicholas Piggin wrote:
> > A store to MMCR0 with PMCjCE=1 fails to update hflags correctly and
> > results in hflags mismatch:
> > 
> >    qemu: fatal: TCG hflags mismatch (current:0x2408003d rebuilt:0x240a003d)
> > 
> > This can be reproduced by running perf on a recent machine.
> > 
> > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> > ---
>
> Fixes: c2eff582a32f ("target/ppc: PMU basic cycle count for pseries TCG")

Or is it this one? 0625c7760d54 ("target/ppc: do not call
hreg_compute_hflags() in helper_store_mmcr0()")

Ah, neither! It looks like 8b3d1c49a9f0 ("target/ppc: Add new PMC
HFLAGS"). But that shows I have probably missed HFLAGS_PMC_OTHER
here.

Let me do a bit more investigation and send an updated patch if
necessary.

Thanks,
Nick

>
> (not sure why I didn't hit this back in 2021)
>
>
> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


  reply	other threads:[~2023-05-16 10:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-15  9:26 [PATCH v3 0/9] target/ppc: Assorted ppc target fixes Nicholas Piggin
2023-05-15  9:26 ` [PATCH v3 1/9] target/ppc: Fix width of some 32-bit SPRs Nicholas Piggin
2023-05-15 10:14   ` Harsh Prateek Bora
2023-05-15 11:14     ` Nicholas Piggin
2023-05-15 11:43       ` Harsh Prateek Bora
2023-05-15 12:03   ` Mark Cave-Ayland
2023-05-15 12:51     ` Nicholas Piggin
2023-05-15 15:19     ` Nicholas Piggin
2023-05-16  7:02       ` Mark Cave-Ayland
2023-05-16  9:39         ` Nicholas Piggin
2023-05-15  9:26 ` [PATCH v3 2/9] target/ppc: Fix PMU MMCR0[PMCjCE] bit in hflags calculation Nicholas Piggin
2023-05-16  9:32   ` Daniel Henrique Barboza
2023-05-16 10:44     ` Nicholas Piggin [this message]
2023-05-16 11:07       ` Daniel Henrique Barboza
2023-05-15  9:26 ` [PATCH v3 3/9] target/ppc: Fix instruction loading endianness in alignment interrupt Nicholas Piggin
2023-05-16 15:46   ` Daniel Henrique Barboza
2023-05-15  9:26 ` [PATCH v3 4/9] target/ppc: Alignment faults do not set DSISR in ISA v3.0 onward Nicholas Piggin
2023-05-15  9:26 ` [PATCH v3 5/9] target/ppc: Change partition-scope translate interface Nicholas Piggin
2023-05-15  9:26 ` [PATCH v3 6/9] target/ppc: Add SRR1 prefix indication to interrupt handlers Nicholas Piggin
2023-05-15  9:26 ` [PATCH v3 7/9] target/ppc: Implement HEIR SPR Nicholas Piggin
2023-05-15  9:26 ` [PATCH v3 8/9] target/ppc: Add ISA v3.1 LEV indication in SRR1 for system call interrupts Nicholas Piggin
2023-05-15  9:26 ` [PATCH v3 9/9] target/ppc: Better CTRL SPR implementation Nicholas Piggin
2023-05-27 18:05 ` [PATCH v3 0/9] target/ppc: Assorted ppc target fixes Daniel Henrique Barboza
2023-05-29  1:47   ` Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CSNN2JCJ9ZUZ.3U1FM12NO5AIQ@wheely \
    --to=npiggin@gmail.com \
    --cc=danielhb413@gmail.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.