All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Cédric Le Goater" <clg@kaod.org>, qemu-ppc@nongnu.org
Cc: <qemu-devel@nongnu.org>, "Frederic Barrat" <frederic.barrat@fr.ibm.com>
Subject: Re: [PATCH] ppc/pnv: Add initial P9/10 SBE model
Date: Mon, 29 May 2023 11:51:11 +1000	[thread overview]
Message-ID: <CSYDVLMGDZV3.1FTXBTBGZIQXK@wheely> (raw)
In-Reply-To: <39307893-c28b-ece2-9403-322c2884e5f0@kaod.org>

On Fri May 26, 2023 at 10:20 PM AEST, Cédric Le Goater wrote:
> On 8/11/22 10:04, Cédric Le Goater wrote:
> > On 8/11/22 09:54, Nicholas Piggin wrote:

[snip]

> >> +
> >> +#define sbe_cmd_dbg(fmt, ...) do { \
> >> +    if (DEBUG_SBE_CMD) { \
> >> +        fprintf(stderr, "SBE cmd: %s: " fmt, __func__, ## __VA_ARGS__); \
> >> +    } \
> >> +} while (0)
> > 
> > Please use trace events instead, with a pnv_sbe_ prefix.
> > 
> > Apart from that, LGTM !
> > 
> > Reviewed-by: Cédric Le Goater <clg@kaod.org>
>
>
>
>
> This looked like an interesting extension to the baremetal models.
> Did you abandon the idea ? if not, it would be good material for
> QEMU 8.1. Could you resend please  ? (with the TOD patches)

Hey Cedric,

Yeah I kind of forgot about these for a while, sorry :( Too much
stuff going on... But by an amazing coincidence I have just started to
look at these again in the past few days, so I should try to get it
merged.

Thanks,
Nick


      reply	other threads:[~2023-05-29  1:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11  7:54 [PATCH] ppc/pnv: Add initial P9/10 SBE model Nicholas Piggin
2022-08-11  8:04 ` Cédric Le Goater
2023-05-26 12:20   ` Cédric Le Goater
2023-05-29  1:51     ` Nicholas Piggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CSYDVLMGDZV3.1FTXBTBGZIQXK@wheely \
    --to=npiggin@gmail.com \
    --cc=clg@kaod.org \
    --cc=frederic.barrat@fr.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.