From: "Erik Schilling" <erik.schilling@linaro.org>
To: "Viresh Kumar" <viresh.kumar@linaro.org>,
<xen-devel@lists.xen.org>, "Juergen Gross" <jgross@suse.com>,
"Julien Grall" <julien@xen.org>,
"Anthony PERARD" <anthony.perard@citrix.com>
Cc: "Vincent Guittot" <vincent.guittot@linaro.org>,
stratos-dev@op-lists.linaro.org,
"Alex Bennée" <alex.bennee@linaro.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.com>,
"Oleksandr Tyshchenko" <olekstysh@gmail.com>
Subject: Re: [PATCH V3 3/3] libxl: arm: Add grant_usage parameter for virtio devices
Date: Fri, 02 Jun 2023 08:25:34 +0200 [thread overview]
Message-ID: <CT1Y7URMMDGV.33DMUXYONLKUT@fedora> (raw)
In-Reply-To: <0e347b2f4817cc578a5f8e41bf70503ae8cf69e3.1685684586.git.viresh.kumar@linaro.org>
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
> index 0a203d22321f..bf846dca8ec0 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -1792,6 +1792,9 @@ func (x *DeviceVirtio) fromC(xc *C.libxl_device_virtio) error {
> x.BackendDomname = C.GoString(xc.backend_domname)
> x.Type = C.GoString(xc._type)
> x.Transport = VirtioTransport(xc.transport)
> +if err := x.GrantUsage.fromC(&xc.grant_usage);err != nil {
NITPICK: space after ; seems missing.
> +return fmt.Errorf("converting field GrantUsage: %v", err)
> +}
> x.Devid = Devid(xc.devid)
> x.Irq = uint32(xc.irq)
> x.Base = uint64(xc.base)
> @@ -1809,6 +1812,9 @@ xc.backend_domname = C.CString(x.BackendDomname)}
> if x.Type != "" {
> xc._type = C.CString(x.Type)}
> xc.transport = C.libxl_virtio_transport(x.Transport)
> +if err := x.GrantUsage.toC(&xc.grant_usage); err != nil {
Here it exists.
- Erik
next prev parent reply other threads:[~2023-06-02 6:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 5:49 [PATCH V3 0/3] libxl: Make grants configurable for virtio devices Viresh Kumar
2023-06-02 5:49 ` [PATCH V3 1/3] libxl: virtio: Remove unused frontend nodes Viresh Kumar
2023-06-12 14:04 ` Anthony PERARD
2023-06-02 5:49 ` [PATCH V3 2/3] libxl: Call libxl__virtio_devtype.set_default() early enough Viresh Kumar
2023-06-12 14:09 ` Anthony PERARD
2023-06-02 5:49 ` [PATCH V3 3/3] libxl: arm: Add grant_usage parameter for virtio devices Viresh Kumar
2023-06-02 6:25 ` Erik Schilling [this message]
2023-06-02 6:30 ` Viresh Kumar
2023-06-12 14:48 ` Anthony PERARD
2023-06-13 6:02 ` [PATCH V3.1] " Viresh Kumar
2023-06-13 10:48 ` Anthony PERARD
2023-06-30 4:40 ` Viresh Kumar
2023-06-30 8:40 ` Julien Grall
2023-06-30 8:42 ` Julien Grall
2023-06-30 8:43 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CT1Y7URMMDGV.33DMUXYONLKUT@fedora \
--to=erik.schilling@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=mathieu.poirier@linaro.com \
--cc=olekstysh@gmail.com \
--cc=stratos-dev@op-lists.linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.