From: "Nicholas Piggin" <npiggin@gmail.com>
To: "BALATON Zoltan" <balaton@eik.bme.hu>, <qemu-devel@nongnu.org>,
<qemu-ppc@nongnu.org>
Cc: <clg@kaod.org>, "Greg Kurz" <groug@kaod.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>
Subject: Re: [PATCH v3 12/14] target/ppc: Clean up ifdefs in excp_helper.c, part 1
Date: Tue, 20 Jun 2023 15:07:20 +1000 [thread overview]
Message-ID: <CTH7TRQ8I0SP.30Z12X2RSO5JI@wheely> (raw)
In-Reply-To: <178a7e99a1d930b8f988280741147513a726a68b.1686868895.git.balaton@eik.bme.hu>
On Fri Jun 16, 2023 at 9:03 AM AEST, BALATON Zoltan wrote:
> Use #ifdef, #ifndef for brevity and add comments to #endif that are
> more than a few lines apart for clarity.
These will collide with the SOFTMMU ifdef changes that Philippe is
working on I think? They seem okay but maybe wait until after those
are merged?
Thanks,
Nick
next prev parent reply other threads:[~2023-06-20 5:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 23:03 [PATCH v3 00/14] Misc clean ups to target/ppc exception handling BALATON Zoltan
2023-06-15 23:03 ` [PATCH v3 01/14] target/ppc: Remove some superfluous parentheses BALATON Zoltan
2023-06-15 23:03 ` [PATCH v3 02/14] target/ppc: Remove unneeded parameter from powerpc_reset_wakeup() BALATON Zoltan
2023-06-15 23:03 ` [PATCH v3 03/14] target/ppc: Move common check in exception handlers to a function BALATON Zoltan
2023-06-15 23:03 ` [PATCH v3 04/14] target/ppc: Use env_cpu for cpu_abort in excp_helper BALATON Zoltan
2023-06-20 4:54 ` Nicholas Piggin
2023-06-20 10:50 ` BALATON Zoltan
2023-06-15 23:03 ` [PATCH v3 05/14] target/ppc: Remove some more local CPUState variables only used once BALATON Zoltan
2023-06-20 5:01 ` Nicholas Piggin
2023-06-15 23:03 ` [PATCH v3 06/14] target/ppc: Readability improvements in exception handlers BALATON Zoltan
2023-06-15 23:03 ` [PATCH v3 07/14] target/ppd: Remove unused define BALATON Zoltan
2023-06-18 12:48 ` Bernhard Beschow
2023-06-15 23:03 ` [PATCH v3 08/14] target/ppc: Fix gen_sc to use correct nip BALATON Zoltan
2023-06-20 4:03 ` Nicholas Piggin
2023-06-15 23:03 ` [PATCH v3 09/14] target/ppc: Move patching nip from exception handler to helper_scv BALATON Zoltan
2023-06-20 4:09 ` Nicholas Piggin
2023-06-20 10:47 ` BALATON Zoltan
2023-06-26 11:25 ` Nicholas Piggin
2023-06-27 17:40 ` BALATON Zoltan
2023-06-28 1:03 ` Nicholas Piggin
2023-06-26 11:28 ` Nicholas Piggin
2023-06-15 23:03 ` [PATCH v3 10/14] target/ppc: Simplify syscall exception handlers BALATON Zoltan
2023-06-20 5:05 ` Nicholas Piggin
2023-06-15 23:03 ` [PATCH v3 11/14] target/ppc: Get CPUState in one step BALATON Zoltan
2023-06-15 23:03 ` [PATCH v3 12/14] target/ppc: Clean up ifdefs in excp_helper.c, part 1 BALATON Zoltan
2023-06-20 5:07 ` Nicholas Piggin [this message]
2023-06-20 10:52 ` BALATON Zoltan
2023-06-15 23:03 ` [PATCH v3 13/14] target/ppc: Clean up ifdefs in excp_helper.c, part 2 BALATON Zoltan
2023-06-15 23:03 ` [PATCH v3 14/14] target/ppc: Clean up ifdefs in excp_helper.c, part 3 BALATON Zoltan
2023-06-30 19:52 ` [PATCH v3 00/14] Misc clean ups to target/ppc exception handling Daniel Henrique Barboza
2023-06-30 22:57 ` BALATON Zoltan
2023-07-01 6:39 ` Daniel Henrique Barboza
2023-07-01 9:39 ` BALATON Zoltan
2023-07-01 9:59 ` Daniel Henrique Barboza
2023-07-02 12:36 ` BALATON Zoltan
2023-07-03 10:09 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CTH7TRQ8I0SP.30Z12X2RSO5JI@wheely \
--to=npiggin@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.