From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Nicholas Piggin" <npiggin@gmail.com>, <qemu-devel@nongnu.org>
Cc: qemu-stable@nongnu.org,
"Matheus Tavares Bernardino" <quic_mathbern@quicinc.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Taylor Simpson" <tsimpson@quicinc.com>,
"Frederic Barrat" <fbarrat@linux.ibm.com>
Subject: Re: [PATCH] gdbstub: Fix client Ctrl-C handling
Date: Wed, 12 Jul 2023 12:13:20 +1000 [thread overview]
Message-ID: <CTZTWJ73RQFY.1ZX05ZTD1FIWA@wheely> (raw)
In-Reply-To: <20230711085903.304496-1-npiggin@gmail.com>
On Tue Jul 11, 2023 at 6:59 PM AEST, Nicholas Piggin wrote:
> The gdb remote protocol has a special interrupt character (0x03) that is
> transmitted outside the regular packet processing, and represents a
> Ctrl-C pressed in the client. Despite not being a regular packet, it
> does expect a regular stop response if the stub successfully stops the
> running program.
>
> See: https://sourceware.org/gdb/onlinedocs/gdb/Interrupts.html
>
> Inhibiting the stop reply packet can lead to gdb client hang. So permit
> a stop response when receiving a character from gdb that stops the vm.
> Additionally, add a warning if that was not a 0x03 character, because
> the gdb session is likely to end up getting confused if this happens.
>
> Cc: qemu-stable@nongnu.org
Oh, I should note that this doesn't apply to any stable
branches I'm sorry. Will be more careful with the tag...
Thanks,
Nick
next prev parent reply other threads:[~2023-07-12 2:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 8:59 [PATCH] gdbstub: Fix client Ctrl-C handling Nicholas Piggin
2023-07-11 11:03 ` Matheus Tavares Bernardino
2023-07-12 2:11 ` Nicholas Piggin
2023-07-26 6:35 ` Joel Stanley
2023-07-30 9:43 ` Nicholas Piggin
2023-07-31 6:58 ` Joel Stanley
2023-07-31 13:59 ` Peter Maydell
2023-08-01 20:05 ` Philippe Mathieu-Daudé
2023-08-01 18:40 ` Matheus Tavares Bernardino
2023-08-08 22:56 ` Richard Henderson
2023-08-10 10:05 ` Alex Bennée
2023-07-12 2:13 ` Nicholas Piggin [this message]
2023-07-12 10:39 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CTZTWJ73RQFY.1ZX05ZTD1FIWA@wheely \
--to=npiggin@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=fbarrat@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.