From: "Nicolas Escande" <nico.escande@gmail.com>
To: "Minjie Du" <duminjie@vivo.com>,
"Gregory Greenman" <gregory.greenman@intel.com>,
"Kalle Valo" <kvalo@kernel.org>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"open list:INTEL WIRELESS WIFI LINK (iwlwifi)"
<linux-wireless@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Cc: <opensource.kernel@vivo.com>
Subject: Re: [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register()
Date: Wed, 12 Jul 2023 16:01:22 +0200 [thread overview]
Message-ID: <CU08YMZ7867W.ITLC05RV2R69@syracuse> (raw)
In-Reply-To: <20230712131407.16462-1-duminjie@vivo.com>
On Wed Jul 12, 2023 at 3:14 PM CEST, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return
> in iwl_mei_dbgfs_register().
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> drivers/net/wireless/intel/iwlwifi/mei/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> index 54445f39f..e5d203a62 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> @@ -1888,7 +1888,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *mei)
> {
> mei->dbgfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
>
> - if (!mei->dbgfs_dir)
> + if (IS_ERR(mei->dbgfs_dir))
> return;
same as the other one
>
> debugfs_create_ulong("status", S_IRUSR,
next prev parent reply other threads:[~2023-07-12 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 13:14 [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register() Minjie Du
2023-07-12 14:01 ` Nicolas Escande [this message]
2023-08-13 15:27 ` Greenman, Gregory
2023-08-21 12:46 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CU08YMZ7867W.ITLC05RV2R69@syracuse \
--to=nico.escande@gmail.com \
--cc=duminjie@vivo.com \
--cc=gregory.greenman@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.