Re: [meta-virtualization][PATCH v2] vhost-device: add recipes for vhost-device daemons

["Erik Schilling" <erik.schilling@linaro.org>]

On Wed Aug 16, 2023 at 10:11 AM CEST, Mikko Rapeli wrote:
> Hi,
>
> On Mon, Aug 14, 2023 at 10:04:06AM +0200, Erik Schilling wrote:
> > This adds recipes for the first tagged release of the vhost-device
> > daemons of the rust-vmm project.
> > 
> > While the initial release was done for all daemons at the same time,
> > the daemons all have indepentend version numbers and will be released
> > on their own schedules in the future. Therefore, I splitted them into
> > independent recipes.
> > 
> > Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
> > ---
> > These are a bunch of daemons that implement various vhost-user virtio
> > devices. Currently, they are mostly tested with QEMU, but we are also
> > working on Xen support (most bits are upstream already).
> > ---
> > Changes in v2:
> > - Added README.md to explain generation of dependency .inc files
> > - Link to v1: https://lore.kernel.org/r/20230728-vhost-device-v1-1-d9f81124b66a@linaro.org
> > ---
> >  README.md                                          |  14 ++
> >  .../vhost-device/vhost-device-gpio-crates.inc      | 184 +++++++++++++++
> >  .../vhost-device/vhost-device-gpio_0.1.0.bb        |  20 ++
> >  .../vhost-device/vhost-device-i2c-crates.inc       | 126 ++++++++++
> >  .../vhost-device/vhost-device-i2c_0.1.0.bb         |  16 ++
> >  .../vhost-device/vhost-device-rng-crates.inc       | 158 +++++++++++++
> >  .../vhost-device/vhost-device-rng_0.1.0.bb         |  17 ++
> >  .../vhost-device/vhost-device-scsi-crates.inc      | 166 +++++++++++++
> >  .../vhost-device/vhost-device-scsi_0.1.0.bb        |  16 ++
> >  .../vhost-device/vhost-device-vsock-crates.inc     | 258 +++++++++++++++++++++
> >  .../vhost-device/vhost-device-vsock_0.1.0.bb       |  16 ++
> >  11 files changed, 991 insertions(+)
> <snip>
> > +++ b/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb
> > @@ -0,0 +1,20 @@
> > +SUMMARY = "vhost gpio backend device"
> > +DESCRIPTION = "A vhost-user backend that emulates a VirtIO GPIO device"
> > +HOMEPAGE = "https://github.com/rust-vmm/vhost-device"
> > +LICENSE = "Apache-2.0 | BSD-3-Clause"
> > +LIC_FILES_CHKSUM = "\
> > +    file://LICENSE-APACHE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
> > +    file://LICENSE-BSD-3-Clause;md5=2489db1359f496fff34bd393df63947e \
> > +"
> > +DEPENDS += "libgpiod"
> > +# libgpiod-sys generates bindings using bindgen, which depends on clang
> > +DEPENDS += "clang-native"
>
> As Richard mentioned on #yocto, this recipe adds a new layer dependency from
> meta-virtualization to meta-clang. This could be documented and test build jobs
> changed to include meta-clang, or these recipes could be moved to build conditionally
> only when meta-clang is available by moving the recipes to directory
> dynamic-layers/meta-clang/recipes-extended
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1528/steps/23/logs/stdio

Hm... I guess moving vhost-device-gpio to dynamic-layers/ is the least
invasive option?

@Bruce: Which option do you prefer? I can draft a patch.

> Or how hard is the dependency to clang-native?

vhost-device-gpio depends on libgpiod which generates the bindings at
build time with bindgen [1]. So it is a hard dependency for that daemon.
The other daemons are fine without it.

[1] https://github.com/rust-lang/rust-bindgen

- Erik