From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 652AAC83F33 for ; Thu, 31 Aug 2023 10:13:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343785AbjHaKNN (ORCPT ); Thu, 31 Aug 2023 06:13:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238116AbjHaKNM (ORCPT ); Thu, 31 Aug 2023 06:13:12 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 445F5E67 for ; Thu, 31 Aug 2023 03:13:01 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-529fb2c6583so768873a12.1 for ; Thu, 31 Aug 2023 03:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1693476780; x=1694081580; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=e7v4YEHKe+eCw/TeGULI02ezKGrSX/6FZe8vszhKShU=; b=GDZ07FpT+CNej/aZSh1Np170rhrgZlJvNr7rN2UfCQCEFdE+x0XoodqDWDnbK7AEaR 7vbJCYHNV9WoepvB26K4Na02Ai3SiwGPSONp7aPVTvCuko0DKAZxhGb5333X2dYucEco 3tgh+LSaeYPjOsC121NFuJAvWmdasM2Sw3YWwA76BOBV+bFDE1h7kssMqZDaX6hJ5zZh t0Z85r0ZfgrBcxWXBsu5UcgVM4e4BLR0UjnTdMF6inOqmHqIBMsxmL1i7t4aBrirlRBv LGa02fBEJxENZ575c6mrk1xDPeDNNdHwHp2FmxkwrLGheY6OAKxMI2I3Q63/eCX/f6mr VRvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693476780; x=1694081580; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=e7v4YEHKe+eCw/TeGULI02ezKGrSX/6FZe8vszhKShU=; b=OEd8k25Xqn6TQsMWWk9clArPb+ecE0zE0/PDN2R7cB4JVKxG2KiNdtzZcgDkWKjjEo me8gwAWp54xL7CgcrSaAe/fSxhXiM19+ENsWWsChLVE1dpX/zJWNjruimd7Vfu9vLWCB eq4m9rVrEJQveLnoWMxsuilIZFe4tmjxAiXZVew8U7Wm/iHEZoo+fkBOQM9AclYMVk48 bgCIzP7HVSBexdeapNVVMTjfH0LHa5Dgb1gIZiyGIl+j/VcoFvNotBUkludIkgFIxqij gOuQ0UfGPT96QaBo1+syVHXEeH1l3H/TFmXEpN6ky4nJ74Olo5gd5WlcFVzuji+fCtK2 MRQw== X-Gm-Message-State: AOJu0Ywszhvm38gQeslGgHfgkF/E8XvpC+p7v/zxHnwnWka1GyRPNOye q9008FBqGn2h79Dt197kVMhEpw== X-Google-Smtp-Source: AGHT+IEuYVCopo/jdrk+kN9i1QSXZe6VfZ6G0pxlPUpl/QjLI2c9L+8wfjA/Ey3Yg4SWpToT5CAN9w== X-Received: by 2002:a50:fc05:0:b0:525:680a:6b89 with SMTP id i5-20020a50fc05000000b00525680a6b89mr3661319edr.12.1693476779584; Thu, 31 Aug 2023 03:12:59 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id x18-20020aa7d6d2000000b0052718577668sm608976edr.11.2023.08.31.03.12.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Aug 2023 03:12:59 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 31 Aug 2023 12:12:58 +0200 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , , , Subject: Re: [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable From: "Luca Weiss" To: "Krzysztof Kozlowski" , , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Srinivas Kandagatla" , "Linus Walleij" , "Rafael J. Wysocki" , "Viresh Kumar" X-Mailer: aerc 0.15.2 References: <20230830-fp5-initial-v1-0-5a954519bbad@fairphone.com> <20230830-fp5-initial-v1-4-5a954519bbad@fairphone.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed Aug 30, 2023 at 12:06 PM CEST, Krzysztof Kozlowski wrote: > On 30/08/2023 11:58, Luca Weiss wrote: > > Like other Qualcomm PMICs the PM7250B can be used on different addresse= s > > on the SPMI bus. Use similar defines like the PMK8350 to make this > > possible. > >=20 > > Signed-off-by: Luca Weiss > > --- > > arch/arm64/boot/dts/qcom/pm7250b.dtsi | 23 ++++++++++++++++------- > > 1 file changed, 16 insertions(+), 7 deletions(-) > >=20 > > diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dt= s/qcom/pm7250b.dtsi > > index e8540c36bd99..3514de536baa 100644 > > --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi > > +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi > > @@ -7,6 +7,15 @@ > > #include > > #include > > =20 > > +/* This PMIC can be configured to be at different SIDs */ > > +#ifndef PM7250B_SID > > + #define PM7250B_SID 2 > > +#endif > > Why do you send the same patch as v1, without any reference to previous > discussions? > > You got here feedback already. > > https://lore.kernel.org/linux-arm-msm/f52524da-719b-790f-ad2c-0c3f313d9fe= 9@linaro.org/ Hi Krzysztof, I did mention that original patch in the cover letter of this series. I'm definitely aware of the discussion earlier this year there but also tried to get an update lately if there's any update with no response. If you want to block this patch, I'll have to remove pm7250b from the device dts, so we'll lose some functionality. Not sure what other approaches there could be. Regards Luca > > Best regards, > Krzysztof