From: "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To: "Miguel Ojeda" <ojeda@kernel.org>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Alex Gaynor" <alex.gaynor@gmail.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@lists.linux.dev
Subject: Re: [PATCH 1/3] rust: task: remove redundant explicit link
Date: Mon, 09 Oct 2023 10:48:19 +0200 [thread overview]
Message-ID: <CW3S1FL7JQ9K.3R5QL6NYCVBJ8@gmail.com> (raw)
In-Reply-To: <20231005210556.466856-2-ojeda@kernel.org>
> Starting with Rust 1.73.0, `rustdoc` detects redundant explicit
> links with its new lint `redundant_explicit_links` [1]:
>
> error: redundant explicit link target
> --> rust/kernel/task.rs:85:21
> |
> 85 | /// [`current`](crate::current) macro because it is safe.
> | --------- ^^^^^^^^^^^^^^ explicit target is redundant
> | |
> | because label contains path that resolves to same destination
> |
> = note: when a link's destination is not specified,
> the label is used to resolve intra-doc links
> = note: `-D rustdoc::redundant-explicit-links` implied by `-D warnings`
> help: remove explicit link target
> |
> 85 | /// [`current`] macro because it is safe.
>
> In order to avoid the warning in the compiler upgrade commit,
> make it an intra-doc link as the tool suggests.
>
> Link: https://github.com/rust-lang/rust/pull/113167 [1]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
next prev parent reply other threads:[~2023-10-09 8:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 21:05 [PATCH 0/3] Rust 1.73.0 upgrade Miguel Ojeda
2023-10-05 21:05 ` [PATCH 1/3] rust: task: remove redundant explicit link Miguel Ojeda
2023-10-05 21:29 ` Martin Rodriguez Reboredo
2023-10-06 8:17 ` Finn Behrens
2023-10-06 8:51 ` Alice Ryhl
2023-10-09 8:48 ` Vincenzo Palazzo [this message]
2023-10-05 21:05 ` [PATCH 2/3] rust: print: use explicit link in documentation Miguel Ojeda
2023-10-05 21:30 ` Martin Rodriguez Reboredo
2023-10-06 8:14 ` Finn Behrens
2023-10-06 8:52 ` Alice Ryhl
2023-10-09 8:48 ` Vincenzo Palazzo
2023-10-05 21:05 ` [PATCH 3/3] rust: upgrade to Rust 1.73.0 Miguel Ojeda
2023-10-05 21:30 ` Martin Rodriguez Reboredo
2023-10-06 9:08 ` Alice Ryhl
2023-10-09 8:49 ` Vincenzo Palazzo
2023-10-15 19:35 ` [PATCH 0/3] Rust 1.73.0 upgrade Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CW3S1FL7JQ9K.3R5QL6NYCVBJ8@gmail.com \
--to=vincenzopalazzodev@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.