All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Harsh Prateek Bora" <harshpb@linux.ibm.com>, <qemu-ppc@nongnu.org>
Cc: <clegoate@redhat.com>, <qemu-devel@nongnu.org>,
	<mikey@neuling.org>, <vaibhav@linux.ibm.com>,
	<jniethe5@gmail.com>, <sbhat@linux.ibm.com>,
	<kconsul@linux.vnet.ibm.com>, <danielhb413@gmail.com>
Subject: Re: [PATCH v2 00/14] Nested PAPR API (KVM on PowerVM)
Date: Mon, 13 Nov 2023 23:15:50 +1000	[thread overview]
Message-ID: <CWXPNBOJTWCV.24ODSFNXQ0WEX@wheely> (raw)
In-Reply-To: <20231012104951.194876-1-harshpb@linux.ibm.com>

This will have to wait until the next release. There should not be
big changes to rebase on. I'll take a better look before then.

Linux now has this merged upstream so it will be much easier to test.

I posted some RFCs for new avocado tests including a KVM guest boot
(https://lists.gnu.org/archive/html/qemu-ppc/2023-10/msg00260.html).
Byt I guess it won't be too easy to adapt that to test the new API
until there is a usable distro image with support. We should open an
issue for that.

Thanks,
Nick

On Thu Oct 12, 2023 at 8:49 PM AEST, Harsh Prateek Bora wrote:
> There is an existing Nested-HV API to enable nested guests on powernv
> machines. However, that is not supported on pseries/PowerVM LPARs.
> This patch series implements required hcall interfaces to enable nested
> guests with KVM on PowerVM.
> Unlike Nested-HV, with this API, entire L2 state is retained by L0
> during guest entry/exit and uses pre-defined Guest State Buffer (GSB)
> format to communicate guest state between L1 and L2 via L0.
>
> L0 here refers to the phyp/PowerVM, or launching a Qemu TCG L0 with the
> newly introduced option cap-nested-papr=true.
> L1 refers to the LPAR host on PowerVM or Linux booted on Qemu TCG with
> above mentioned option cap-nested-papr=true.
> L2 refers to nested guest running on top of L1 using KVM.
> No SW changes needed for Qemu running in L1 Linux as well as L2 Kernel.
>
> There is a Linux Kernel side patch series to enable support for Nested
> PAPR in L1 and same can be found at below url:
>
> Linux Kernel patch series:
> - https://lore.kernel.org/linuxppc-dev/20230914030600.16993-1-jniethe5@gmail.com/
>
> For more details, documentation can be referred in either of patch
> series.
>
> There are scripts available to assist in setting up an environment for
> testing nested guests at https://github.com/iamjpn/kvm-powervm-test
>
> A tree with this series is available at:
> https://github.com/planetharsh/qemu/tree/upstream-kop-1012
>
> Thanks to Michael Neuling, Shivaprasad Bhat, Kautuk Consul, Vaibhav Jain
> and Jordan Niethe.
>
> Changelog:
>
> v2:
>     - Addressed review comments from Nick on v1 series.
> v1:
>     - https://lore.kernel.org/qemu-devel/20230906043333.448244-1-harshpb@linux.ibm.com/
>
> Harsh Prateek Bora (14):
>   spapr: nested:  move nested part of spapr_get_pate into spapr_nested.c
>   spapr: nested: Introduce SpaprMachineStateNested to store related
>     info.
>   spapr: nested: Document Nested PAPR API
>   spapr: nested: Introduce cap-nested-papr for Nested PAPR API
>   spapr: nested: register nested-hv api hcalls only for cap-nested-hv
>   spapr: nested: Introduce H_GUEST_[GET|SET]_CAPABILITIES hcalls.
>   spapr: nested: Introduce H_GUEST_[CREATE|DELETE] hcalls.
>   spapr: nested: Introduce H_GUEST_CREATE_VPCU hcall.
>   spapr: nested: Initialize the GSB elements lookup table.
>   spapr: nested: Introduce H_GUEST_[GET|SET]_STATE hcalls.
>   spapr: nested: Use correct source for parttbl info for nested PAPR
>     API.
>   spapr: nested: rename nested_host_state to nested_hv_host
>   spapr: nested: keep nested-hv exit code restricted to its API.
>   spapr: nested: Introduce H_GUEST_RUN_VCPU hcall.
>
>  docs/devel/nested-papr.txt      |  500 +++++++++++
>  hw/ppc/spapr.c                  |   32 +-
>  hw/ppc/spapr_caps.c             |   63 ++
>  hw/ppc/spapr_hcall.c            |    2 -
>  hw/ppc/spapr_nested.c           | 1439 ++++++++++++++++++++++++++++++-
>  include/hw/ppc/spapr.h          |   21 +-
>  include/hw/ppc/spapr_cpu_core.h |    7 +-
>  include/hw/ppc/spapr_nested.h   |  361 ++++++++
>  target/ppc/cpu.h                |    2 +
>  9 files changed, 2368 insertions(+), 59 deletions(-)
>  create mode 100644 docs/devel/nested-papr.txt



      parent reply	other threads:[~2023-11-13 13:16 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12 10:49 [PATCH v2 00/14] Nested PAPR API (KVM on PowerVM) Harsh Prateek Bora
2023-10-12 10:49 ` [PATCH v2 01/14] spapr: nested: move nested part of spapr_get_pate into spapr_nested.c Harsh Prateek Bora
2023-11-29  3:47   ` Nicholas Piggin
2023-10-12 10:49 ` [PATCH v2 02/14] spapr: nested: Introduce SpaprMachineStateNested to store related info Harsh Prateek Bora
2023-11-29  3:48   ` Nicholas Piggin
2023-10-12 10:49 ` [PATCH v2 03/14] spapr: nested: Document Nested PAPR API Harsh Prateek Bora
2023-10-12 10:49 ` [PATCH v2 04/14] spapr: nested: Introduce cap-nested-papr for " Harsh Prateek Bora
2023-11-29  4:01   ` Nicholas Piggin
2023-11-30  6:19     ` Harsh Prateek Bora
2023-11-30 11:11       ` Nicholas Piggin
2023-12-01  5:34         ` Harsh Prateek Bora
2023-10-12 10:49 ` [PATCH v2 05/14] spapr: nested: register nested-hv api hcalls only for cap-nested-hv Harsh Prateek Bora
2023-11-29  4:03   ` Nicholas Piggin
2023-10-12 10:49 ` [PATCH v2 06/14] spapr: nested: Introduce H_GUEST_[GET|SET]_CAPABILITIES hcalls Harsh Prateek Bora
2023-10-12 10:49 ` [PATCH v2 07/14] spapr: nested: Introduce H_GUEST_[CREATE|DELETE] hcalls Harsh Prateek Bora
2023-10-12 10:49 ` [PATCH v2 08/14] spapr: nested: Introduce H_GUEST_CREATE_VPCU hcall Harsh Prateek Bora
2023-10-12 10:49 ` [PATCH v2 09/14] spapr: nested: Initialize the GSB elements lookup table Harsh Prateek Bora
2023-10-12 10:49 ` [PATCH v2 10/14] spapr: nested: Introduce H_GUEST_[GET|SET]_STATE hcalls Harsh Prateek Bora
2023-10-12 10:49 ` [PATCH v2 11/14] spapr: nested: Use correct source for parttbl info for nested PAPR API Harsh Prateek Bora
2023-11-29  4:15   ` Nicholas Piggin
2023-10-12 10:49 ` [PATCH v2 12/14] spapr: nested: rename nested_host_state to nested_hv_host Harsh Prateek Bora
2023-10-12 10:49 ` [PATCH v2 13/14] spapr: nested: keep nested-hv exit code restricted to its API Harsh Prateek Bora
2023-11-29  4:16   ` Nicholas Piggin
2023-10-12 10:49 ` [PATCH v2 14/14] spapr: nested: Introduce H_GUEST_RUN_VCPU hcall Harsh Prateek Bora
2023-11-29  4:58   ` Nicholas Piggin
2023-11-13 13:15 ` Nicholas Piggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CWXPNBOJTWCV.24ODSFNXQ0WEX@wheely \
    --to=npiggin@gmail.com \
    --cc=clegoate@redhat.com \
    --cc=danielhb413@gmail.com \
    --cc=harshpb@linux.ibm.com \
    --cc=jniethe5@gmail.com \
    --cc=kconsul@linux.vnet.ibm.com \
    --cc=mikey@neuling.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=sbhat@linux.ibm.com \
    --cc=vaibhav@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.