From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Yusong Gao" <a869920004@gmail.com>, <davem@davemloft.net>,
<dhowells@redhat.com>, <dwmw2@infradead.org>,
<zohar@linux.ibm.com>, <herbert@gondor.apana.org.au>,
<lists@sapience.com>, <dimitri.ledkov@canonical.com>
Cc: <keyrings@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-crypto@vger.kernel.org>
Subject: Re: [RESEND PATCH v2] sign-file: Fix incorrect return values check
Date: Tue, 21 Nov 2023 01:44:03 +0200 [thread overview]
Message-ID: <CX41E533XH4S.1B6IZCU0PKPL2@kernel.org> (raw)
In-Reply-To: <20231120013359.814059-1-a869920004@gmail.com>
On Mon Nov 20, 2023 at 3:33 AM EET, Yusong Gao wrote:
> There are some wrong return values check in sign-file when call OpenSSL
> API. For example the CMS_final() return 1 for success or 0 for failure.
Why not make it a closed sentence and list the functions that need to be
changed?
> The ERR() check cond is wrong because of the program only check the
> return value is < 0 instead of <= 0.
>
Lacking Fixes tag(s). See: ttps://www.kernel.org/doc/html/latest/process/submitting-patches.html
> Link:
> https://www.openssl.org/docs/manmaster/man3/CMS_final.html
> https://www.openssl.org/docs/manmaster/man3/i2d_CMS_bio_stream.html
> https://www.openssl.org/docs/manmaster/man3/i2d_PKCS7_bio.html
> https://www.openssl.org/docs/manmaster/man3/BIO_free.html
Replace with
Link: https://www.openssl.org/docs/manmaster/man3/
BR, Jarkko
next prev parent reply other threads:[~2023-11-20 23:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 1:33 [RESEND PATCH v2] sign-file: Fix incorrect return values check Yusong Gao
2023-11-20 23:44 ` Jarkko Sakkinen [this message]
2023-11-21 2:32 ` Yusong Gao
-- strict thread matches above, loose matches on Subject: below --
2023-11-10 7:18 Yusong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CX41E533XH4S.1B6IZCU0PKPL2@kernel.org \
--to=jarkko@kernel.org \
--cc=a869920004@gmail.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dimitri.ledkov@canonical.com \
--cc=dwmw2@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@sapience.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.