From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70C316AB9; Sat, 13 Jan 2024 20:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="elFGA7OA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 575F4C433F1; Sat, 13 Jan 2024 20:46:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705178820; bh=iwEVATHQ8eeDbVh0zZOeyRTJ7va9/daHx97fvBWGCnc=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=elFGA7OAAVDu5Vtl+1rE9koMNONVqQziudmT364fAVLfwluPsG963158mubxJMrfI OkZvV7rgV3+7U0C8wB+Vb5kPKoZKLDUCx/oIZT2y90SpyYyM9TRjupAqVUFdE8/6D0 YNgX0OPsdD/wL5RSkPZ1T48vyt3L7edkolfwLwBlXpZPvbsBW1hmD1/ttRHCL0l8ow 1cawMy0CyaoMsD9Y2MN/VEEREJAfxbQk5EaZ3UiKp9VOhYKrI9VBv3OI1sjJMZDnYh 0w+yOrYIt3pi4DBp5UAiCJe3UCq1yDOAqWrXeOmaBQ/jzXfYrks29Br/fBXrU5Ipeh AIvh8rn7afNtg== Precedence: bulk X-Mailing-List: keyrings@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 13 Jan 2024 22:46:57 +0200 Message-Id: Cc: , , Subject: Re: [PATCH] KEYS: include header for EINVAL definition From: "Jarkko Sakkinen" To: "Clay Chang" , , , X-Mailer: aerc 0.16.0 References: <20240107132842.4024084-1-clayc@hpe.com> In-Reply-To: On Fri Jan 12, 2024 at 7:59 AM EET, Clay Chang wrote: > Hi Jarkko, > > Yes, I have. I am working on an OpenBMC project and the kernel .config wa= s generated by merging several config fragments. In one experiment where th= e CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not presented, I got a EINVAL un= declared compilation error. > > Do you want me to show the full .config here? Well the problem with the patch is that it does not *prove* that there is issue. So you evidence in the commit message that there is bug in the first place and which config options cause it. And it it must be testable with latest mainline (not by downstream project). BR, Jarkko