All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Peter Robinson" <pbrobinson@gmail.com>, <linux-tegra@vger.kernel.org>
Cc: "Jon Hunter" <jonathanh@nvidia.com>,
	"Thierry Reding" <treding@nvidia.com>,
	"Sameer Pujar" <spujar@nvidia.com>
Subject: Re: [PATCH v2 1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA
Date: Fri, 19 Jan 2024 16:37:00 +0100	[thread overview]
Message-ID: <CYISLWR02ZWF.18RE3DFIINWF5@gmail.com> (raw)
In-Reply-To: <20240112093310.329642-1-pbrobinson@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

On Fri Jan 12, 2024 at 10:32 AM CET, Peter Robinson wrote:
> Update the architecture dependency to be the generic Tegra
> because the driver works on the four latest Tegra generations
> not just T210, if you build a kernel with a specific

I prefer spelling these out as Tegra210 for better greppability.

> ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get
> this driver.
>
> Fixes: 46a88534afb59 ("bus: Add support for Tegra ACONNECT")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Cc: Jon Hunter <jonathanh@nvidia.com>
> Cc: Thierry Reding <treding@nvidia.com>
> ---
>
> v2: fix spelling of option
>
>  drivers/bus/Kconfig | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index e6742998f372c..b003dad62d596 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -186,11 +186,12 @@ config SUNXI_RSB
>  
>  config TEGRA_ACONNECT
>  	tristate "Tegra ACONNECT Bus Driver"
> -	depends on ARCH_TEGRA_210_SOC
> +	depends on ARCH_TEGRA
>  	depends on OF && PM
>  	help
>  	  Driver for the Tegra ACONNECT bus which is used to interface with
> -	  the devices inside the Audio Processing Engine (APE) for Tegra210.
> +	  the devices inside the Audio Processing Engine (APE) for
> +	  Tegra210/Tegra186/Tegra194/Tegra234.

Perhaps we want to say something like "Tegra210 and later"? I know it's
going to be in at least one more, but I would think it's likely that it
will stay around even longer.

Sameer, have you seen any indication that ACONNECT will go away in some
future chip?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2024-01-19 15:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12  9:32 [PATCH v2 1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA Peter Robinson
2024-01-12  9:32 ` [PATCH v2 2/2] dmaengine: tegra210-adma: " Peter Robinson
2024-01-17 14:56   ` Jon Hunter
2024-01-19 15:37   ` Thierry Reding
2024-01-17 14:55 ` [PATCH v2 1/2] bus: tegra-aconnect: " Jon Hunter
2024-01-19 15:37 ` Thierry Reding [this message]
2024-01-22  7:59   ` Sameer Pujar
2024-01-22 16:25 ` (subset) " Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CYISLWR02ZWF.18RE3DFIINWF5@gmail.com \
    --to=thierry.reding@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-tegra@vger.kernel.org \
    --cc=pbrobinson@gmail.com \
    --cc=spujar@nvidia.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.