From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6042E28DDB; Fri, 16 Feb 2024 10:26:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708079172; cv=none; b=QL//gJDRwG8NAUU76Pr+pig4jOq/mqom2W0htnZldxluq323/z3HA601bGlgqlvm4LHym76CumXYTaz/xj1caxh1pe9U4QynP0UWV0l8NHzcEgmPTIDP8Qik4vmX5SkryMa7tL1xHRPygBt7LJM6AYkWhCGE94iH5MXZlxzyCmU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708079172; c=relaxed/simple; bh=+pkZefiPmfNLRzzUaA7n5y6qDHZMRJRXzHgd4nb5GWI=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=nw/bjA+16XiDCQIbECPFzNwqW97PjD29kba0yVRYar/4dYF5A2FzJrghQJGL672mCQwHyIYCW+AZKzOrinlmeqK69QRmKSN6/4QtTKGlVC5HZ9m+Hidhv0YMks53QnG9i3qCIQyrHapYZ3it6axIyfLHtZszKCRsZwOgSUQDP5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=JStXjQwk; arc=none smtp.client-ip=217.70.183.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="JStXjQwk" Received: by mail.gandi.net (Postfix) with ESMTPSA id C30BCFF808; Fri, 16 Feb 2024 10:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708079167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+pkZefiPmfNLRzzUaA7n5y6qDHZMRJRXzHgd4nb5GWI=; b=JStXjQwkH8ZEt3ydGXVRwZp6IkCy5Zb/CKP5zP2BZwV1waZcrgBbRQ1po2x6JlAl4Itmei e24H/RGyChLjiA1UQe8aWbD06HYzzIK2PmACcN2dS4hdovnrnjX+il83nu9n/1/Fj0EUNr DuEQ6s7HjJya1vYAA1KXYWWQW6cY9eRNTBZXPiT+rmisBFEcJWmE+e4+6GQ4P36zFAce/0 10oc8yiNhMWpISFBt273Za7EdagZ38B71U8e9xztbG20jWbgAQEUTiKVRUGc6CE3orTQBk A921fyqr3AuzC2aRVrmIH7KoatrVo2RMPzF+QGpzuX0suvp5/oViWbtnjXYtqw== Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 16 Feb 2024 11:26:05 +0100 Message-Id: Cc: , , , , , "Gregory Clement" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Krzysztof Kozlowski" , "Linus Walleij" , "Andi Shyti" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Thomas Bogendoerfer" From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH 13/13] MIPS: mobileye: eyeq5: add resets to I2C controllers X-Mailer: aerc 0.15.2 References: <20240215-mbly-i2c-v1-0-19a336e91dca@bootlin.com> <20240215-mbly-i2c-v1-13-19a336e91dca@bootlin.com> <42b7e3bb-a152-4ded-91f3-fb8043a7f413@linaro.org> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com Hello, On Fri Feb 16, 2024 at 10:17 AM CET, Krzysztof Kozlowski wrote: > On 16/02/2024 10:05, Th=C3=A9o Lebrun wrote: > > Hello, > >=20 > > On Fri Feb 16, 2024 at 8:59 AM CET, Krzysztof Kozlowski wrote: > >> On 15/02/2024 17:52, Th=C3=A9o Lebrun wrote: > >>> Add resets properties to each I2C controller. This depends on the > >>> reset-eyeq5 platform reset controller driver. > >>> > >>> Signed-off-by: Th=C3=A9o Lebrun > >>> --- > >> > >> This should be squashed with previous patch adding i2c controllers. > >> Don't add incomplete nodes just to fix them in next patch. > >=20 > > The goal was to isolate reset phandles to a single patch. The series > > That was what you did, not the goal. If that's the goal, then it is > clearly wrong. > > > with this patch dropped works because resets in their default state are > > deasserted, so this isn't a fix. And it allows testing the series on > > hardware with only the base platform series, which I found useful. > > Series or half-of-series? Anyway, commits must be logical chunks, so one > chunk is to add I2C controllers, not "part of I2C controllers". DTS is > also independent of drivers (and it will go via different trees!), so > whatever dependency you think of, it does not exist. My reasoning was focused on my point-of-view as a contributor and tester of the series. Your explanation makes sense; I had never thought this through from the maintainer's POV. Thanks, -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A134C48260 for ; Fri, 16 Feb 2024 10:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Subject:From:To: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vXaN8w9XSDxoF5+3/DPY54q4m/7Kwo+XxLCCs6dOAPQ=; b=hhP1Lh1XwoTll6 woGJSL3+EKcCU3vnSKpbUAYsPt4uLR5VFhFWofc5rtWD4fy71LTysGUDr5Q4gPxbuXYnRMmuUFsbq kcIWSDMaE/X4XEZ/UOpjhN19R9xszv9YgI4MTeTO0ll+77X2o6ZBxUYXy/RdhrEASlRFLn/L3y+8o 2MNvmQ4bvoYErOz2bbviqfiWWLMO1Wz2lWQyAfm1jne+1Tsbdh0E/VDLger6NmE4kfO/K/wu2YjES o9Ect9SSqMVQiLXdm5kZEhZqEWFSJOIkGHEiQP6omGtgOim6PGzREUU6usyvQh5yx9PsbbjN6/68o XSoaNwTzt7vQPrPVGpDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ravQ6-00000001xBC-2Ypc; Fri, 16 Feb 2024 10:26:14 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ravQ4-00000001xAR-0aOF for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2024 10:26:13 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id C30BCFF808; Fri, 16 Feb 2024 10:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708079167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+pkZefiPmfNLRzzUaA7n5y6qDHZMRJRXzHgd4nb5GWI=; b=JStXjQwkH8ZEt3ydGXVRwZp6IkCy5Zb/CKP5zP2BZwV1waZcrgBbRQ1po2x6JlAl4Itmei e24H/RGyChLjiA1UQe8aWbD06HYzzIK2PmACcN2dS4hdovnrnjX+il83nu9n/1/Fj0EUNr DuEQ6s7HjJya1vYAA1KXYWWQW6cY9eRNTBZXPiT+rmisBFEcJWmE+e4+6GQ4P36zFAce/0 10oc8yiNhMWpISFBt273Za7EdagZ38B71U8e9xztbG20jWbgAQEUTiKVRUGc6CE3orTQBk A921fyqr3AuzC2aRVrmIH7KoatrVo2RMPzF+QGpzuX0suvp5/oViWbtnjXYtqw== Mime-Version: 1.0 Date: Fri, 16 Feb 2024 11:26:05 +0100 Message-Id: Cc: , , , , , "Gregory Clement" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Krzysztof Kozlowski" , "Linus Walleij" , "Andi Shyti" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Thomas Bogendoerfer" From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH 13/13] MIPS: mobileye: eyeq5: add resets to I2C controllers X-Mailer: aerc 0.15.2 References: <20240215-mbly-i2c-v1-0-19a336e91dca@bootlin.com> <20240215-mbly-i2c-v1-13-19a336e91dca@bootlin.com> <42b7e3bb-a152-4ded-91f3-fb8043a7f413@linaro.org> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_022612_348300_FE7D14AD X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpPbiBGcmkgRmViIDE2LCAyMDI0IGF0IDEwOjE3IEFNIENFVCwgS3J6eXN6dG9mIEtv emxvd3NraSB3cm90ZToKPiBPbiAxNi8wMi8yMDI0IDEwOjA1LCBUaMOpbyBMZWJydW4gd3JvdGU6 Cj4gPiBIZWxsbywKPiA+IAo+ID4gT24gRnJpIEZlYiAxNiwgMjAyNCBhdCA4OjU5IEFNIENFVCwg S3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKPiA+PiBPbiAxNS8wMi8yMDI0IDE3OjUyLCBUaMOp byBMZWJydW4gd3JvdGU6Cj4gPj4+IEFkZCByZXNldHMgcHJvcGVydGllcyB0byBlYWNoIEkyQyBj b250cm9sbGVyLiBUaGlzIGRlcGVuZHMgb24gdGhlCj4gPj4+IHJlc2V0LWV5ZXE1IHBsYXRmb3Jt IHJlc2V0IGNvbnRyb2xsZXIgZHJpdmVyLgo+ID4+Pgo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBUaMOp byBMZWJydW4gPHRoZW8ubGVicnVuQGJvb3RsaW4uY29tPgo+ID4+PiAtLS0KPiA+Pgo+ID4+IFRo aXMgc2hvdWxkIGJlIHNxdWFzaGVkIHdpdGggcHJldmlvdXMgcGF0Y2ggYWRkaW5nIGkyYyBjb250 cm9sbGVycy4KPiA+PiBEb24ndCBhZGQgaW5jb21wbGV0ZSBub2RlcyBqdXN0IHRvIGZpeCB0aGVt IGluIG5leHQgcGF0Y2guCj4gPiAKPiA+IFRoZSBnb2FsIHdhcyB0byBpc29sYXRlIHJlc2V0IHBo YW5kbGVzIHRvIGEgc2luZ2xlIHBhdGNoLiBUaGUgc2VyaWVzCj4KPiBUaGF0IHdhcyB3aGF0IHlv dSBkaWQsIG5vdCB0aGUgZ29hbC4gSWYgdGhhdCdzIHRoZSBnb2FsLCB0aGVuIGl0IGlzCj4gY2xl YXJseSB3cm9uZy4KPgo+ID4gd2l0aCB0aGlzIHBhdGNoIGRyb3BwZWQgd29ya3MgYmVjYXVzZSBy ZXNldHMgaW4gdGhlaXIgZGVmYXVsdCBzdGF0ZSBhcmUKPiA+IGRlYXNzZXJ0ZWQsIHNvIHRoaXMg aXNuJ3QgYSBmaXguIEFuZCBpdCBhbGxvd3MgdGVzdGluZyB0aGUgc2VyaWVzIG9uCj4gPiBoYXJk d2FyZSB3aXRoIG9ubHkgdGhlIGJhc2UgcGxhdGZvcm0gc2VyaWVzLCB3aGljaCBJIGZvdW5kIHVz ZWZ1bC4KPgo+IFNlcmllcyBvciBoYWxmLW9mLXNlcmllcz8gQW55d2F5LCBjb21taXRzIG11c3Qg YmUgbG9naWNhbCBjaHVua3MsIHNvIG9uZQo+IGNodW5rIGlzIHRvIGFkZCBJMkMgY29udHJvbGxl cnMsIG5vdCAicGFydCBvZiBJMkMgY29udHJvbGxlcnMiLiBEVFMgaXMKPiBhbHNvIGluZGVwZW5k ZW50IG9mIGRyaXZlcnMgKGFuZCBpdCB3aWxsIGdvIHZpYSBkaWZmZXJlbnQgdHJlZXMhKSwgc28K PiB3aGF0ZXZlciBkZXBlbmRlbmN5IHlvdSB0aGluayBvZiwgaXQgZG9lcyBub3QgZXhpc3QuCgpN eSByZWFzb25pbmcgd2FzIGZvY3VzZWQgb24gbXkgcG9pbnQtb2YtdmlldyBhcyBhIGNvbnRyaWJ1 dG9yIGFuZCB0ZXN0ZXIKb2YgdGhlIHNlcmllcy4gWW91ciBleHBsYW5hdGlvbiBtYWtlcyBzZW5z ZTsgSSBoYWQgbmV2ZXIgdGhvdWdodCB0aGlzCnRocm91Z2ggZnJvbSB0aGUgbWFpbnRhaW5lcidz IFBPVi4KClRoYW5rcywKCi0tClRow6lvIExlYnJ1biwgQm9vdGxpbgpFbWJlZGRlZCBMaW51eCBh bmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9vdGxpbi5jb20KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK