Re: [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it

From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Mark Hasemeyer" <markhas@chromium.org>,
	"LKML" <linux-kernel@vger.kernel.org>
Cc: "AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Sudeep Holla" <sudeep.holla@arm.com>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Raul Rangel" <rrangel@chromium.org>,
	"Tzung-Bi Shih" <tzungbi@kernel.org>,
	"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
	"Alexandre TORGUE" <alexandre.torgue@st.com>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Andre Przywara" <andre.przywara@arm.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Baoquan He" <bhe@redhat.com>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Benson Leung" <bleung@chromium.org>,
	"Bhanu Prakash Maiya" <bhanumaiya@chromium.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Chen-Yu Tsai" <wenst@chromium.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Daniel Scally" <djrscally@gmail.com>,
	"David Gow" <davidgow@google.com>,
	"Enric Balletbo i Serra" <eballetbo@gmail.com>,
	"Frank Rowand" <frowand.list@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Guenter Roeck" <groeck@chromium.org>,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Lee Jones" <lee@kernel.org>, "Len Brown" <lenb@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Michal Simek" <michal.simek@amd.com>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Nick Hawkins" <nick.hawkins@hpe.com>,
	"Prashant Malani" <pmalani@chromium.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Rob Barnes" <robbarnes@google.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Stephen Boyd" <swboyd@chromium.org>,
	"Takashi Iwai" <tiwai@suse.de>,
	"Tony Lindgren" <tony@atomide.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Wolfram Sang" <wsa@kernel.org>,
	chrome-platform@lists.linux.dev,
	cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-i2c@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it
Date: Fri, 16 Feb 2024 12:31:03 +0100	[thread overview]
Message-ID: <CZ6GWUQ73SSL.6HP29PU9Q7R@gmail.com> (raw)
In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

On Tue Dec 26, 2023 at 8:21 PM CET, Mark Hasemeyer wrote:
> Currently the cros_ec driver assumes that its associated interrupt is
> wake capable. This is an incorrect assumption as some Chromebooks use a
> separate wake pin, while others overload the interrupt for wake and IO.
> This patch train updates the driver to query the underlying ACPI/DT data
> to determine whether or not the IRQ should be enabled for wake.
>
> Both the device tree and ACPI systems have methods for reporting IRQ
> wake capability. In device tree based systems, a node can advertise
> itself as a 'wakeup-source'. In ACPI based systems, GpioInt and
> Interrupt resource descriptors can use the 'SharedAndWake' or
> 'ExclusiveAndWake' share types.
>
> Some logic is added to the platform, ACPI, and DT subsystems to more
> easily pipe wakeirq information up to the driver.
>
> Changes in v3:
> -Rebase on linux-next
> -See each patch for patch specific changes
>
> Changes in v2:
> -Rebase on linux-next
> -Add cover letter
> -See each patch for patch specific changes
>
> Mark Hasemeyer (24):
[...]
>   ARM: dts: tegra: Enable cros-ec-spi as wake source
[...]
>   arm64: dts: tegra: Enable cros-ec-spi as wake source
[...]

Both patches applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]