From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicholas Piggin Date: Sat, 17 Feb 2024 17:19:54 +1000 Subject: [kvm-unit-tests PATCH v4 8/8] migration: add a migration selftest In-Reply-To: References: <20240209091134.600228-1-npiggin@gmail.com> <20240209091134.600228-9-npiggin@gmail.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri Feb 16, 2024 at 9:15 PM AEST, Thomas Huth wrote: > On 09/02/2024 10.11, Nicholas Piggin wrote: > > Add a selftest for migration support in guest library and test harness > > code. It performs migrations in a tight loop to irritate races and bugs > > in the test harness code. > > > > Include the test in arm, s390, powerpc. > > > > Acked-by: Claudio Imbrenda (s390x) > > Reviewed-by: Thomas Huth > > Signed-off-by: Nicholas Piggin > > --- > > arm/Makefile.common | 1 + > > arm/selftest-migration.c | 1 + > > arm/unittests.cfg | 6 ++++++ > > Hi Nicholas, > > I just gave the patches a try, but the arm test seems to fail for me: Only > the first getchar() seems to wait for a character, all the subsequent ones > don't wait anymore and just continue immediately ... is this working for > you? Or do I need another patch on top? Hey sorry missed this comment.... It does seem to work for me, I've mostly tested pseries but I did test others too (that's how I saw the arm getchar limit). How are you observing it not waiting for migration? I put some sleeps in the migration script before echo'ing to the console input and it seems to be doing the right thing. Admittedly the test contains no way to programaticaly verify the machine was migrated the expected number of times, it would be nice to try to match that up somehow. Thanks, Nick From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BF5733CA for ; Sat, 17 Feb 2024 07:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708154405; cv=none; b=jwsMTn/ExZE8+7oTFkfUhzij7YGoAMLav1Wn/NVpjdglsM9FgG9SvcwEm5BGVROw89SEDl+yNzsvLjjTF625SnYkNxNiunoNfFOYAWPGpPHbiZkqaLHA0lqDvR5VuUbDHOBhfdO98Uix7GjqyQBlSPE+ytswTMdwfJDAj+UwXRA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708154405; c=relaxed/simple; bh=0r/mcDX9INprGCcwU6dSv7nrT7Y62HTCBakDChmI/xs=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=oTGblXX3spPFds3eEJm/Dw5krR4YCC2TKUgQZcH5Tr2TGozJI/V0g02QO2HSiIn1qruDuA13zTBVk27MQoLeah7cBL7emZLiCmkw5A0nNn6nozXD+ivHJGf7KUGUazuRlNJgcSeO5hdRjDwBnKnpPpwhUjb2kgO0QSiaUd1m4dY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NXRNgPNO; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NXRNgPNO" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5d8b887bb0cso2293187a12.2 for ; Fri, 16 Feb 2024 23:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708154403; x=1708759203; darn=lists.linux.dev; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WfIxsLt7/ArIHKSH0XLbtdtiRdY5BKjg0yAd6fCtPMY=; b=NXRNgPNOHLfe7yg0YQXv3GsiVaLNQezejcGOA2/lA5EDsLd9skEHMxg8mRo0pRU4ct C062eOwFjcjBUAFASU0BiSO8LOGGUo2qyMMJ+zD7D1ZP0tL0mUcO5WfdLqJHjebxaZ1I 6LTPCXqmTMuQZ37aNLI7lZcWDb9Tbr+guNKZljSEm0WFQmT83k/PXBzG5XF6fkCHrYIx eoZeX//RJpEKvcKwjrM2P1bjQ4eSh0YRKvSfawYhynxhkjzAZjVCc27VBdkVQvDlJOVs 6XxRS1RCor2yhXzkWXHjeOJ2GFL7P8Ts+Ftd4eFXGQQT+ss8N79ua1wcTGM+PvjZQV1t 83qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708154403; x=1708759203; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WfIxsLt7/ArIHKSH0XLbtdtiRdY5BKjg0yAd6fCtPMY=; b=NevH3RT/9W8+3wRRRHRp++GoavQEqSOQEW5JTWXhODoopAyZOavzEIrTgiMIudpQXp AdSgaTh09UOBEf78mjwbyyz70e6M8M5oASM+4wpQp7PQdsmF0U5AMjxEmzYHpyOyIRl7 F7mpT5l8yGqxvZsQx/uFj7AmjG707cScmpidKknJ9aouCJph9O9VYPDLeYAZYOdzH988 ShKCQjPh+S8t+gLDcP0xJB4mIRxUl5D4MsQKOgCF2SqpljMNCeUZoyWj9soCfUYrR622 otqPbOxbCszdjrq518iMphNj6ytK2MOUpskY1VfE7HWnwu2xN2t35rdE3BZMO9HKnx/Q jN0g== X-Forwarded-Encrypted: i=1; AJvYcCUTaFxPsvXaEq8GeHZ3bMfQItcy5ql/WPEVlpDp3CQGik61Nk4QEF6BhFgTM61AC+pJsRrXFYmH7Q/WG7xjjchH7qfw8RtT X-Gm-Message-State: AOJu0YyIXf9ZViYT9AoAKajdLUwKZpOVABcKOYTeavl1uXsqFOmnrwyE cC1o2mutGMQ1wWwjow7kToMUhqpMTAxvUHbEq0+vzIhivURixtdZ X-Google-Smtp-Source: AGHT+IHeuo0k9fAN0txniwLyphYby2uu9UX6Hw/WFiRGnP8mxfVbUdCFutgfkGyqtdVbG1X9PA0DNg== X-Received: by 2002:a17:902:dad1:b0:1db:4df0:a31f with SMTP id q17-20020a170902dad100b001db4df0a31fmr8038401plx.6.1708154403370; Fri, 16 Feb 2024 23:20:03 -0800 (PST) Received: from localhost (123-243-155-241.static.tpgi.com.au. [123.243.155.241]) by smtp.gmail.com with ESMTPSA id w3-20020a170903310300b001db4f25b168sm868865plc.255.2024.02.16.23.19.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Feb 2024 23:20:02 -0800 (PST) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 17 Feb 2024 17:19:54 +1000 Message-Id: Cc: , "Laurent Vivier" , "Shaoqin Huang" , "Andrew Jones" , "Nico Boehr" , "Paolo Bonzini" , "Alexandru Elisei" , "Eric Auger" , "Janosch Frank" , "Claudio Imbrenda" , "David Hildenbrand" , "Marc Hartmayer" , , , , Subject: Re: [kvm-unit-tests PATCH v4 8/8] migration: add a migration selftest From: "Nicholas Piggin" To: "Thomas Huth" X-Mailer: aerc 0.15.2 References: <20240209091134.600228-1-npiggin@gmail.com> <20240209091134.600228-9-npiggin@gmail.com> In-Reply-To: On Fri Feb 16, 2024 at 9:15 PM AEST, Thomas Huth wrote: > On 09/02/2024 10.11, Nicholas Piggin wrote: > > Add a selftest for migration support in guest library and test harness > > code. It performs migrations in a tight loop to irritate races and bugs > > in the test harness code. > >=20 > > Include the test in arm, s390, powerpc. > >=20 > > Acked-by: Claudio Imbrenda (s390x) > > Reviewed-by: Thomas Huth > > Signed-off-by: Nicholas Piggin > > --- > > arm/Makefile.common | 1 + > > arm/selftest-migration.c | 1 + > > arm/unittests.cfg | 6 ++++++ > > Hi Nicholas, > > I just gave the patches a try, but the arm test seems to fail for me: Onl= y=20 > the first getchar() seems to wait for a character, all the subsequent one= s=20 > don't wait anymore and just continue immediately ... is this working for= =20 > you? Or do I need another patch on top? Hey sorry missed this comment.... It does seem to work for me, I've mostly tested pseries but I did test others too (that's how I saw the arm getchar limit). How are you observing it not waiting for migration? I put some sleeps in the migration script before echo'ing to the console input and it seems to be doing the right thing. Admittedly the test contains no way to programaticaly verify the machine was migrated the expected number of times, it would be nice to try to match that up somehow. Thanks, Nick From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74CDFC48BC3 for ; Sat, 17 Feb 2024 07:21:01 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=MCGruIJh; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TcKwD0Dw6z3c4C for ; Sat, 17 Feb 2024 18:21:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=MCGruIJh; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::62f; helo=mail-pl1-x62f.google.com; envelope-from=npiggin@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TcKvK2PNXz3btl for ; Sat, 17 Feb 2024 18:20:11 +1100 (AEDT) Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1dba94f9201so12305505ad.0 for ; Fri, 16 Feb 2024 23:20:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708154403; x=1708759203; darn=lists.ozlabs.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WfIxsLt7/ArIHKSH0XLbtdtiRdY5BKjg0yAd6fCtPMY=; b=MCGruIJhbFK8ZXsB6XdQbfzGEE9b3LIhACnUsE0cVhQZYncdT8gDgSWVrRrF2uyx9Y sMwYNZvoKsnz5Dg55kg/kJqqr96m3hYYGgVK44aq+nRmNBWDana+DtHmi8I64xrjzOGY sb/Z3wmHwfKiMCL7/zelA6dSJumDoXeslv3vj/39YIgbhsg/by2fdaSYLeHWmKNvXCAw 46roedb9Md0hHx4iQlzwZA2q5sgL3n7TDPq6weMqp8schN8+DaVFFCTTYqrPAUR92sYV MR8Lj6vHgwXL+ilg7TeGDCWXhcaAVD+8EBBEZG7rgPwk4u2dwZOBh+u5csnZD8jWX/cg u7fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708154403; x=1708759203; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WfIxsLt7/ArIHKSH0XLbtdtiRdY5BKjg0yAd6fCtPMY=; b=SpUl2IDYPL1BVNzFtOnR9cavn+4uKpPvg3FDqBG8zvdSuk5/As8hP2DQGFsNEd9hro WAXI2cZgS1LjDrEflUhAIRZpXzH10mqe+CMmNaPaIoD6hLVIFnaZ0ANo6OqUh6KK7wuj 3yfrnUbrkwTFQ2t+PdTAP65KxtkcEK1DRonAQozc1ulh4i2z1XyZO6NeITjfJ8ZNcLEg WiL3II8yyVH8+EocVmekPFDoVrvWKpUrSEglrHvuNBXQpaJqHAjZEK3TceJZSgX/7Bzh 5mepR87akc9nqrdWn0ncvls0utY63ejFL1Yh72A4+s94UXbvELkyAVlQP3twa5vc1a4f DCKQ== X-Forwarded-Encrypted: i=1; AJvYcCWnOTd+3KhtcMW2hStffTrsvhCXDDC2lHR7xDKnuyt8wvTjWHWNhhlkvk4Yj2RrdBjzzOksEE5tdRLBJGie6cNZjUhmBU0SFfmL74388w== X-Gm-Message-State: AOJu0YypGcQG6ERU9CKxrXOkuly+3ss0XEkowmVPKKP9pGumbFWhkB3Y KnQLBmkrTd6CXTkt3sMeMauNhYjHGygx36Hn67ql0DAk1mzGdx7o X-Google-Smtp-Source: AGHT+IHeuo0k9fAN0txniwLyphYby2uu9UX6Hw/WFiRGnP8mxfVbUdCFutgfkGyqtdVbG1X9PA0DNg== X-Received: by 2002:a17:902:dad1:b0:1db:4df0:a31f with SMTP id q17-20020a170902dad100b001db4df0a31fmr8038401plx.6.1708154403370; Fri, 16 Feb 2024 23:20:03 -0800 (PST) Received: from localhost (123-243-155-241.static.tpgi.com.au. [123.243.155.241]) by smtp.gmail.com with ESMTPSA id w3-20020a170903310300b001db4f25b168sm868865plc.255.2024.02.16.23.19.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Feb 2024 23:20:02 -0800 (PST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 17 Feb 2024 17:19:54 +1000 Message-Id: Subject: Re: [kvm-unit-tests PATCH v4 8/8] migration: add a migration selftest From: "Nicholas Piggin" To: "Thomas Huth" X-Mailer: aerc 0.15.2 References: <20240209091134.600228-1-npiggin@gmail.com> <20240209091134.600228-9-npiggin@gmail.com> In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , linux-s390@vger.kernel.org, Nico Boehr , Janosch Frank , kvm@vger.kernel.org, David Hildenbrand , linuxppc-dev@lists.ozlabs.org, Shaoqin Huang , Andrew Jones , Eric Auger , Marc Hartmayer , kvm-riscv@lists.infradead.org, kvmarm@lists.linux.dev, Paolo Bonzini , Claudio Imbrenda , Alexandru Elisei Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri Feb 16, 2024 at 9:15 PM AEST, Thomas Huth wrote: > On 09/02/2024 10.11, Nicholas Piggin wrote: > > Add a selftest for migration support in guest library and test harness > > code. It performs migrations in a tight loop to irritate races and bugs > > in the test harness code. > >=20 > > Include the test in arm, s390, powerpc. > >=20 > > Acked-by: Claudio Imbrenda (s390x) > > Reviewed-by: Thomas Huth > > Signed-off-by: Nicholas Piggin > > --- > > arm/Makefile.common | 1 + > > arm/selftest-migration.c | 1 + > > arm/unittests.cfg | 6 ++++++ > > Hi Nicholas, > > I just gave the patches a try, but the arm test seems to fail for me: Onl= y=20 > the first getchar() seems to wait for a character, all the subsequent one= s=20 > don't wait anymore and just continue immediately ... is this working for= =20 > you? Or do I need another patch on top? Hey sorry missed this comment.... It does seem to work for me, I've mostly tested pseries but I did test others too (that's how I saw the arm getchar limit). How are you observing it not waiting for migration? I put some sleeps in the migration script before echo'ing to the console input and it seems to be doing the right thing. Admittedly the test contains no way to programaticaly verify the machine was migrated the expected number of times, it would be nice to try to match that up somehow. Thanks, Nick