From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AEF737160; Mon, 19 Feb 2024 14:29:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708353002; cv=none; b=B32Y8fyB4wy0oN6faDdxxHC2zN6nT9jKMxDek8p/cW36xCDYmlOh6UDaPGSLD3t2F5H3xAeZlCRF0zLQl53Jto2BBJuc8TAuIYuWV2OFItinSPeSFxYeTM8GFnUSqFW1+oz64Iacqq73UjXhMveLd3aTaZYWwJ5BNGnWuOoDtuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708353002; c=relaxed/simple; bh=jSJtb19xo6U4wrKlOqq7IbDHuxWUa9am9jpce38A2yU=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=SOCZ5/inIpBqG5OXC7zIdmxNls9ThlbbSIDYI95iNpTyhduuYYAjdVC2mdDsoCAt/rlRbRfRnYJw3sRmJUUWY7qub/Z49V/4lYwoB3uFMdewtOLRaCHg12sevJj71sVv52HpIhRpvtTVH+8swtGLaOkIzZbeOyz3+5bRv1NkGpk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Y+Ri8PbE; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Y+Ri8PbE" Received: by mail.gandi.net (Postfix) with ESMTPSA id E74DE1BF209; Mon, 19 Feb 2024 14:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708352998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jSJtb19xo6U4wrKlOqq7IbDHuxWUa9am9jpce38A2yU=; b=Y+Ri8PbEfAVqHYxOyn7iqdOjgEFwTTgLg0MONT5WYr9Pt6gbz+NqkpWDcV/ZjfYuInJ9PT dopPyvTqtIusrhbip7t5fiYVk+sTGQktlAk8uT7Qg0QfMV8xXxjgWQZ4ip+gFuj6pY0IPt 5M/K17pKPtqTOdeueh+LFKt6b5PLLEkrGV0FVcmKJCsN3oChUhbPa2JUZyilf+xSyn1et+ UzAlUgnQjMAigrc2fnsfdl4zlWDCZjsucLO3uEgvwKlnZGmhqAKcPQZIqO6iWoHBESoJEU uKb6etT9INEcZyxkGvsGiWPO8I87me5hCW8S1QAyHAuVcxUARUStsP1mtLPcdg== Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 19 Feb 2024 15:29:57 +0100 Message-Id: From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH 01/13] dt-bindings: i2c: nomadik: add timeout-usecs property bindings Cc: "Rob Herring" , "Andi Shyti" , "Krzysztof Kozlowski" , "Conor Dooley" , "Thomas Bogendoerfer" , , , , , , "Gregory Clement" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Linus Walleij" X-Mailer: aerc 0.15.2 References: <20240215-mbly-i2c-v1-0-19a336e91dca@bootlin.com> <20240215-mbly-i2c-v1-1-19a336e91dca@bootlin.com> <20240216022704.GB850600-robh@kernel.org> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com Hello, On Mon Feb 19, 2024 at 3:06 PM CET, Linus Walleij wrote: > Hi Th=C3=A9o, > > thanks for your patch! > > On Fri, Feb 16, 2024 at 10:16=E2=80=AFAM Th=C3=A9o Lebrun wrote: > > > i2c-mpc (fsl,timeout) and i2c-gpio (i2c-gpio,timeout-ms). I agree this > > prop has no reason to be compatible-specific. > > > > Feedback from dt-bindings and I2C host maintainers would be useful: wha= t > > should the property be named? Having the unit makes it self-descriptive= , > > which sounds like a good idea to me. timeout-usecs, timeout-us, another > > option? > > Use i2c-transfer-timeout-ms in my opinion, so it us crystal clear > what that property is for. Using =C2=B5s (microseconds) would be OK? I'm not sure yet about the exact timeout desired but a one millisecond granularity might not be enough for the Mobileye usecase. Expect incoming patches to use the I2C controller in Fast Mode Plus (1Mbps) and High Speed Mode (3.4Mbps). Gotta go fast! > As Rob mentioned this isn't in the kernel schemas but in dtschema, so > you need to patch this: > https://github.com/robherring/dt-schema Indeed. The other question if we do microseconds is the suffix: -us, -usecs, -microseconds, etc? I picked -usecs for my v1, but a grep tells me I am the only user of this suffix. -us is much more common. BTW i2c-controller.yaml already has a =C2=B5s timeout: i2c-scl-clk-low-timeout-us Thanks, -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ------------------------------------------------------------------------ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6168C48BF8 for ; Mon, 19 Feb 2024 14:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:Cc:Subject: From:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w3s+SMGc2k8Dgm4R9VwtYvDOoDkgo+/nmS1as7FVnjE=; b=2V6NS1RNwIzpS6 vPQLaHo0NTNzYHwEPPR9cfab9OIRHpA+MP74zfg94J0GmuWm41Ks0XDWLQDgbB+DyGgbZJ4dbYmyr U1CYB8OdrcDoxbEJbMXy5b1ei9i1z9bTYs8bVY17noVxByI8pdwjfWK8E0hAQig/8W3OzrhGpagiK LlKT6f153WeKuaXtnOVmHxNsdR0q9GP0ic1aWFCrcPBPrgTntuMDhMKr9BpmG/OhcDChAPtPpX07u YTfoCKmreZYQ7q7OSUxzArUbnTMPtdru9E9/3/aOnPaQMeaVoUa9nSxZ+uZQ8VZyM5N21BhdzJD5A yC8/m29O+lQBEPIv/lng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc4eh-0000000Aq08-2lbt; Mon, 19 Feb 2024 14:30:03 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc4ee-0000000ApzP-2pjE for linux-arm-kernel@lists.infradead.org; Mon, 19 Feb 2024 14:30:02 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id E74DE1BF209; Mon, 19 Feb 2024 14:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708352998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jSJtb19xo6U4wrKlOqq7IbDHuxWUa9am9jpce38A2yU=; b=Y+Ri8PbEfAVqHYxOyn7iqdOjgEFwTTgLg0MONT5WYr9Pt6gbz+NqkpWDcV/ZjfYuInJ9PT dopPyvTqtIusrhbip7t5fiYVk+sTGQktlAk8uT7Qg0QfMV8xXxjgWQZ4ip+gFuj6pY0IPt 5M/K17pKPtqTOdeueh+LFKt6b5PLLEkrGV0FVcmKJCsN3oChUhbPa2JUZyilf+xSyn1et+ UzAlUgnQjMAigrc2fnsfdl4zlWDCZjsucLO3uEgvwKlnZGmhqAKcPQZIqO6iWoHBESoJEU uKb6etT9INEcZyxkGvsGiWPO8I87me5hCW8S1QAyHAuVcxUARUStsP1mtLPcdg== Mime-Version: 1.0 Date: Mon, 19 Feb 2024 15:29:57 +0100 Message-Id: From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH 01/13] dt-bindings: i2c: nomadik: add timeout-usecs property bindings Cc: "Rob Herring" , "Andi Shyti" , "Krzysztof Kozlowski" , "Conor Dooley" , "Thomas Bogendoerfer" , , , , , , "Gregory Clement" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Linus Walleij" X-Mailer: aerc 0.15.2 References: <20240215-mbly-i2c-v1-0-19a336e91dca@bootlin.com> <20240215-mbly-i2c-v1-1-19a336e91dca@bootlin.com> <20240216022704.GB850600-robh@kernel.org> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240219_063000_869114_737A24F8 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpPbiBNb24gRmViIDE5LCAyMDI0IGF0IDM6MDYgUE0gQ0VULCBMaW51cyBXYWxsZWlq IHdyb3RlOgo+IEhpIFRow6lvLAo+Cj4gdGhhbmtzIGZvciB5b3VyIHBhdGNoIQo+Cj4gT24gRnJp LCBGZWIgMTYsIDIwMjQgYXQgMTA6MTbigK9BTSBUaMOpbyBMZWJydW4gPHRoZW8ubGVicnVuQGJv b3RsaW4uY29tPiB3cm90ZToKPgo+ID4gaTJjLW1wYyAoZnNsLHRpbWVvdXQpIGFuZCBpMmMtZ3Bp byAoaTJjLWdwaW8sdGltZW91dC1tcykuIEkgYWdyZWUgdGhpcwo+ID4gcHJvcCBoYXMgbm8gcmVh c29uIHRvIGJlIGNvbXBhdGlibGUtc3BlY2lmaWMuCj4gPgo+ID4gRmVlZGJhY2sgZnJvbSBkdC1i aW5kaW5ncyBhbmQgSTJDIGhvc3QgbWFpbnRhaW5lcnMgd291bGQgYmUgdXNlZnVsOiB3aGF0Cj4g PiBzaG91bGQgdGhlIHByb3BlcnR5IGJlIG5hbWVkPyBIYXZpbmcgdGhlIHVuaXQgbWFrZXMgaXQg c2VsZi1kZXNjcmlwdGl2ZSwKPiA+IHdoaWNoIHNvdW5kcyBsaWtlIGEgZ29vZCBpZGVhIHRvIG1l LiB0aW1lb3V0LXVzZWNzLCB0aW1lb3V0LXVzLCBhbm90aGVyCj4gPiBvcHRpb24/Cj4KPiBVc2Ug aTJjLXRyYW5zZmVyLXRpbWVvdXQtbXMgaW4gbXkgb3Bpbmlvbiwgc28gaXQgdXMgY3J5c3RhbCBj bGVhcgo+IHdoYXQgdGhhdCBwcm9wZXJ0eSBpcyBmb3IuCgpVc2luZyDCtXMgKG1pY3Jvc2Vjb25k cykgd291bGQgYmUgT0s/IEknbSBub3Qgc3VyZSB5ZXQgYWJvdXQgdGhlIGV4YWN0CnRpbWVvdXQg ZGVzaXJlZCBidXQgYSBvbmUgbWlsbGlzZWNvbmQgZ3JhbnVsYXJpdHkgbWlnaHQgbm90IGJlIGVu b3VnaApmb3IgdGhlIE1vYmlsZXllIHVzZWNhc2UuCgpFeHBlY3QgaW5jb21pbmcgcGF0Y2hlcyB0 byB1c2UgdGhlIEkyQyBjb250cm9sbGVyIGluIEZhc3QgTW9kZSBQbHVzCigxTWJwcykgYW5kIEhp Z2ggU3BlZWQgTW9kZSAoMy40TWJwcykuIEdvdHRhIGdvIGZhc3QhCgo+IEFzIFJvYiBtZW50aW9u ZWQgdGhpcyBpc24ndCBpbiB0aGUga2VybmVsIHNjaGVtYXMgYnV0IGluIGR0c2NoZW1hLCBzbwo+ IHlvdSBuZWVkIHRvIHBhdGNoIHRoaXM6Cj4gaHR0cHM6Ly9naXRodWIuY29tL3JvYmhlcnJpbmcv ZHQtc2NoZW1hCgpJbmRlZWQuIFRoZSBvdGhlciBxdWVzdGlvbiBpZiB3ZSBkbyBtaWNyb3NlY29u ZHMgaXMgdGhlCnN1ZmZpeDogLXVzLCAtdXNlY3MsIC1taWNyb3NlY29uZHMsIGV0Yz8gSSBwaWNr ZWQgLXVzZWNzIGZvciBteSB2MSwgYnV0CmEgZ3JlcCB0ZWxscyBtZSBJIGFtIHRoZSBvbmx5IHVz ZXIgb2YgdGhpcyBzdWZmaXguIC11cyBpcyBtdWNoIG1vcmUKY29tbW9uLgoKQlRXIGkyYy1jb250 cm9sbGVyLnlhbWwgYWxyZWFkeSBoYXMgYSDCtXMgdGltZW91dDoKaTJjLXNjbC1jbGstbG93LXRp bWVvdXQtdXMKClRoYW5rcywKCi0tClRow6lvIExlYnJ1biwgQm9vdGxpbgpFbWJlZGRlZCBMaW51 eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9vdGxpbi5jb20KCi0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK