From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61E5E81742; Wed, 21 Feb 2024 16:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708531521; cv=none; b=E3IZV/llhIAWrPUm7EfcOBK1yxzQJfarfSR1wm9usgOkiL0WsauLbN7pjST/6i65dXe4BF5zl4/900YZWhsIEc2b1+LWhrW+TZcsRXrQsCqdzHi6ZqcPMB+elPZ3xySbw9Vt5c2DsH47zmSQAErYXmjlPH2FkLZOIycBMwpE3Uo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708531521; c=relaxed/simple; bh=4osHeqTpGZbNF+WwFOeN/1hOUN/aK+g+cz/1SRJB+9E=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=NdmFB497uoovKSCJN8K+jeSGbkBmpRtHwOjhz/+fcE5d34v32RZCL0O1wLfOjGIFrSDqNjEVLWZ4bJDs8xM2gOKeX1nVl7Kv4u9LG98PJqBV2Fr1yjMUBQ49gHTKDYmFRDBC/DmL6Yvmt7/K+FhpsO5mOYakmugOT9SEYp2izlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=jB2y2QNw; arc=none smtp.client-ip=217.70.183.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="jB2y2QNw" Received: by mail.gandi.net (Postfix) with ESMTPSA id DAA2EC0013; Wed, 21 Feb 2024 16:05:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708531516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KMfvDi1Z7NgcdHnP3iiFwTVbi7e7yWaAr0kgZz77890=; b=jB2y2QNwjiyNS83wMYPNJMm+XgYPGyoUtT68qdAcfISdumDjJnAr5ntNT7dGwok2HL4NFj 12GzGwCkAwWNFq+EbRQvj5zbXIGTQq7s2RzdCCfyaAOuibep9mEJpmFn5v5vlNzpf3Z8rX eWIh/K0nbUoWeTtZEm78NCgOVVzVPizrG2HQfW6I6HkiEpRLVrhScpd4/Ekg24F9nMTrGF vbsV+08topQMABL2LlP90n4ytitLV4/ihLVQx2w7plXfvhUON02JXjxPmNpf+tZb+TYUPk ZBs/cLF51a/rLam1ul/DfP0K+LmrRBXD7lUdgN8+UchNJJmbyAadX9gR4LDYbA== Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 21 Feb 2024 17:05:15 +0100 Message-Id: From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH 13/23] gpio: nomadik: fix offset bug in nmk_pmx_set() Cc: "Bartosz Golaszewski" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Philipp Zabel" , "Thomas Bogendoerfer" , , , , , , "Gregory CLEMENT" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Linus Walleij" X-Mailer: aerc 0.15.2 References: <20240214-mbly-gpio-v1-0-f88c0ccf372b@bootlin.com> <20240214-mbly-gpio-v1-13-f88c0ccf372b@bootlin.com> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com Hello, On Mon Feb 19, 2024 at 10:56 PM CET, Linus Walleij wrote: > On Wed, Feb 14, 2024 at 5:24=E2=80=AFPM Th=C3=A9o Lebrun wrote: > > > Previously, the statement looked like: > > > > slpm[x] &=3D ~BIT(g->pins[i]); > > > > Where: > > - slpm is a unsigned int pointer; > > - g->pins[i] is a pin number which can grow to more than 32. > > > > The expected shift amount is a pin bank offset. > > > > This bug does not occur on every group or pin: the altsetting must be > > NMK_GPIO_ALT_C and the pin must be 32 or above. It is possible that it > > occurred. For example, in pinctrl-nomadik-db8500.c, pin group i2c3_c_2 > > has the right altsetting and has pins 229 and 230. > > > > Signed-off-by: Th=C3=A9o Lebrun > > Ah good catch! > Reviewed-by: Linus Walleij > > I this something I could just apply as a fix or are there > dependencies on other patches? There are dependencies. As Bartosz and you asked, I'll try my best to avoid them and move this patch up in the series, with an appropriate Fixes: trailer (to the initial driver commit I believe). Thanks, -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B3F7C48BEB for ; Wed, 21 Feb 2024 16:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:Cc:Subject: From:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8vSW3+bm/Ejimq7wrR+aV0DMW10nX6f2dW2sdq4WmM8=; b=c33bEe6E+i3s1y /cg0j5cqZwUbanyDLClpiI5PrtitaF39Gew/8CW+XrGpnxB24pLZnKeI/eamX9f4kTPQ1RXbaOrSt /ZPWopRKcnVs1PWhSww/vvTp9QBEB8nQQuB3prmAaDFY2rELsoiVr4zhC9gpVxLVwkpKqmHtykpma kbSvq7N9aChxhUXu2qXoED4uISlRWBhPxU8ibIv6iPDxp/RNzticBXpkRa2VePNN18A7G6ViEtbHA BscMYxBT1PiPbjFDZ4UMy1suofgsz0D8hHoh4M/tAjkYib8QTj1GMMc9XYFZnZ75KFS0zLkZ79xrq QSOLEqx1DhN/eJ3ulsyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcp62-00000001dwW-03Ev; Wed, 21 Feb 2024 16:05:22 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcp5y-00000001duy-2HoO for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 16:05:20 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id DAA2EC0013; Wed, 21 Feb 2024 16:05:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708531516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KMfvDi1Z7NgcdHnP3iiFwTVbi7e7yWaAr0kgZz77890=; b=jB2y2QNwjiyNS83wMYPNJMm+XgYPGyoUtT68qdAcfISdumDjJnAr5ntNT7dGwok2HL4NFj 12GzGwCkAwWNFq+EbRQvj5zbXIGTQq7s2RzdCCfyaAOuibep9mEJpmFn5v5vlNzpf3Z8rX eWIh/K0nbUoWeTtZEm78NCgOVVzVPizrG2HQfW6I6HkiEpRLVrhScpd4/Ekg24F9nMTrGF vbsV+08topQMABL2LlP90n4ytitLV4/ihLVQx2w7plXfvhUON02JXjxPmNpf+tZb+TYUPk ZBs/cLF51a/rLam1ul/DfP0K+LmrRBXD7lUdgN8+UchNJJmbyAadX9gR4LDYbA== Mime-Version: 1.0 Date: Wed, 21 Feb 2024 17:05:15 +0100 Message-Id: From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH 13/23] gpio: nomadik: fix offset bug in nmk_pmx_set() Cc: "Bartosz Golaszewski" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Philipp Zabel" , "Thomas Bogendoerfer" , , , , , , "Gregory CLEMENT" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Linus Walleij" X-Mailer: aerc 0.15.2 References: <20240214-mbly-gpio-v1-0-f88c0ccf372b@bootlin.com> <20240214-mbly-gpio-v1-13-f88c0ccf372b@bootlin.com> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_080518_800504_2514045A X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpPbiBNb24gRmViIDE5LCAyMDI0IGF0IDEwOjU2IFBNIENFVCwgTGludXMgV2FsbGVp aiB3cm90ZToKPiBPbiBXZWQsIEZlYiAxNCwgMjAyNCBhdCA1OjI04oCvUE0gVGjDqW8gTGVicnVu IDx0aGVvLmxlYnJ1bkBib290bGluLmNvbT4gd3JvdGU6Cj4KPiA+IFByZXZpb3VzbHksIHRoZSBz dGF0ZW1lbnQgbG9va2VkIGxpa2U6Cj4gPgo+ID4gICAgIHNscG1beF0gJj0gfkJJVChnLT5waW5z W2ldKTsKPiA+Cj4gPiBXaGVyZToKPiA+ICAtIHNscG0gaXMgYSB1bnNpZ25lZCBpbnQgcG9pbnRl cjsKPiA+ICAtIGctPnBpbnNbaV0gaXMgYSBwaW4gbnVtYmVyIHdoaWNoIGNhbiBncm93IHRvIG1v cmUgdGhhbiAzMi4KPiA+Cj4gPiBUaGUgZXhwZWN0ZWQgc2hpZnQgYW1vdW50IGlzIGEgcGluIGJh bmsgb2Zmc2V0Lgo+ID4KPiA+IFRoaXMgYnVnIGRvZXMgbm90IG9jY3VyIG9uIGV2ZXJ5IGdyb3Vw IG9yIHBpbjogdGhlIGFsdHNldHRpbmcgbXVzdCBiZQo+ID4gTk1LX0dQSU9fQUxUX0MgYW5kIHRo ZSBwaW4gbXVzdCBiZSAzMiBvciBhYm92ZS4gSXQgaXMgcG9zc2libGUgdGhhdCBpdAo+ID4gb2Nj dXJyZWQuIEZvciBleGFtcGxlLCBpbiBwaW5jdHJsLW5vbWFkaWstZGI4NTAwLmMsIHBpbiBncm91 cCBpMmMzX2NfMgo+ID4gaGFzIHRoZSByaWdodCBhbHRzZXR0aW5nIGFuZCBoYXMgcGlucyAyMjkg YW5kIDIzMC4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBUaMOpbyBMZWJydW4gPHRoZW8ubGVicnVu QGJvb3RsaW4uY29tPgo+Cj4gQWggZ29vZCBjYXRjaCEKPiBSZXZpZXdlZC1ieTogTGludXMgV2Fs bGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8ub3JnPgo+Cj4gSSB0aGlzIHNvbWV0aGluZyBJIGNv dWxkIGp1c3QgYXBwbHkgYXMgYSBmaXggb3IgYXJlIHRoZXJlCj4gZGVwZW5kZW5jaWVzIG9uIG90 aGVyIHBhdGNoZXM/CgpUaGVyZSBhcmUgZGVwZW5kZW5jaWVzLiBBcyBCYXJ0b3N6IGFuZCB5b3Ug YXNrZWQsIEknbGwgdHJ5IG15IGJlc3QgdG8KYXZvaWQgdGhlbSBhbmQgbW92ZSB0aGlzIHBhdGNo IHVwIGluIHRoZSBzZXJpZXMsIHdpdGggYW4gYXBwcm9wcmlhdGUKRml4ZXM6IHRyYWlsZXIgKHRv IHRoZSBpbml0aWFsIGRyaXZlciBjb21taXQgSSBiZWxpZXZlKS4KClRoYW5rcywKCi0tClRow6lv IExlYnJ1biwgQm9vdGxpbgpFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0 dHBzOi8vYm9vdGxpbi5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK