From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC8313A1A2; Wed, 21 Feb 2024 16:22:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708532550; cv=none; b=X/l1Pv2VT92p+21zkp92TYZ01Jy93ScoeFUuCWhOVAqKFM+gFBa/XJ60NgSXEW9P+xEHWVs2LFCjkKKQSrU7T9b1Cp1tZcegZaaQ2mRoY9bGCTxca0YdtzFpdUuX4Jrmfb3L3OBY+c/2coiISIYcsx+uCvyLEfAn5iGDChEyqJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708532550; c=relaxed/simple; bh=kiiMrG6mntXHh6iDBqWOevebD5aCEfw6RRIXVCezYaY=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=iLTXi/35hNx4AMb/4oc5HJrwNd2xFtC5WS2971tbS4L0CZPuT7dWZiJ668NyZFOikkIV/nVtpVpAfAFGWFG9pIPg3CAKgeC01oLTxNiwrIRKYYWZEFcY+Zk/QNZdRHUR7s3i3A0gY2iURosDy4Q2Au4hqK9k+nBeB4rUQVJAxuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ojElP1EM; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ojElP1EM" Received: by mail.gandi.net (Postfix) with ESMTPSA id 3F42F20009; Wed, 21 Feb 2024 16:22:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708532546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oYNF6aBAFXnBwLIFV8DYWQPUG0yyBkNdFICAoB9FzHE=; b=ojElP1EMF86PODLDP9T4uBAGLfHZ1XkMqIJ3TaYZ+/sPvFdYH/gFLxXGAxPKV8NptsQnTm ne9p4VweZ0loVzt0Zxn9ZiI6AoEWxplApr8d3wULM3fpKnDLDrVwznE0qzkPi+DL97wyqp SDdPRyCGzk78gi88IJEK4ihGSwIVbuwsnSGU3Y/6bpNZIA9vxndaJXfUHFGVMvVSR2cKcU R7WBtOEJywKiZMahVoID7HQWx4ScEF838i1TO9vi3B2+kRwsFRNIMdgbFNrlGU2JJER12O kE4NnVSnabdhLkqzuN/FD7goeVkrZnRuu5J6waTx33AtumU8mre+3lTeJCobcQ== Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 21 Feb 2024 17:22:25 +0100 Message-Id: Subject: Re: [PATCH 18/23] gpio: nomadik: support mobileye,eyeq5-gpio Cc: "Bartosz Golaszewski" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Philipp Zabel" , "Thomas Bogendoerfer" , , , , , , "Gregory CLEMENT" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Linus Walleij" From: =?utf-8?q?Th=C3=A9o_Lebrun?= X-Mailer: aerc 0.15.2 References: <20240214-mbly-gpio-v1-0-f88c0ccf372b@bootlin.com> <20240214-mbly-gpio-v1-18-f88c0ccf372b@bootlin.com> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com Hello, On Wed Feb 21, 2024 at 2:45 PM CET, Linus Walleij wrote: > On Wed, Feb 14, 2024 at 5:24=E2=80=AFPM Th=C3=A9o Lebrun wrote: > > We create a custom compatible for the STA2X11 IP block as integrated > > into the Mobileye EyeQ5 platform. Its wake and alternate functions have > > been disabled, we want to avoid touching those registers. > > > > We both do: (1) early return in functions that do not support the > > platform, but with warnings, and (2) avoid calling those functions in > > the first place. > > > > We ensure that pinctrl-nomadik is not used with this STA2X11 variant. > > > > Signed-off-by: Th=C3=A9o Lebrun > (...) > >+ bool quirk_mbly; > > Compulsive abbreviation? I would just rename it: > > bool is_mobileye_soc; > > Nevermind the long name, it makes it crystal clear for readers > what is going on. (Rusty Russell's API naming guidelines.) > > With that changed: > Reviewed-by: Linus Walleij Makes complete sense. This is old heritage from my initial prototype that should have long gone disappeared. Thanks for your feedback & reviews! -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49452C48BC3 for ; Wed, 21 Feb 2024 16:22:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From:To:Cc: Subject:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tPyyKz07UfTHQtwXtUxZ26FU+bkkm+zr43CBI5ydqL4=; b=GruTc4E7RDN5eA aE6cAoNfMIONH9RAoQKlqwArAOtxpwD+QOKAiCrkcap8mMFDe9VSvsK1c152unJzRF4jDdXTMCso5 kroZi2Kr5L/looM2H7PMIEgTpNBcX8ZeBNLooWpGw+C+0tp4MH6K75DD8etiTPI/WC6Ow0SGkD2Wi HJ/IdwAWpWLeI6Pyop9QLevyz2Bc5o71vUc4m62yaJXPCgSAZVw7JaEuflRRcSUrAJK+40NBuohNM a+YoUj+GqUYnru6xHYyu1z2S1UVqy+USMXBK7xOCI+tkkwuC4WUL9uJOk9vsnzDLnX/y3y9rGFp7r CpxbphMc8uUmEA61+AwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcpMf-00000001h3Q-3Ce8; Wed, 21 Feb 2024 16:22:33 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcpMc-00000001h2X-2VE0 for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 16:22:32 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3F42F20009; Wed, 21 Feb 2024 16:22:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708532546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oYNF6aBAFXnBwLIFV8DYWQPUG0yyBkNdFICAoB9FzHE=; b=ojElP1EMF86PODLDP9T4uBAGLfHZ1XkMqIJ3TaYZ+/sPvFdYH/gFLxXGAxPKV8NptsQnTm ne9p4VweZ0loVzt0Zxn9ZiI6AoEWxplApr8d3wULM3fpKnDLDrVwznE0qzkPi+DL97wyqp SDdPRyCGzk78gi88IJEK4ihGSwIVbuwsnSGU3Y/6bpNZIA9vxndaJXfUHFGVMvVSR2cKcU R7WBtOEJywKiZMahVoID7HQWx4ScEF838i1TO9vi3B2+kRwsFRNIMdgbFNrlGU2JJER12O kE4NnVSnabdhLkqzuN/FD7goeVkrZnRuu5J6waTx33AtumU8mre+3lTeJCobcQ== Mime-Version: 1.0 Date: Wed, 21 Feb 2024 17:22:25 +0100 Message-Id: Subject: Re: [PATCH 18/23] gpio: nomadik: support mobileye,eyeq5-gpio Cc: "Bartosz Golaszewski" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Philipp Zabel" , "Thomas Bogendoerfer" , , , , , , "Gregory CLEMENT" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Linus Walleij" From: =?utf-8?q?Th=C3=A9o_Lebrun?= X-Mailer: aerc 0.15.2 References: <20240214-mbly-gpio-v1-0-f88c0ccf372b@bootlin.com> <20240214-mbly-gpio-v1-18-f88c0ccf372b@bootlin.com> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_082230_812337_58D1366F X-CRM114-Status: GOOD ( 15.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpPbiBXZWQgRmViIDIxLCAyMDI0IGF0IDI6NDUgUE0gQ0VULCBMaW51cyBXYWxsZWlq IHdyb3RlOgo+IE9uIFdlZCwgRmViIDE0LCAyMDI0IGF0IDU6MjTigK9QTSBUaMOpbyBMZWJydW4g PHRoZW8ubGVicnVuQGJvb3RsaW4uY29tPiB3cm90ZToKPiA+IFdlIGNyZWF0ZSBhIGN1c3RvbSBj b21wYXRpYmxlIGZvciB0aGUgU1RBMlgxMSBJUCBibG9jayBhcyBpbnRlZ3JhdGVkCj4gPiBpbnRv IHRoZSBNb2JpbGV5ZSBFeWVRNSBwbGF0Zm9ybS4gSXRzIHdha2UgYW5kIGFsdGVybmF0ZSBmdW5j dGlvbnMgaGF2ZQo+ID4gYmVlbiBkaXNhYmxlZCwgd2Ugd2FudCB0byBhdm9pZCB0b3VjaGluZyB0 aG9zZSByZWdpc3RlcnMuCj4gPgo+ID4gV2UgYm90aCBkbzogKDEpIGVhcmx5IHJldHVybiBpbiBm dW5jdGlvbnMgdGhhdCBkbyBub3Qgc3VwcG9ydCB0aGUKPiA+IHBsYXRmb3JtLCBidXQgd2l0aCB3 YXJuaW5ncywgYW5kICgyKSBhdm9pZCBjYWxsaW5nIHRob3NlIGZ1bmN0aW9ucyBpbgo+ID4gdGhl IGZpcnN0IHBsYWNlLgo+ID4KPiA+IFdlIGVuc3VyZSB0aGF0IHBpbmN0cmwtbm9tYWRpayBpcyBu b3QgdXNlZCB3aXRoIHRoaXMgU1RBMlgxMSB2YXJpYW50Lgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6 IFRow6lvIExlYnJ1biA8dGhlby5sZWJydW5AYm9vdGxpbi5jb20+Cj4gKC4uLikKPiA+KyAgICAg ICBib29sIHF1aXJrX21ibHk7Cj4KPiBDb21wdWxzaXZlIGFiYnJldmlhdGlvbj8gSSB3b3VsZCBq dXN0IHJlbmFtZSBpdDoKPgo+IGJvb2wgaXNfbW9iaWxleWVfc29jOwo+Cj4gTmV2ZXJtaW5kIHRo ZSBsb25nIG5hbWUsIGl0IG1ha2VzIGl0IGNyeXN0YWwgY2xlYXIgZm9yIHJlYWRlcnMKPiB3aGF0 IGlzIGdvaW5nIG9uLiAoUnVzdHkgUnVzc2VsbCdzIEFQSSBuYW1pbmcgZ3VpZGVsaW5lcy4pCj4K PiBXaXRoIHRoYXQgY2hhbmdlZDoKPiBSZXZpZXdlZC1ieTogTGludXMgV2FsbGVpaiA8bGludXMu d2FsbGVpakBsaW5hcm8ub3JnPgoKTWFrZXMgY29tcGxldGUgc2Vuc2UuIFRoaXMgaXMgb2xkIGhl cml0YWdlIGZyb20gbXkgaW5pdGlhbCBwcm90b3R5cGUKdGhhdCBzaG91bGQgaGF2ZSBsb25nIGdv bmUgZGlzYXBwZWFyZWQuCgpUaGFua3MgZm9yIHlvdXIgZmVlZGJhY2sgJiByZXZpZXdzIQoKLS0K VGjDqW8gTGVicnVuLCBCb290bGluCkVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJp bmcKaHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=