From: "Nicholas Piggin" <npiggin@gmail.com>
To: "BALATON Zoltan" <balaton@eik.bme.hu>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: <qemu-devel@nongnu.org>, <qemu-ppc@nongnu.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>, <clg@kaod.org>
Subject: Re: [PATCH v6 5/9] target/ppc: Simplify syscall exception handlers
Date: Tue, 27 Feb 2024 16:36:41 +1000 [thread overview]
Message-ID: <CZFNJGTBCAHX.2OZVSK9U6SH2V@wheely> (raw)
In-Reply-To: <b06a66b4-d31b-d106-1a4b-fcfc9e3bd1b2@eik.bme.hu>
On Thu Feb 22, 2024 at 10:20 PM AEST, BALATON Zoltan wrote:
> On Thu, 22 Feb 2024, Philippe Mathieu-Daudé wrote:
> > On 22/2/24 12:33, BALATON Zoltan wrote:
> >> After previous changes the hypercall handling in 7xx and 74xx
> >> exception handlers can be folded into one if statement to simpilfy
> >
> > "simplify"
> >
> >> this code. Also add "unlikely" to mark the less freqiently used branch
> >
> > "frequently"
>
> Could these be fixed up when merging please? I'd not resend again unless
> there's some other things need fixing.
Main thing was the gen_exception_err code shraing with sc. If you
wouldn't mind resending the series with all fixups. I'll plan to
get another ppc PR in before soft freeze in ~ 2 weeks so and I'll
grab this if possible.
Thanks,
Nick
next prev parent reply other threads:[~2024-02-27 6:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 11:33 [PATCH v6 0/9] Misc clean ups to target/ppc exception handling BALATON Zoltan
2024-02-22 11:33 ` [PATCH v6 1/9] target/ppc: Use env_cpu for cpu_abort in excp_helper BALATON Zoltan
2024-02-22 12:06 ` Philippe Mathieu-Daudé
2024-02-22 11:33 ` [PATCH v6 2/9] target/ppc: Readability improvements in exception handlers BALATON Zoltan
2024-02-22 11:33 ` [PATCH v6 3/9] target/ppc: Fix gen_sc to use correct nip BALATON Zoltan
2024-02-27 6:23 ` Nicholas Piggin
2024-02-22 11:33 ` [PATCH v6 4/9] target/ppc: Move patching nip from exception handler to helper_scv BALATON Zoltan
2024-02-22 11:33 ` [PATCH v6 5/9] target/ppc: Simplify syscall exception handlers BALATON Zoltan
2024-02-22 12:09 ` Philippe Mathieu-Daudé
2024-02-22 12:20 ` BALATON Zoltan
2024-02-27 6:36 ` Nicholas Piggin [this message]
2024-02-27 6:32 ` Nicholas Piggin
2024-02-22 11:34 ` [PATCH v6 6/9] target/ppc: Clean up ifdefs in excp_helper.c, part 1 BALATON Zoltan
2024-02-22 11:34 ` [PATCH v6 7/9] target/ppc: Clean up ifdefs in excp_helper.c, part 2 BALATON Zoltan
2024-02-22 11:34 ` [PATCH v6 8/9] target/ppc: Clean up ifdefs in excp_helper.c, part 3 BALATON Zoltan
2024-02-22 11:34 ` [PATCH v6 9/9] target/ppc: Remove interrupt handler wrapper functions BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZFNJGTBCAHX.2OZVSK9U6SH2V@wheely \
--to=npiggin@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.