From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4523B78B61; Tue, 27 Feb 2024 13:38:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709041125; cv=none; b=kHkLaD4VVHf8/b8sICjEe7j42wRsna2DOYkWL8zuKA2QUTqcF13Q7XlMuXBNKmBHOJihk5T3JI3p06lHM2QVCbpHwftpi1cPxG6XeqiZI/t2VRbUoYin2JQzVnb+41nKskKZ+2qvwsyRTvAEGbPSPZ/Nu845SQoXxzAYoz0uuBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709041125; c=relaxed/simple; bh=Ad3s8txV/LRKTi3+KCXHUIgZVNfAZ9S2VAZ3ew4nrfE=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=cOeh57Dc1AWTwyOMGig60WauZRu/SvzKXRAio42hrVkBkOVHHEcEC+FWKmQDrix54IRwaZgF7jquNJYuKAXHP1cGkXyAf6VFLGTsMzkv3wlNwQ3AYSheOEbE0i8sTUsMu/KuhB6uCeBPzEVmV2Sfi7c4Wzroarp51ZOVywUcFu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=L3nHvMeK; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="L3nHvMeK" Received: by mail.gandi.net (Postfix) with ESMTPSA id A454D24000A; Tue, 27 Feb 2024 13:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709041120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ugB9QxiL2b1VXZ64TujSRaUb9sqfq1WG8mbx8ms1t8=; b=L3nHvMeKugiy6LAMcXCUL40zZFkFyG3stQRCERhiPdxJe3E0Hmzaxmc4okAgDcBr9U4dce MabFzn95ayqAVbsXsICU+hIghagnyW62tfkH76EGxaxLevNTkTGL7T6XXxpG7c70YJRida FsCqgDEloarSSvHd4W++4CkZQYK7cLR9DS9kgJNX3q+JzZ5uiocuE4/suGqZXVocBmi8S2 gL/nime4cLazyjWSWNAtEfsIqac3zN1ZGMiosIt069itDFdoNzDLaRnxFTn69FLMXouH+X PzS/pk0jhfoT+W4YHIa8JMziWyCDQXmifs9+5/3Jp5yBpS8z6kKpuNkqLvZG2A== Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 27 Feb 2024 14:38:39 +0100 Message-Id: Subject: Re: [PATCH 09/13] i2c: nomadik: fetch timeout-usecs property from devicetree Cc: "Linus Walleij" , "Andi Shyti" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Thomas Bogendoerfer" , , , , , , "Gregory Clement" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Wolfram Sang" From: =?utf-8?q?Th=C3=A9o_Lebrun?= X-Mailer: aerc 0.15.2 References: <20240215-mbly-i2c-v1-0-19a336e91dca@bootlin.com> <20240215-mbly-i2c-v1-9-19a336e91dca@bootlin.com> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com Hello, On Tue Feb 27, 2024 at 1:14 PM CET, Wolfram Sang wrote: > > + /* Slave response timeout */ > > + if (!of_property_read_u32(np, "timeout-usecs", &timeout_usecs)) > > + priv->timeout_usecs =3D timeout_usecs; > > + else > > + priv->timeout_usecs =3D 200 * USEC_PER_MSEC; > > I could imagine to add 'transfer_timeout_us' to struct i2c_timings. > Then, you could use 'i2c_parse_fw_timings' to obtain the value. What > values/value range do you use here? I can't find them in the DTS > additions. That sounds good. I have not used this prop in the DTS as it does not make much sense for an eval board. The target is production boards. An order of magnitude is a few transfers every 15ms. It means a timeout of 15ms divided by "a few". I don't have more precise values, but I could if you consider it useful. I've done some testing at 50~100=C2=B5s timeouts and it works as expected. = At those values timerslack is important to consider (default of 50=C2=B5s). This is at 400kHz clock frequency. Keep in mind the controllers support up to 3.4MHz (not yet upstreamed) so timeouts could in theory go lower if required by the usecase. My upcoming question is how to move forward on this series. I can do the patch to i2c_parse_fw_timings() in the next revision. That way it gets added alongside the first user of this feature. Would it work for you? Thanks, -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0035C5478C for ; Tue, 27 Feb 2024 13:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From:To:Cc: Subject:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iGiv/QZV0xr3htzrKseg4jj+AHxKM/RN1PZNtH9ZLxo=; b=EKfBhteA+bkhZL raADBILJcUBx4X9iZ4JSFp7DTVmMJ70Ta4gYmd8cQ6h7BhLbQ85Y6seDsGLciwuKD9jw69fiE5eTG SjwxCBtOe0kTUbVpAepWpp90WcI/ZnQuo7P/7amM7++3/jijV87CN+XnDB+aCobZnBaLQhCT0DkIv 8V0DFmzzvbricrqamVWFNUOWv5G686SlOriilUCK+0Z/U/MIcv1QbURiofEuymALrKobl1EPn1MuL BgXv92lVSOqjwHD3oaXvweuRsD/WByx2OspwKfMKHoRtbB4Fv3u0GS8/depF+oiuon0TRsw+Qjddr Q+omjpUdjl8boAv00dkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rexfT-00000005PkK-0FGk; Tue, 27 Feb 2024 13:38:47 +0000 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rexfQ-00000005PjM-0HvY for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 13:38:45 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id A454D24000A; Tue, 27 Feb 2024 13:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709041120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ugB9QxiL2b1VXZ64TujSRaUb9sqfq1WG8mbx8ms1t8=; b=L3nHvMeKugiy6LAMcXCUL40zZFkFyG3stQRCERhiPdxJe3E0Hmzaxmc4okAgDcBr9U4dce MabFzn95ayqAVbsXsICU+hIghagnyW62tfkH76EGxaxLevNTkTGL7T6XXxpG7c70YJRida FsCqgDEloarSSvHd4W++4CkZQYK7cLR9DS9kgJNX3q+JzZ5uiocuE4/suGqZXVocBmi8S2 gL/nime4cLazyjWSWNAtEfsIqac3zN1ZGMiosIt069itDFdoNzDLaRnxFTn69FLMXouH+X PzS/pk0jhfoT+W4YHIa8JMziWyCDQXmifs9+5/3Jp5yBpS8z6kKpuNkqLvZG2A== Mime-Version: 1.0 Date: Tue, 27 Feb 2024 14:38:39 +0100 Message-Id: Subject: Re: [PATCH 09/13] i2c: nomadik: fetch timeout-usecs property from devicetree Cc: "Linus Walleij" , "Andi Shyti" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Thomas Bogendoerfer" , , , , , , "Gregory Clement" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Wolfram Sang" From: =?utf-8?q?Th=C3=A9o_Lebrun?= X-Mailer: aerc 0.15.2 References: <20240215-mbly-i2c-v1-0-19a336e91dca@bootlin.com> <20240215-mbly-i2c-v1-9-19a336e91dca@bootlin.com> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_053844_271445_249B3CF8 X-CRM114-Status: GOOD ( 15.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpPbiBUdWUgRmViIDI3LCAyMDI0IGF0IDE6MTQgUE0gQ0VULCBXb2xmcmFtIFNhbmcg d3JvdGU6Cj4gPiArCS8qIFNsYXZlIHJlc3BvbnNlIHRpbWVvdXQgKi8KPiA+ICsJaWYgKCFvZl9w cm9wZXJ0eV9yZWFkX3UzMihucCwgInRpbWVvdXQtdXNlY3MiLCAmdGltZW91dF91c2VjcykpCj4g PiArCQlwcml2LT50aW1lb3V0X3VzZWNzID0gdGltZW91dF91c2VjczsKPiA+ICsJZWxzZQo+ID4g KwkJcHJpdi0+dGltZW91dF91c2VjcyA9IDIwMCAqIFVTRUNfUEVSX01TRUM7Cj4KPiBJIGNvdWxk IGltYWdpbmUgdG8gYWRkICd0cmFuc2Zlcl90aW1lb3V0X3VzJyB0byBzdHJ1Y3QgaTJjX3RpbWlu Z3MuCj4gVGhlbiwgeW91IGNvdWxkIHVzZSAnaTJjX3BhcnNlX2Z3X3RpbWluZ3MnIHRvIG9idGFp biB0aGUgdmFsdWUuIFdoYXQKPiB2YWx1ZXMvdmFsdWUgcmFuZ2UgZG8geW91IHVzZSBoZXJlPyBJ IGNhbid0IGZpbmQgdGhlbSBpbiB0aGUgRFRTCj4gYWRkaXRpb25zLgoKVGhhdCBzb3VuZHMgZ29v ZC4gSSBoYXZlIG5vdCB1c2VkIHRoaXMgcHJvcCBpbiB0aGUgRFRTIGFzIGl0IGRvZXMgbm90Cm1h a2UgbXVjaCBzZW5zZSBmb3IgYW4gZXZhbCBib2FyZC4gVGhlIHRhcmdldCBpcyBwcm9kdWN0aW9u IGJvYXJkcy4KCkFuIG9yZGVyIG9mIG1hZ25pdHVkZSBpcyBhIGZldyB0cmFuc2ZlcnMgZXZlcnkg MTVtcy4gSXQgbWVhbnMgYSB0aW1lb3V0Cm9mIDE1bXMgZGl2aWRlZCBieSAiYSBmZXciLiBJIGRv bid0IGhhdmUgbW9yZSBwcmVjaXNlIHZhbHVlcywgYnV0IEkKY291bGQgaWYgeW91IGNvbnNpZGVy IGl0IHVzZWZ1bC4KCkkndmUgZG9uZSBzb21lIHRlc3RpbmcgYXQgNTB+MTAwwrVzIHRpbWVvdXRz IGFuZCBpdCB3b3JrcyBhcyBleHBlY3RlZC4gQXQKdGhvc2UgdmFsdWVzIHRpbWVyc2xhY2sgaXMg aW1wb3J0YW50IHRvIGNvbnNpZGVyIChkZWZhdWx0IG9mIDUwwrVzKS4KVGhpcyBpcyBhdCA0MDBr SHogY2xvY2sgZnJlcXVlbmN5LiBLZWVwIGluIG1pbmQgdGhlIGNvbnRyb2xsZXJzIHN1cHBvcnQK dXAgdG8gMy40TUh6IChub3QgeWV0IHVwc3RyZWFtZWQpIHNvIHRpbWVvdXRzIGNvdWxkIGluIHRo ZW9yeSBnbwpsb3dlciBpZiByZXF1aXJlZCBieSB0aGUgdXNlY2FzZS4KCk15IHVwY29taW5nIHF1 ZXN0aW9uIGlzIGhvdyB0byBtb3ZlIGZvcndhcmQgb24gdGhpcyBzZXJpZXMuIEkgY2FuIGRvIHRo ZQpwYXRjaCB0byBpMmNfcGFyc2VfZndfdGltaW5ncygpIGluIHRoZSBuZXh0IHJldmlzaW9uLiBU aGF0IHdheSBpdCBnZXRzCmFkZGVkIGFsb25nc2lkZSB0aGUgZmlyc3QgdXNlciBvZiB0aGlzIGZl YXR1cmUuIFdvdWxkIGl0IHdvcmsgZm9yIHlvdT8KClRoYW5rcywKCi0tClRow6lvIExlYnJ1biwg Qm9vdGxpbgpFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9v dGxpbi5jb20KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==