From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EFE01B7F3; Mon, 4 Mar 2024 09:46:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709545595; cv=none; b=GuyjDDxjquQvooJOrmAlFUhk2BwnoYuzVfJSUzALPSrKF8PB3+zyct0H1rUtPPFLZUCqXCQqawQYupdTScOyYBPjdgrLvJ+imaXyQjsIXFYhCaw1ZgUGoLHBKx4xLodHw89+d5p2pF9qcWTP2emsiCP8Nd2LHUdfm4Z8lrhM8zc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709545595; c=relaxed/simple; bh=anUB/OBSNGm/JeFQNlRuNFLtUQHaQ9D8+eh1w3c3q18=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=Sg3CWZcwnKmAIYuR55o4+eeuT37KeDEFitV+7j5ku6HnY5kyTLOLIkNvTjEaLhWmeqdpThJQaIbWBcmrgvaDkjTEwrNmi2quKgC+emPTAtoBHz6p8clLiGnF2M9CWTZ+QgftfSxb3yU0IZxglGOgCC0XGF85Bi8FQrX2Zqy/1/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=U2hJjhPf; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="U2hJjhPf" Received: by mail.gandi.net (Postfix) with ESMTPSA id 11E9C1C000B; Mon, 4 Mar 2024 09:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709545590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+obVxPBVye59ep/rc+NawmN0v65caHupg9rcnFDhO04=; b=U2hJjhPfJOybFyQT4y93sxpTKV9BVq+ROnsiqrseqLuHyo3Algc9QmEqF78XZW4vw+nps0 hqWxOQFFeHpDSPWMuAWRgoV0kPPh34RzLGGX7Y3V8H98/CYTX5UI3Ihs5mkHSpV6SuRKRl aL0SZKJz+mA6n1G1HOhWuWgtl5rKiVNGqKWVUbTPUmSE/ZOIdnaMdy+t3UhOMwI1UCnsu/ L+vQTaNYK2HGkHlEftlk/loHRTWUQyI1EY3XAaP7nfI5vN2mPQvSiWp0feResi5kFwVzwh CDcUL78cCvMYjMlMm0LY1DY9wrLf/okIjsoRCL+BrkliozmRxEpBTh/m3ZSAnA== Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 04 Mar 2024 10:46:26 +0100 Message-Id: Subject: Re: [SPAM] [PATCH v2 04/11] i2c: nomadik: simplify IRQ masking logic Cc: "Linus Walleij" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Thomas Bogendoerfer" , , , , , , "Gregory Clement" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Andi Shyti" From: =?utf-8?q?Th=C3=A9o_Lebrun?= X-Mailer: aerc 0.15.2 References: <20240229-mbly-i2c-v2-0-b32ed18c098c@bootlin.com> <20240229-mbly-i2c-v2-4-b32ed18c098c@bootlin.com> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com Hello, On Sat Mar 2, 2024 at 1:39 AM CET, Andi Shyti wrote: > On Thu, Feb 29, 2024 at 07:10:52PM +0100, Th=C3=A9o Lebrun wrote: > > IRQ_MASK and I2C_CLEAR_ALL_INTS are redundant. One masks the top three > > if I2C_CLEAR_ALL_INTS is redundant why don't you remove it? I understand this is unclear. What I meant by redundant is that they are redundant from one another; one overlaps the other. I'll give a better commit description for v3. Something like: IRQ_MASK and I2C_CLEAR_ALL_INTS both mask available interrupts. IRQ_MASK removes top options (bits 29-31). I2C_CLEAR_ALL_INTS removes reserved options including top bits. Keep the latter. 31 29 27 25 23 21 19 17 15 13 11 09 07 05 03 01 30 28 26 24 22 20 18 16 14 12 10 08 06 04 02 00 --- IRQ_MASK: -------------------------------------------------- 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 0 0 0 --- I2C_CLEAR_ALL_INTS: ---------------------------------------- 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 Notice I2C_CLEAR_ALL_INTS is more restrictive than IRQ_MASK. Is that better? > > bits off as reserved, the other one masks the reserved IRQs inside the > > u32. Get rid of IRQ_MASK and only use the most restrictive mask. > > Why is IRQ_MASK redundant? What happens if you write in the > reserved bits? The wording wasn't correct. Have I answered your question from the above? Thanks Andi, -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35684C48BF6 for ; Mon, 4 Mar 2024 10:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From:To:Cc: Subject:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qbWAEX43hhhJE7xUwpjkFIrmeS5CtXG6Tdt2DtCIWUw=; b=sVyz8W/KybUz81 h8j5JonRiKzTV4mJU7TlY0CaWWEst4xdYz1CYZl9x9pJh7ESvteVx5bgmVbIuR0ezCgYH81tFnL1w rfqBUjdQGZHlUu8tMS8XHN8nGrAywjxc5v4ea1n6b/0Ssrn/rZNcZsmzn0JVp3igzWoqUoML0rw6U fL6PiDhyS4b8xi8VAdC6hQO4xNR/ai4X/PGaZnjr4+mPxLm7omyLW1nuDb9nwFKOhxzCdT1QneJzZ 9KeS58x/wlgQ9/lN3LdJD+FMVtQDaX1XvJZpfTjwduiA+U2eYUARZCh6vyENgX5uVLdCzdFB2+fpP qlYiTkF2Fqb1Ze4ksCsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh5Z8-00000008bgH-48v9; Mon, 04 Mar 2024 10:29:03 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh4u7-00000008UAm-2lNX for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 09:46:46 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 11E9C1C000B; Mon, 4 Mar 2024 09:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709545590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+obVxPBVye59ep/rc+NawmN0v65caHupg9rcnFDhO04=; b=U2hJjhPfJOybFyQT4y93sxpTKV9BVq+ROnsiqrseqLuHyo3Algc9QmEqF78XZW4vw+nps0 hqWxOQFFeHpDSPWMuAWRgoV0kPPh34RzLGGX7Y3V8H98/CYTX5UI3Ihs5mkHSpV6SuRKRl aL0SZKJz+mA6n1G1HOhWuWgtl5rKiVNGqKWVUbTPUmSE/ZOIdnaMdy+t3UhOMwI1UCnsu/ L+vQTaNYK2HGkHlEftlk/loHRTWUQyI1EY3XAaP7nfI5vN2mPQvSiWp0feResi5kFwVzwh CDcUL78cCvMYjMlMm0LY1DY9wrLf/okIjsoRCL+BrkliozmRxEpBTh/m3ZSAnA== Mime-Version: 1.0 Date: Mon, 04 Mar 2024 10:46:26 +0100 Message-Id: Subject: Re: [SPAM] [PATCH v2 04/11] i2c: nomadik: simplify IRQ masking logic Cc: "Linus Walleij" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Thomas Bogendoerfer" , , , , , , "Gregory Clement" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Andi Shyti" From: =?utf-8?q?Th=C3=A9o_Lebrun?= X-Mailer: aerc 0.15.2 References: <20240229-mbly-i2c-v2-0-b32ed18c098c@bootlin.com> <20240229-mbly-i2c-v2-4-b32ed18c098c@bootlin.com> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_014644_316161_7C520ABF X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpPbiBTYXQgTWFyIDIsIDIwMjQgYXQgMTozOSBBTSBDRVQsIEFuZGkgU2h5dGkgd3Jv dGU6Cj4gT24gVGh1LCBGZWIgMjksIDIwMjQgYXQgMDc6MTA6NTJQTSArMDEwMCwgVGjDqW8gTGVi cnVuIHdyb3RlOgo+ID4gSVJRX01BU0sgYW5kIEkyQ19DTEVBUl9BTExfSU5UUyBhcmUgcmVkdW5k YW50LiBPbmUgbWFza3MgdGhlIHRvcCB0aHJlZQo+Cj4gaWYgSTJDX0NMRUFSX0FMTF9JTlRTIGlz IHJlZHVuZGFudCB3aHkgZG9uJ3QgeW91IHJlbW92ZSBpdD8KCkkgdW5kZXJzdGFuZCB0aGlzIGlz IHVuY2xlYXIuIFdoYXQgSSBtZWFudCBieSByZWR1bmRhbnQgaXMgdGhhdCB0aGV5IGFyZQpyZWR1 bmRhbnQgZnJvbSBvbmUgYW5vdGhlcjsgb25lIG92ZXJsYXBzIHRoZSBvdGhlci4gSSdsbCBnaXZl IGEgYmV0dGVyCmNvbW1pdCBkZXNjcmlwdGlvbiBmb3IgdjMuIFNvbWV0aGluZyBsaWtlOgoKICAg SVJRX01BU0sgYW5kIEkyQ19DTEVBUl9BTExfSU5UUyBib3RoIG1hc2sgYXZhaWxhYmxlIGludGVy cnVwdHMuCiAgIElSUV9NQVNLIHJlbW92ZXMgdG9wIG9wdGlvbnMgKGJpdHMgMjktMzEpLiBJMkNf Q0xFQVJfQUxMX0lOVFMKICAgcmVtb3ZlcyByZXNlcnZlZCBvcHRpb25zIGluY2x1ZGluZyB0b3Ag Yml0cy4gS2VlcCB0aGUgbGF0dGVyLgoKICAgMzEgIDI5ICAyNyAgMjUgIDIzICAyMSAgMTkgIDE3 ICAxNSAgMTMgIDExICAwOSAgMDcgIDA1ICAwMyAgMDEKICAgICAzMCAgMjggIDI2ICAyNCAgMjIg IDIwICAxOCAgMTYgIDE0ICAxMiAgMTAgIDA4ICAwNiAgMDQgIDAyICAwMAogICAtLS0gSVJRX01B U0s6IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAg ICAgICAgICAxIDEgMSAxIDEgMSAxIDEgMSAxIDEgMSAxIDEgMSAxIDEgMSAxIDEgMSAxIDEgMSAx IDEgMSAxIDEKICAgIDAgMCAwCiAgIC0tLSBJMkNfQ0xFQVJfQUxMX0lOVFM6IC0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICAgICAgICAgIDEgICAgIDEgMSAgICAgICAx IDEgMSAxIDEgICAgICAgICAgICAgICAgICAgMSAxIDEgMSAxIDEgMQogICAgMCAwIDAgICAwIDAg ICAgIDAgMCAwICAgICAgICAgICAwIDAgMCAwIDAgMCAwIDAgMAoKICAgIE5vdGljZSBJMkNfQ0xF QVJfQUxMX0lOVFMgaXMgbW9yZSByZXN0cmljdGl2ZSB0aGFuIElSUV9NQVNLLgoKSXMgdGhhdCBi ZXR0ZXI/Cgo+ID4gYml0cyBvZmYgYXMgcmVzZXJ2ZWQsIHRoZSBvdGhlciBvbmUgbWFza3MgdGhl IHJlc2VydmVkIElSUXMgaW5zaWRlIHRoZQo+ID4gdTMyLiBHZXQgcmlkIG9mIElSUV9NQVNLIGFu ZCBvbmx5IHVzZSB0aGUgbW9zdCByZXN0cmljdGl2ZSBtYXNrLgo+Cj4gV2h5IGlzIElSUV9NQVNL IHJlZHVuZGFudD8gV2hhdCBoYXBwZW5zIGlmIHlvdSB3cml0ZSBpbiB0aGUKPiByZXNlcnZlZCBi aXRzPwoKVGhlIHdvcmRpbmcgd2Fzbid0IGNvcnJlY3QuIEhhdmUgSSBhbnN3ZXJlZCB5b3VyCnF1 ZXN0aW9uIGZyb20gdGhlIGFib3ZlPwoKVGhhbmtzIEFuZGksCgotLQpUaMOpbyBMZWJydW4sIEJv b3RsaW4KRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3Rs aW4uY29tCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=