All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Hanjun Guo <hanjun.guo@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Aaron Lu <aaron.lu@intel.com>,
	Max Eliaser <max.eliaser@intel.com>,
	linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/9] ACPI: Add support for device specific properties
Date: Mon, 18 Aug 2014 07:37:18 -0500	[thread overview]
Message-ID: <D0175D3C.A1C92%dvhart@linux.intel.com> (raw)
In-Reply-To: <20140818082656.GR2462@lahna.fi.intel.com>

On 8/18/14, 3:27, "Mika Westerberg" <mika.westerberg@linux.intel.com>
wrote:

>On Mon, Aug 18, 2014 at 04:13:29PM +0800, Hanjun Guo wrote:

Hi Hanjun,

Thanks for reviewing!

>>
>> > +/* ACPI _DSD device properties UUID:
>>daffd814-6eba-4d8c-8a91-bc9bbf4aa301 */
>> > +static const u8 prp_uuid[16] = {
>> 
>> s/prp_uuid/dsd_uuid ?
>
>Well, it is actually the _DSD UUID that implements ACPI device
>properties (hence the prp_) but I have no problems in changing that to
>dsd_uuid instead.

The distinction is important. DSD does not define a format, the UUID does,
and there can be many - although we are adding support specifically for
one. The PRP name here also pairs with the PRP0000 HID.

-- 
Darren Hart					Open Source Technology Center
darren.hart@intel.com				            Intel Corporation




WARNING: multiple messages have this Message-ID (diff)
From: Darren Hart <dvhart@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Hanjun Guo <hanjun.guo@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Aaron Lu <aaron.lu@intel.com>,
	Max Eliaser <max.eliaser@intel.com>, <linux-acpi@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/9] ACPI: Add support for device specific properties
Date: Mon, 18 Aug 2014 07:37:18 -0500	[thread overview]
Message-ID: <D0175D3C.A1C92%dvhart@linux.intel.com> (raw)
In-Reply-To: <20140818082656.GR2462@lahna.fi.intel.com>

On 8/18/14, 3:27, "Mika Westerberg" <mika.westerberg@linux.intel.com>
wrote:

>On Mon, Aug 18, 2014 at 04:13:29PM +0800, Hanjun Guo wrote:

Hi Hanjun,

Thanks for reviewing!

>>
>> > +/* ACPI _DSD device properties UUID:
>>daffd814-6eba-4d8c-8a91-bc9bbf4aa301 */
>> > +static const u8 prp_uuid[16] = {
>> 
>> s/prp_uuid/dsd_uuid ?
>
>Well, it is actually the _DSD UUID that implements ACPI device
>properties (hence the prp_) but I have no problems in changing that to
>dsd_uuid instead.

The distinction is important. DSD does not define a format, the UUID does,
and there can be many - although we are adding support specifically for
one. The PRP name here also pairs with the PRP0000 HID.

-- 
Darren Hart					Open Source Technology Center
darren.hart@intel.com				            Intel Corporation




  parent reply	other threads:[~2014-08-18 12:37 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-17  6:04 [RFC PATCH 0/9] Add ACPI _DSD and unified device properties support Mika Westerberg
2014-08-17  6:04 ` [RFC PATCH 1/9] ACPI: Add support for device specific properties Mika Westerberg
2014-08-18  8:13   ` Hanjun Guo
2014-08-18  8:27     ` Mika Westerberg
2014-08-18  8:57       ` Hanjun Guo
2014-08-18 12:37       ` Darren Hart [this message]
2014-08-18 12:37         ` Darren Hart
     [not found] ` <1408255459-17625-1-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-08-17  6:04   ` [RFC PATCH 2/9] ACPI: Document ACPI " Mika Westerberg
2014-08-17  6:04     ` Mika Westerberg
2014-08-18 10:54     ` Mark Rutland
2014-08-18 16:05       ` Mika Westerberg
2014-08-19  5:45       ` Darren Hart
2014-08-19  5:45         ` Darren Hart
2014-08-19 16:51         ` Mark Rutland
2014-08-17  6:04   ` [RFC PATCH 6/9] gpiolib: add API to get gpio desc and flags Mika Westerberg
2014-08-17  6:04     ` Mika Westerberg
2014-08-17 13:00     ` Grant Likely
2014-08-17 13:00       ` Grant Likely
2014-08-17 17:43       ` Darren Hart
2014-08-17 17:43         ` Darren Hart
2014-08-18  4:57         ` Rafael J. Wysocki
     [not found]           ` <1927766.GeLld99ozq-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-08-18  7:16             ` Aaron Lu
2014-08-18  7:16               ` Aaron Lu
2014-08-19 15:58             ` Grant Likely
2014-08-19 15:58               ` Grant Likely
2014-08-17  6:04   ` [RFC PATCH 7/9] gpio: sch: Consolidate core and resume banks Mika Westerberg
2014-08-17  6:04     ` Mika Westerberg
2014-08-17  6:04 ` [RFC PATCH 3/9] Driver core: Unified device properties interface for platform firmware Mika Westerberg
2014-08-17 12:49   ` Grant Likely
2014-08-17 12:49     ` Grant Likely
2014-08-17 17:31     ` Darren Hart
2014-08-17 17:31       ` Darren Hart
2014-08-18  4:55       ` Rafael J. Wysocki
2014-08-18  4:46     ` Rafael J. Wysocki
2014-08-17  6:04 ` [RFC PATCH 4/9] of: Add property_ops callback for devices with of_node Mika Westerberg
2014-08-17 12:54   ` Grant Likely
2014-08-17 12:54     ` Grant Likely
2014-08-18  9:29     ` Mika Westerberg
     [not found]       ` <20140818092937.GT2462-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-08-18 12:44         ` Darren Hart
2014-08-18 12:44           ` Darren Hart
2014-08-18  0:44   ` Rob Herring
2014-08-17  6:04 ` [RFC PATCH 5/9] mfd: Add ACPI support Mika Westerberg
2014-08-28 11:29   ` Lee Jones
2014-08-28 11:29     ` Lee Jones
2014-08-28 11:45     ` Mika Westerberg
2014-08-17  6:04 ` [RFC PATCH 8/9] Input: gpio_keys_polled - Make use of device property API Mika Westerberg
2014-08-17  6:04 ` [RFC PATCH 9/9] leds: leds-gpio: " Mika Westerberg
  -- strict thread matches above, loose matches on Subject: below --
2014-08-16  6:53 [RFC PATCH 0/9] Add ACPI _DSD and unified device properties support Mika Westerberg
2014-08-16  6:53 ` [RFC PATCH 1/9] ACPI: Add support for device specific properties Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D0175D3C.A1C92%dvhart@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=aaron.lu@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hanjun.guo@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max.eliaser@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.