All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Olof Johansson <olof@lixom.net>, yann.morin.1998@free.fr
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] merge_config.sh: add -? for help
Date: Fri, 26 Dec 2014 14:40:24 -0800	[thread overview]
Message-ID: <D0C32312.B56B7%dvhart@linux.intel.com> (raw)
In-Reply-To: <1418331304-4821-2-git-send-email-olof@lixom.net>

No objection to the addition of -? if you find it useful.

Acked-by: Darren Hart <dvhart@linux.intel.com>

-- 
Darren Hart
Intel Open Source Technology Center




On 12/11/14, 12:55 PM, "Olof Johansson" <olof@lixom.net> wrote:

>It's usual enough for help text that it makes sense to support it.
>
>Signed-off-by: Olof Johansson <olof@lixom.net>
>---
> scripts/kconfig/merge_config.sh |   12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/scripts/kconfig/merge_config.sh
>b/scripts/kconfig/merge_config.sh
>index 2ab91b9..0c89537 100755
>--- a/scripts/kconfig/merge_config.sh
>+++ b/scripts/kconfig/merge_config.sh
>@@ -28,11 +28,11 @@ trap clean_up HUP INT TERM
> 
> usage() {
> 	echo "Usage: $0 [OPTIONS] [CONFIG [...]]"
>-	echo "  -h    display this help text"
>-	echo "  -m    only merge the fragments, do not execute the make command"
>-	echo "  -n    use allnoconfig instead of alldefconfig"
>-	echo "  -r    list redundant entries when merging fragments"
>-	echo "  -O    dir to put generated output files"
>+	echo "  -h or -? display this help text"
>+	echo "  -m       only merge the fragments, do not execute the make
>command"
>+	echo "  -n       use allnoconfig instead of alldefconfig"
>+	echo "  -r       list redundant entries when merging fragments"
>+	echo "  -O       dir to put generated output files"
> }
> 
> MAKE=true
>@@ -52,7 +52,7 @@ while true; do
> 		shift
> 		continue
> 		;;
>-	"-h")
>+	"-h"|"-?")
> 		usage
> 		exit
> 		;;
>-- 
>1.7.10.4
>



WARNING: multiple messages have this Message-ID (diff)
From: Darren Hart <dvhart@linux.intel.com>
To: Olof Johansson <olof@lixom.net>, <yann.morin.1998@free.fr>
Cc: <linux-kbuild@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] merge_config.sh: add -? for help
Date: Fri, 26 Dec 2014 14:40:24 -0800	[thread overview]
Message-ID: <D0C32312.B56B7%dvhart@linux.intel.com> (raw)
In-Reply-To: <1418331304-4821-2-git-send-email-olof@lixom.net>

No objection to the addition of -? if you find it useful.

Acked-by: Darren Hart <dvhart@linux.intel.com>

-- 
Darren Hart
Intel Open Source Technology Center




On 12/11/14, 12:55 PM, "Olof Johansson" <olof@lixom.net> wrote:

>It's usual enough for help text that it makes sense to support it.
>
>Signed-off-by: Olof Johansson <olof@lixom.net>
>---
> scripts/kconfig/merge_config.sh |   12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/scripts/kconfig/merge_config.sh
>b/scripts/kconfig/merge_config.sh
>index 2ab91b9..0c89537 100755
>--- a/scripts/kconfig/merge_config.sh
>+++ b/scripts/kconfig/merge_config.sh
>@@ -28,11 +28,11 @@ trap clean_up HUP INT TERM
> 
> usage() {
> 	echo "Usage: $0 [OPTIONS] [CONFIG [...]]"
>-	echo "  -h    display this help text"
>-	echo "  -m    only merge the fragments, do not execute the make command"
>-	echo "  -n    use allnoconfig instead of alldefconfig"
>-	echo "  -r    list redundant entries when merging fragments"
>-	echo "  -O    dir to put generated output files"
>+	echo "  -h or -? display this help text"
>+	echo "  -m       only merge the fragments, do not execute the make
>command"
>+	echo "  -n       use allnoconfig instead of alldefconfig"
>+	echo "  -r       list redundant entries when merging fragments"
>+	echo "  -O       dir to put generated output files"
> }
> 
> MAKE=true
>@@ -52,7 +52,7 @@ while true; do
> 		shift
> 		continue
> 		;;
>-	"-h")
>+	"-h"|"-?")
> 		usage
> 		exit
> 		;;
>-- 
>1.7.10.4
>



  parent reply	other threads:[~2014-12-26 22:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11 20:55 [PATCH 1/2] merge_config.sh: Display usage if given too few arguments Olof Johansson
2014-12-11 20:55 ` [PATCH 2/2] merge_config.sh: add -? for help Olof Johansson
2014-12-24  4:51   ` Masahiro Yamada
2014-12-26 22:40   ` Darren Hart [this message]
2014-12-26 22:40     ` Darren Hart
2015-01-07 20:29   ` Michal Marek
2015-01-07 20:28 ` [PATCH 1/2] merge_config.sh: Display usage if given too few arguments Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D0C32312.B56B7%dvhart@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.