Re: [PATCH] kernel/image/depmodwrapper: Fixups for depmod

["Hart, Darren" <darren.hart@intel.com>]

On 1/20/15, 6:16 AM, "Bruce Ashfield" <bruce.ashfield@windriver.com> wrote:

>On 15-01-20 08:33 AM, Richard Purdie wrote:
>> With the rpm package backend enabled, running:
>>
>> bitbake <image>
>> bitbake virtual/kernel -c clean
>> bitbake <image> -c rootfs -f
>>
>> results in an image with incorrect kernel module dependency information.
>> The problem is that the System.map and kernel-abiversion files are
>>needed
>> for depmod and after the recent kernel changes, these are no longer in
>> sstate.
>>
>> Its reasonable to require the kernel to unpack/build if you're
>> about to build a module against it. It is not reasonable to require this
>> just to build a rootfs.
>>
>> Therefore stash the needed files specifically for depmod.
>>
>> Also fix some STAGING_KERNEL_DIR references which were incorrect, found
>> whilst sorting through his change.
>
>Now that I see the fix, the tweaks are clear (and obvious). I would have
>preferred a straight up module loading error in all cases .. since that
>would have showed in my workflows. The rootfs.py changes in particular
>would have taken me much longer to get right.
>
>>
>> This patch also makes the depmod files being missing a fatal error
>>rather than
>> something the system just ignores silently.
>
>Nice improvement.
>
>Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>

Functionally look good. I noticed some whitespace issues (spaces in bash
sections instead of tabs), but those may have been due to keeping a file
internally consistent.

Otherwise,

Reviewed-by: Darren Hart <dvhart@linux.intel.com>


-- 
Darren Hart
Intel Open Source Technology Center