From: "Vick, Matthew" <matthew.vick@intel.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ethernet: fm10k: Actually drop 4 bits
Date: Mon, 26 Jan 2015 16:58:13 +0000 [thread overview]
Message-ID: <D0EBB1E6.6855F%matthew.vick@intel.com> (raw)
In-Reply-To: <87twzhknnl.fsf@rasmusvillemoes.dk>
On 1/23/15, 4:50 PM, "Rasmus Villemoes" <linux@rasmusvillemoes.dk> wrote:
>On Sat, Jan 24 2015, "Vick, Matthew" <matthew.vick@intel.com> wrote:
>
>> Good catch! I noticed this too and was getting a patch together to
>>address
>> this.
>>
>> The difference is that I was planning on not silently accepting an
>>invalid
>> VLAN ID to begin with and returning FM10K_ERR_PARAM if the VLAN was
>> invalid, which I think is a better approach for this situation. If it's
>> alright with you, I'll generate the patch shortly and credit you via
>>your
>> Reported-by.
>
>Sure, do what you think is best.
>
>Rasmus
Sounds good. I'll get the patch created and validated through Jeff's tree.
Cheers,
Matthew
prev parent reply other threads:[~2015-01-26 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 22:53 [PATCH] ethernet: fm10k: Actually drop 4 bits Rasmus Villemoes
2015-01-23 3:27 ` Jeff Kirsher
2015-01-24 0:18 ` Vick, Matthew
2015-01-24 0:50 ` Rasmus Villemoes
2015-01-26 16:58 ` Vick, Matthew [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0EBB1E6.6855F%matthew.vick@intel.com \
--to=matthew.vick@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.