Re: [PATCH] image: Add missing depends on virtual/kernel for depmod data

["Hart, Darren" <darren.hart@intel.com>]

On 1/27/15, 8:18 AM, "Richard Purdie" <richard.purdie@linuxfoundation.org>
wrote:

>On Tue, 2015-01-27 at 15:48 +0000, Hart, Darren wrote:
>> On 1/27/15, 7:45 AM, "Bruce Ashfield" <bruce.ashfield@windriver.com>
>>wrote:
>> 
>> >On 15-01-27 10:29 AM, Richard Purdie wrote:
>> >> We need the depmod data so that the kernel depmod command works
>> >>successfully
>> >> at rootfs time. The fact this was working inconsistently is now
>> >>highlighted
>> >> after the command was made to error out. A simple test case is:
>> >>
>> >> bitbake virtual/kernel image
>> >> bitbake vrituak/kernel -c clean
>> >> bitbake image -c rootfs -f
>> >>
>> >> We fix it by adding the missing dependency.
>> >
>> >Looks good here.
>> >
>> >Out of curiosity, was this hiding before, or did it only come about due
>> >to our recent moves to the work-shared kernel builds ?
>> 
>> I'm being dense I guess. I went to go verify what virtual/kernel
>> do_populate_sysroot is doing in the current state of things, in order to
>> be sure it copied over the right files, and I couldn't find it quickly.
>> Where is this defined?
>
>http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=11ef55a93bd2bbd95e203
>fab3aa237322923ffd9
>
>Specifically:
>
>sysroot_stage_all () {
> sysroot_stage_dir ${D}${datadir}/kernel-depmod
>${SYSROOT_DESTDIR}${datadir}/kernel-depmod
>}

Right, I thought of this while driving in :-) -ENOCOFFEE

Reviewed-by: Darren Hart <dvhart@linux.intel.com>

-- 
Darren Hart
Intel Open Source Technology Center