Re: [PATCH] mtd: spi-nor: spansion: Add support for infineon cy15v102qsn

From: "Michael Walle" <mwalle@kernel.org>
To: "Hui Wang" <hui.wang@canonical.com>,
	<linux-mtd@lists.infradead.org>, <tudor.ambarus@linaro.org>,
	<pratyush@kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: spansion: Add support for infineon cy15v102qsn
Date: Mon, 08 Apr 2024 14:53:09 +0200	[thread overview]
Message-ID: <D0ER81J5LHKW.N4T3BI3FRLDB@kernel.org> (raw)
In-Reply-To: <20240408124328.777375-1-hui.wang@canonical.com>

[-- Attachment #1.1: Type: text/plain, Size: 1197 bytes --]

Hi,

On Mon Apr 8, 2024 at 2:43 PM CEST, Hui Wang wrote:
> It is 2Mbit F-RAM which is logically organized as 256K x 8.

Please have a look at drivers/misc/at25.c. I'm trying to get rid of
the NO_ERASE flag. This is more of an EEPROM like device. The at25
driver already have some kind of FRAM type support.

> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
>  drivers/mtd/spi-nor/spansion.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
> index 6cc237c24e07..5dc94926b2cb 100644
> --- a/drivers/mtd/spi-nor/spansion.c
> +++ b/drivers/mtd/spi-nor/spansion.c
> @@ -981,6 +981,12 @@ static const struct flash_info spansion_nor_parts[] = {
>  		.name = "s28hs02gt",
>  		.mfr_flags = USE_CLPEF,
>  		.fixups = &s28hx_t_fixups,
> +	}, {
> +		.id = SNOR_ID(0x48, 0x51, 0x80, 0x06, 0x00, 0x00),

This doesn't look like a JEDEC id. The datasheet says it is a 11bit
manufacturer id?

-michael

> +		.name = "cy15v102qsn",
> +		.size = SZ_256K,
> +		.sector_size = SZ_256K,
> +		.flags = SPI_NOR_NO_ERASE,
>  	}, {
>  		.id = SNOR_ID(0xef, 0x40, 0x13),
>  		.name = "s25fl004k",

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/