Re: [PATCH 3/7] vmxnet3: cleanup txq stats

[Yong Wang <yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>]

On 2/25/15, 6:31 PM, "Stephen Hemminger" <stephen@networkplumber.org>
wrote:

>There are several stats here which are never set, and have no way
>to be displayed.  Assume in future xstats could be used.
>
>Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Yong Wang <yongwang@vmware.com>

>---
> lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
>diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_ring.h
>b/lib/librte_pmd_vmxnet3/vmxnet3_ring.h
>index c5abdb6..ebe6268 100644
>--- a/lib/librte_pmd_vmxnet3/vmxnet3_ring.h
>+++ b/lib/librte_pmd_vmxnet3/vmxnet3_ring.h
>@@ -121,16 +121,12 @@ vmxnet3_comp_ring_adv_next2proc(struct
>vmxnet3_comp_ring *ring)
> }
> 
> struct vmxnet3_txq_stats {
>-	uint64_t               drop_total; /* # of pkts dropped by the driver,
>the
>-									   * counters below track droppings due to
>-									   * different reasons
>-									   */
>-	uint64_t               drop_oversized;
>-	uint64_t               drop_hdr_inspect_err;
>-	uint64_t               drop_tso;
>-	uint64_t               deferred;
>-	uint64_t               tx_ring_full;
>-	uint64_t               linearized;  /* # of pkts linearized */
>+	uint64_t	drop_total; /* # of pkts dropped by the driver,
>+				     * the counters below track droppings due to
>+				     * different reasons
>+				     */
>+	uint64_t	drop_tso;
>+	uint64_t	tx_ring_full;
> };
> 
> typedef struct vmxnet3_tx_ctx {
>-- 
>2.1.4
>