Re: [PATCH 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

["Narsimhulu Musini (nmusini)" <nmusini@cisco.com>]

Hi Hannes,

   Thanks for reviewing the patch. Please find responses inline.
I will incorporate the changes in next patch submittal.

On 02/03/15 7:05 pm, "Hannes Reinecke" <hare@suse.de> wrote:

>On 02/10/2015 05:43 PM, Narsimhulu Musini wrote:
>> Kconfig for kbuild
>> Makefile to build snic module
>> 
>> Updated MAINTAINERS file
>> 
>> Signed-off-by: Narsimhulu Musini <nmusini@cisco.com>
>> Signed-off-by: Sesidhar Baddela <sebaddel@cisco.com>
>> ---
>>  MAINTAINERS                |  7 +++++++
>>  drivers/scsi/Kconfig       | 10 ++++++++++
>>  drivers/scsi/Makefile      |  1 +
>>  drivers/scsi/snic/Makefile | 17 +++++++++++++++++
>>  4 files changed, 35 insertions(+)
>>  create mode 100644 drivers/scsi/snic/Makefile
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 2a97e05..368fb76 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2536,6 +2536,13 @@ L:	linux-scsi@vger.kernel.org
>>  S:	Supported
>>  F:	drivers/scsi/fnic/
>>  
>> +CISCO SCSI HBA DRIVER
>> +M:	Narsimhulu Musini <nmusini@cisco.com>
>> +M:	Sesidhar Baddela <sebaddel@cisco.com>
>> +L:	linux-scsi@vger.kernel.org
>> +S:	Supported
>> +F:	drivers/scsi/snic/
>> +
>>  CMPC ACPI DRIVER
>>  M:	Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
>>  M:	Daniel Oliveira Nascimento <don@syst.com.br>
>> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
>> index 9c92f41..7e9d80a 100644
>> --- a/drivers/scsi/Kconfig
>> +++ b/drivers/scsi/Kconfig
>> @@ -634,6 +634,16 @@ config FCOE_FNIC
>>  	  <file:Documentation/scsi/scsi.txt>.
>>  	  The module will be called fnic.
>>  
>> +config SCSI_SNIC
>> +	tristate "Cisco SNIC Driver"
>> +	depends on PCI && SCSI && X86
>> +	help
>> +	  This is support for the Cisco PCI-Express SCSI HBA.
>> +
>> +	  To compile this driver as a module, choose M here and read
>> +	  <file:Documentation/scsi/scsi.txt>.
>> +	  The module will be called snic.
>> +
>>  config SCSI_DMX3191D
>>  	tristate "DMX3191D SCSI support"
>>  	depends on PCI && SCSI
>> diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
>> index 58158f1..f643942 100644
>> --- a/drivers/scsi/Makefile
>> +++ b/drivers/scsi/Makefile
>> @@ -39,6 +39,7 @@ obj-$(CONFIG_LIBFC)		+= libfc/
>>  obj-$(CONFIG_LIBFCOE)		+= fcoe/
>>  obj-$(CONFIG_FCOE)		+= fcoe/
>>  obj-$(CONFIG_FCOE_FNIC)		+= fnic/
>> +obj-$(CONFIG_SCSI_SNIC)		+= snic/
>>  obj-$(CONFIG_SCSI_BNX2X_FCOE)	+= libfc/ fcoe/ bnx2fc/
>>  obj-$(CONFIG_ISCSI_TCP) 	+= libiscsi.o	libiscsi_tcp.o iscsi_tcp.o
>>  obj-$(CONFIG_INFINIBAND_ISER) 	+= libiscsi.o
>> diff --git a/drivers/scsi/snic/Makefile b/drivers/scsi/snic/Makefile
>> new file mode 100644
>> index 0000000..ad856a1
>> --- /dev/null
>> +++ b/drivers/scsi/snic/Makefile
>> @@ -0,0 +1,17 @@
>> +obj-$(CONFIG_SCSI_SNIC) += snic.o
>> +
>> +snic-y := \
>> +	snic_attrs.o \
>> +	snic_main.o \
>> +	snic_res.o \
>> +	snic_isr.o \
>> +	snic_ctl.o \
>> +	snic_io.o \
>> +	snic_scsi.o \
>> +	snic_disc.o \
>> +	snic_debugfs.o \
>> +	snic_trc.o \
>> +	vnic_cq.o \
>> +	vnic_intr.o \
>> +	vnic_dev.o \
>> +	vnic_wq.o
>> 
>As mentioned earlier, please add OONFIG_XXX items for debugfs and
>tracing functionality.
Sure, I will add checks to include debugfs dependent functionality only on
CONFIG_DEBUG_FS=y.
>
>Cheers,
>
>Hannes
>-- 
>Dr. Hannes Reinecke		               zSeries & Storage
>hare@suse.de			               +49 911 74053 688
>SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
>GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
>HRB 21284 (AG Nürnberg)
Thanks
Narsimhulu
>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html