From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Stefan Berger" <stefanb@linux.ibm.com>,
<keyrings@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<herbert@gondor.apana.org.au>, <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <lukas@wunner.de>
Subject: Re: [PATCH v3] crypto: ecc - Prevent ecc_digits_from_bytes from reading too many bytes
Date: Fri, 10 May 2024 11:08:42 +0300 [thread overview]
Message-ID: <D15T7OSYSX5S.3G35QSFEIHU8F@kernel.org> (raw)
In-Reply-To: <20240510015921.179175-1-stefanb@linux.ibm.com>
On Fri May 10, 2024 at 4:59 AM EEST, Stefan Berger wrote:
> + memcpy((u8 *)&msd + sizeof(msd) - o, in, o);
Not a review/NAK comment but I personally prefer to treat these
like arrays:
&((u8 *)&msd)[sizeof(msd) - o]
It is totally fine as it is.
BR, Jarkko
next prev parent reply other threads:[~2024-05-10 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 1:59 [PATCH v3] crypto: ecc - Prevent ecc_digits_from_bytes from reading too many bytes Stefan Berger
2024-05-10 8:08 ` Jarkko Sakkinen [this message]
2024-05-17 10:57 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D15T7OSYSX5S.3G35QSFEIHU8F@kernel.org \
--to=jarkko@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.