From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Joachim Vandersmissen" <git@jvdsn.com>,
<linux-crypto@vger.kernel.org>,
"Herbert Xu" <herbert@gondor.apana.org.au>
Cc: "David Howells" <dhowells@redhat.com>,
"Simo Sorce" <simo@redhat.com>,
"Stephan Mueller" <smueller@chronox.de>
Subject: Re: [PATCH v5 1/2] certs: Move RSA self-test data to separate file
Date: Mon, 13 May 2024 23:26:32 +0300 [thread overview]
Message-ID: <D18SS8X9VV7L.28F9PNZ1PM96L@kernel.org> (raw)
In-Reply-To: <20240513045507.25615-1-git@jvdsn.com>
On Mon May 13, 2024 at 7:55 AM EEST, Joachim Vandersmissen wrote:
> + pkcs7 = pkcs7_parse_message(sig, sig_len);
> + if (IS_ERR(pkcs7))
> + panic("Certs %s selftest: pkcs7_parse_message() = %d\n", name, ret);
Off-topic: wondering if Linux had similar helpers for PKCS#1 padding
(and if not, are they difficult to add)?
Anyway, looks good to me:
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
next prev parent reply other threads:[~2024-05-13 20:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 4:55 [PATCH v5 1/2] certs: Move RSA self-test data to separate file Joachim Vandersmissen
2024-05-13 4:55 ` [PATCH v5 2/2] certs: Add ECDSA signature verification self-test Joachim Vandersmissen
2024-05-13 20:29 ` Jarkko Sakkinen
2024-05-13 20:26 ` Jarkko Sakkinen [this message]
2024-05-14 2:36 ` [PATCH v5 1/2] certs: Move RSA self-test data to separate file Joachim Vandersmissen
2024-05-14 12:05 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D18SS8X9VV7L.28F9PNZ1PM96L@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=git@jvdsn.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=simo@redhat.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.