All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wiles, Keith" <keith.wiles@intel.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time
Date: Thu, 4 Jun 2015 14:51:02 +0000	[thread overview]
Message-ID: <D195CFC8.218EB%keith.wiles@intel.com> (raw)
In-Reply-To: <CALwxeUugo_WbFcvBfgq17QiUGwwetO3wTRjNHEHmT385TkTb3A@mail.gmail.com>



From: David Marchand <david.marchand@6wind.com<mailto:david.marchand@6wind.com>>
Date: Thursday, June 4, 2015 at 9:43 AM
To: Keith Wiles <keith.wiles@intel.com<mailto:keith.wiles@intel.com>>
Cc: Neil Horman <nhorman@tuxdriver.com<mailto:nhorman@tuxdriver.com>>, "dev@dpdk.org<mailto:dev@dpdk.org>" <dev@dpdk.org<mailto:dev@dpdk.org>>
Subject: Re: [dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time

On Thu, Jun 4, 2015 at 4:27 PM, Wiles, Keith <keith.wiles@intel.com<mailto:keith.wiles@intel.com>> wrote:
Hi Neil and Stephen,

I agree this is not saving instructions and adding performance, but of
code clutter and providing a layered model for the developer. The
rte_eal_init() routine still exists and I was not trying to remove that
API only layer a convenient API for common constructs.
>
>Its not a bad addition, I'm just not sure its worth having to take on the
>additional API surface to include.  I'd be more supportive if you could
>enhance
>the function to allow the previously mentioned before/after flexibiilty.
>Then
>we could just deprecate rte_eal_init as an API call entirely, and use this
>instead.

I can see we can create an API to add support for doing the applications
args first or after, but would that even be acceptable?

What's the point ?
Adding stuff just for saving lines ?
Are you serious about this ?

Wow, OK dropped!


--
David Marchand

  reply	other threads:[~2015-06-04 14:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 18:49 [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time Keith Wiles
2015-06-03 19:24 ` Thomas Monjalon
2015-06-03 19:43   ` Wiles, Keith
2015-06-04  0:12 ` Stephen Hemminger
2015-06-04 11:50   ` Wiles, Keith
2015-06-04 13:55     ` Neil Horman
2015-06-04 14:27       ` Wiles, Keith
2015-06-04 14:43         ` David Marchand
2015-06-04 14:51           ` Wiles, Keith [this message]
2015-06-04 14:55           ` Wiles, Keith
2015-06-04 14:47       ` Stephen Hemminger
2015-06-04 16:51       ` Thomas F Herbert
2015-06-04 21:27       ` Chilikin, Andrey
2015-06-05  6:01         ` Simon Kågström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D195CFC8.218EB%keith.wiles@intel.com \
    --to=keith.wiles@intel.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.