All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Baruch Siach" <baruch@tkos.co.il>
Cc: Stefan Berger <stefanb@linux.ibm.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v4 2/3] package/libtpms: add host package
Date: Tue, 21 May 2024 13:47:50 +0300	[thread overview]
Message-ID: <D1F9HIPNX2B6.12XBYOS1W36JF@kernel.org> (raw)
In-Reply-To: <877cfnphyj.fsf@tarshish>

On Tue May 21, 2024 at 1:39 PM EEST, Baruch Siach wrote:
> Hi Jarkko,
>
> On Tue, May 21 2024, Jarkko Sakkinen wrote:
> > diff --git a/package/Config.in b/package/Config.in
> > index 1b6a5b0dab..30b76349ec 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -1569,6 +1569,7 @@ menu "Crypto"
> >  	source "package/libssh/Config.in"
> >  	source "package/libssh2/Config.in"
> >  	source "package/libtomcrypt/Config.in"
> > +	source "package/libtpms/Config.in"
> >  	source "package/libuecc/Config.in"
> >  	source "package/libxcrypt/Config.in"
> >  	source "package/mbedtls/Config.in"
> > diff --git a/package/libtpms/Config.in b/package/libtpms/Config.in
> > new file mode 100644
> > index 0000000000..335a5bc7b6
> > --- /dev/null
> > +++ b/package/libtpms/Config.in
> > @@ -0,0 +1,20 @@
> > +config BR2_PACKAGE_LIBTPMS
>
> You are not adding a target package, right? So this config symbol
> doesn't do anything.

Ugh, right. Now I need to do a check before I roll out a new version.

I think this is what I should actually do, right (diff below)? Sorry
learning the process :-)

diff --git a/package/Config.in b/package/Config.in
index 30b76349ec..1b6a5b0dab 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1569,7 +1569,6 @@ menu "Crypto"
        source "package/libssh/Config.in"
        source "package/libssh2/Config.in"
        source "package/libtomcrypt/Config.in"
-       source "package/libtpms/Config.in"
        source "package/libuecc/Config.in"
        source "package/libxcrypt/Config.in"
        source "package/mbedtls/Config.in"
diff --git a/package/Config.in.host b/package/Config.in.host
index 0cf9dc3897..4e0dab0504 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -57,6 +57,7 @@ menu "Host utilities"
        source "package/jsmin/Config.in.host"
        source "package/kmod/Config.in.host"
        source "package/libp11/Config.in.host"
+       source "package/libtpms/Config.in.host"
        source "package/llvm-project/lld/Config.in.host"
        source "package/lpc3250loader/Config.in.host"
        source "package/lttng-babeltrace/Config.in.host"
diff --git a/package/libtpms/Config.in b/package/libtpms/Config.in.host
similarity index 89%
rename from package/libtpms/Config.in
rename to package/libtpms/Config.in.host
index 335a5bc7b6..7a477d21a7 100644
--- a/package/libtpms/Config.in
+++ b/package/libtpms/Config.in.host
@@ -1,7 +1,5 @@
-config BR2_PACKAGE_LIBTPMS
+config BR2_HOST_PACKAGE_LIBTPMS
        bool "libtpms"
-       select BR2_PACKAGE_LIBTOOL
-       select BR2_PACKAGE_OPENSSL
        help
          Libtpms is a library that targets the integration of TPM
          functionality into hypervisors, primarily into Qemu. Libtpms

BR, Jarkko
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-05-21 10:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 10:31 [Buildroot] [PATCH v4 0/3] swtpm and libtpms host packages Jarkko Sakkinen
2024-05-21 10:31 ` [Buildroot] [PATCH v4 1/3] package/json-glib: add host build Jarkko Sakkinen
2024-05-21 10:31 ` [Buildroot] [PATCH v4 2/3] package/libtpms: add host package Jarkko Sakkinen
2024-05-21 10:39   ` Baruch Siach via buildroot
2024-05-21 10:47     ` Jarkko Sakkinen [this message]
2024-05-21 11:15       ` Baruch Siach via buildroot
2024-05-21 10:31 ` [Buildroot] [PATCH v4 3/3] package/swtpm: " Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D1F9HIPNX2B6.12XBYOS1W36JF@kernel.org \
    --to=jarkko@kernel.org \
    --cc=baruch@tkos.co.il \
    --cc=buildroot@buildroot.org \
    --cc=stefanb@linux.ibm.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.