From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Paul Menzel" <pmenzel@molgen.mpg.de>
Cc: <linux-integrity@vger.kernel.org>, <keyrings@vger.kernel.org>,
<James.Bottomley@HansenPartnership.com>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"David Howells" <dhowells@redhat.com>,
"Paul Moore" <paul@paul-moore.com>,
"James Morris" <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Stefan Berger" <stefanb@linux.ibm.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Mario Limonciello" <mario.limonciello@amd.com>,
<linux-kernel@vger.kernel.org>,
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH] tpm: Open code tpm_buf_parameters()
Date: Mon, 27 May 2024 14:00:45 +0300 [thread overview]
Message-ID: <D1KDIOAFZ55T.3ECZ64CCUEER2@kernel.org> (raw)
In-Reply-To: <17bbe39e-3c68-4e0b-9862-9658f684b19e@molgen.mpg.de>
On Sun May 26, 2024 at 8:42 AM EEST, Paul Menzel wrote:
> Dear Jarkko,
>
>
> Thank you for your patch.
>
> Am 25.05.24 um 17:44 schrieb Jarkko Sakkinen:
> > With only single call site, this no sense, and it actually slipped out
>
> this *makes* no sense?
Thanks for the remark :-)
>
> > of the radar during the review. Open code and document the action
> > directly to the site, to make it more readable.
>
> […]
>
>
> Kind regards,
>
> Paul
In order not to have to recycle this, does this now make sense to you:
https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=b6b88cde77e7c30ab8f534d723ad9c4ec15b7753
Unless actual critical fixes for hmac, probably will save this to v6.11
but with some "real" fixes I'll piggy pack it to rcX.
BR, Jarkko
prev parent reply other threads:[~2024-05-27 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-25 15:44 [PATCH] tpm: Open code tpm_buf_parameters() Jarkko Sakkinen
2024-05-26 5:42 ` Paul Menzel
2024-05-27 11:00 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1KDIOAFZ55T.3ECZ64CCUEER2@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ardb@kernel.org \
--cc=dhowells@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=paul@paul-moore.com \
--cc=peterhuewe@gmx.de \
--cc=pmenzel@molgen.mpg.de \
--cc=serge@hallyn.com \
--cc=stefanb@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.