From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jan Beulich" <jbeulich@suse.com>
Cc: "Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
<linux-integrity@vger.kernel.org>
Subject: Re: Ping: [PATCH] tpm_tis: don't flush never initialized work
Date: Wed, 29 May 2024 15:26:11 +0300 [thread overview]
Message-ID: <D1M4L6MZ6IFC.21HFGZ10104Y0@kernel.org> (raw)
In-Reply-To: <365c120f-dfb0-4155-b83f-e0b8d4ead486@suse.com>
On Wed May 29, 2024 at 10:47 AM EEST, Jan Beulich wrote:
> Has this possibly fallen through the cracks?
Not possibly that is what exactly has happened, sorry.
I tweaked a bit the commit message:
commit 2c0943eba0bd765e1e4a90234e669a26a9304b74 (HEAD -> master)
Author: Jan Beulich <jbeulich@suse.com>
Date: Wed May 29 15:23:25 2024 +0300
tpm_tis: Do *not* flush uninitialized work
tpm_tis_core_init() may fail before tpm_tis_probe_irq_single() is
called, in which case tpm_tis_remove() unconditionally calling
flush_work() is triggering a warning for .func still being NULL.
Cc: stable@vger.kernel.org # v6.5+
Fixes: 481c2d14627d ("tpm,tpm_tis: Disable interrupts after 1000 unhandled IRQs")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Does this make sense to you?
> Jan
BR, Jarkko
next prev parent reply other threads:[~2024-05-29 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 14:28 [PATCH] tpm_tis: don't flush never initialized work Jan Beulich
2023-09-14 15:19 ` Jarkko Sakkinen
2023-09-14 15:29 ` Jan Beulich
2023-09-14 15:42 ` Jarkko Sakkinen
2024-05-29 7:47 ` Ping: " Jan Beulich
2024-05-29 12:26 ` Jarkko Sakkinen [this message]
2024-05-29 12:32 ` Jan Beulich
2024-05-29 12:37 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1M4L6MZ6IFC.21HFGZ10104Y0@kernel.org \
--to=jarkko@kernel.org \
--cc=jbeulich@suse.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.