From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Thomas Huth" <thuth@redhat.com>
Cc: "Andrew Jones" <andrew.jones@linux.dev>, <kvm@vger.kernel.org>
Subject: Re: [kvm-unit-tests PATCH 3/4] build: Make build output pretty
Date: Tue, 04 Jun 2024 15:05:10 +1000 [thread overview]
Message-ID: <D1QYYRZ0LMAR.26MRLHMK0MFDT@gmail.com> (raw)
In-Reply-To: <448757a4-46c8-4761-bc51-32ee39f39b97@redhat.com>
On Mon Jun 3, 2024 at 6:26 PM AEST, Thomas Huth wrote:
> On 02/06/2024 14.25, Nicholas Piggin wrote:
> > Unless make V=1 is specified, silence make recipe echoing and print
> > an abbreviated line for major build steps.
> >
> > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> > ---
> > Makefile | 14 ++++++++++++++
> > arm/Makefile.common | 7 +++++++
> > powerpc/Makefile.common | 11 +++++++----
> > riscv/Makefile | 5 +++++
> > s390x/Makefile | 18 +++++++++++++++++-
> > scripts/mkstandalone.sh | 2 +-
> > x86/Makefile.common | 5 +++++
> > 7 files changed, 56 insertions(+), 6 deletions(-)
>
> The short lines look superfluous in verbose mode, e.g.:
>
> [OBJCOPY] s390x/memory-verify.bin
> objcopy -O binary s390x/memory-verify.elf s390x/memory-verify.bin
>
> Could we somehow suppress the echo lines in verbose mode, please?
>
> For example in the SLOF project, it's done like this:
>
> https://gitlab.com/slof/slof/-/blob/master/make.rules?ref_type=heads#L48
>
> By putting the logic into $CC and friends, you also don't have to add
> "@echo" statements all over the place.
I'll could try a bit harder at it, this was a pretty quick hack.
I probably prefer the cmd_cc style that Linux uses rather than
overloading CC. But maybe that's more work.
Thanks,
Nick
next prev parent reply other threads:[~2024-06-04 5:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 12:25 [kvm-unit-tests PATCH 0/4] powerpc fix and misc docs/build/CI improvements Nicholas Piggin
2024-06-02 12:25 ` [kvm-unit-tests PATCH 1/4] powerpc/sprs: Fix report_kfail call Nicholas Piggin
2024-06-03 4:22 ` Thomas Huth
2024-06-02 12:25 ` [kvm-unit-tests PATCH 2/4] doc: update unittests doc Nicholas Piggin
2024-06-03 4:24 ` Thomas Huth
2024-06-03 6:47 ` Andrew Jones
2024-06-03 8:12 ` Nicholas Piggin
2024-06-03 8:45 ` Andrew Jones
2024-06-02 12:25 ` [kvm-unit-tests PATCH 3/4] build: Make build output pretty Nicholas Piggin
2024-06-03 7:00 ` Andrew Jones
2024-06-03 8:26 ` Thomas Huth
2024-06-03 8:56 ` Andrew Jones
2024-06-05 0:38 ` Nicholas Piggin
2024-06-12 10:32 ` Thomas Huth
2024-06-14 1:07 ` Nicholas Piggin
2024-06-04 5:05 ` Nicholas Piggin [this message]
2024-06-02 12:25 ` [kvm-unit-tests PATCH 4/4] gitlab-ci: Always save artifacts Nicholas Piggin
2024-06-03 4:29 ` Thomas Huth
2024-06-03 8:17 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1QYYRZ0LMAR.26MRLHMK0MFDT@gmail.com \
--to=npiggin@gmail.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.