Re: [Buildroot] [PATCH v7 3/3] package/swtpm: add host package

["Jarkko Sakkinen" <jarkko@kernel.org>]

On Thu Jun 6, 2024 at 12:30 PM EEST, Yann E. MORIN wrote:
> Jarkko, All,
>
> On 2024-06-06 02:35 +0300, Jarkko Sakkinen spake thusly:
> > The SWTPM package provides TPM emulators with different front-end
> > interfaces to libtpms. TPM emulators provide socket interfaces (TCP/IP and
> > Unix) and the Linux CUSE interface for the creation of multiple native
> > /dev/vtpm* devices.
> > 
> > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> > ---
> [--SNIP--]
> > diff --git a/package/swtpm/swtpm.mk b/package/swtpm/swtpm.mk
> > new file mode 100644
> > index 0000000000..b05a248c03
> > --- /dev/null
> > +++ b/package/swtpm/swtpm.mk
> > @@ -0,0 +1,23 @@
> > +################################################################################
> > +#
> > +# swtpm
> > +#
> > +################################################################################
> > +
> > +SWTPM_VERSION = 0.8.2
> > +SWTPM_SITE = $(call github,stefanberger,swtpm,v$(SWTPM_VERSION))
> > +SWTPM_LICENSE = BSD-4-Clause
> > +SWTPM_LICENSE_FILES = LICENSE
> > +
> > +# Required because a plain Git clone is used:
> > +HOST_SWTPM_AUTORECONF = YES
> > +HOST_SWTPM_DEPENDENCIES = \
> > +	host-json-glib \
> > +	host-libopenssl \
> > +	host-libtasn1 \
> > +	host-libtool \
> > +	host-libtpms \
> > +	host-pkgconf
> > +HOST_SWTPM_CONF_OPTS = --with-openssl --without-seccomp
> > +
> > +$(eval $(host-autotools-package))
>
>     $ make defconfig
>     $ make host-swtpm
>     [...]
>     configure: error: expect is required: expect package
>
> It is only needed for tests, so I disabled those.
>
> I took that opportunity to also reorganise the variables in a more
> logical manner: first, depenencies, then autoreconf, finally configure
> opts.
>
> Applied to next, thanks.

Thanks a lot for addressing those issues!

With systemd I'll test if just those fixes without version upgrade
would take of it because that would be a better order. And also
split into two patches.

I.e. thes transcripts:

Filesystem found in kernel header but not in filesystems-gperf.gperf: BCACHEFS_SUPER_MAGIC                                                    
Filesystem found in kernel header but not in filesystems-gperf.gperf: PID_FS_MAGIC                                                            

Is this anywhere near how the upstream references could be tagged?

Upstream: ed01b92e1c92 ("basic: add PIDFS magic (#31709)")
Upstream: 201148b08de6 ("basic: Add BCACHEFS magic")

I did not look into any bug database just plain scavenged the superblock
keywors for systemd's commit log :-)

Probably for a project like BuildRoot there must be really something
actually enforocing the upgrade :-)

>
> Regards,
> Yann E. MORIN.

BR, Jarkko
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot