From: "Michael Walle" <mwalle@kernel.org>
To: "Ayush Singh" <ayush@beagleboard.org>,
"Mark Brown" <broonie@kernel.org>,
"Vaishnav M A" <vaishnav@beagleboard.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Derek Kiernan" <derek.kiernan@amd.com>,
"Dragan Cvetic" <dragan.cvetic@amd.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Nishanth Menon" <nm@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Tero Kristo" <kristo@kernel.org>, "Andrew Lunn" <andrew@lunn.ch>,
<jkridner@beagleboard.org>, <robertcnelson@beagleboard.org>
Cc: <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 1/7] dt-bindings: connector: Add mikrobus-connector
Date: Thu, 27 Jun 2024 19:12:52 +0200 [thread overview]
Message-ID: <D2AYUH4XY0SK.1SYOUCT0PLAKT@kernel.org> (raw)
In-Reply-To: <20240627-mikrobus-scratch-spi-v5-1-9e6c148bf5f0@beagleboard.org>
Hi,
Could you give us a DT snippet of how this should look like with a
board?
On Thu Jun 27, 2024 at 6:26 PM CEST, Ayush Singh wrote:
> + board:
> + description: board attached to mikrobus connector
> + $ref: /schemas/types.yaml#/definitions/phandle-array
Shouldn't this be a subnode of the connector?
i.e.
connector {
compatible = "mikrobus-connector";
// phandles to the parent controllers
spi {
temp-sensor@0 {
compatible = "maxim,max31855k";
reg = <0>;
};
};
i2c {
..
};
};
I don't think you can introduce a new
compatible = "maxim,max31855k", "mikrobus,spi";
if there is already a binding for "maxim,max31855k". But I might be
wrong. Why is this compatible needed at all?
Also, the mikrobus-connector driver could translate the chipselects.
-michael
next prev parent reply other threads:[~2024-06-27 17:19 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 16:26 [PATCH v5 0/7] misc: Add mikroBUS driver Ayush Singh
2024-06-27 16:26 ` [PATCH v5 1/7] dt-bindings: connector: Add mikrobus-connector Ayush Singh
2024-06-27 17:12 ` Michael Walle [this message]
2024-06-27 17:29 ` Ayush Singh
2024-06-27 17:49 ` Michael Walle
2024-06-27 18:44 ` Andrew Lunn
2024-08-31 18:11 ` Ayush Singh
2024-09-04 14:46 ` Rob Herring
2024-09-04 17:08 ` Ayush Singh
2024-09-04 17:49 ` Rob Herring
2024-09-05 20:24 ` Ayush Singh
2024-06-28 17:00 ` Rob Herring
2024-06-28 16:28 ` Rob Herring
2024-07-02 15:14 ` Ayush Singh
2024-07-02 15:17 ` Rob Herring
2024-06-27 16:26 ` [PATCH v5 2/7] dt-bindings: mikrobus: Add mikrobus board base Ayush Singh
2024-06-28 16:04 ` Rob Herring
2024-06-27 16:26 ` [PATCH v5 3/7] dt-bindings: mikrobus: Add mikrobus-spi binding Ayush Singh
2024-06-27 19:21 ` Rob Herring (Arm)
2024-06-28 16:48 ` Conor Dooley
2024-07-05 7:44 ` Geert Uytterhoeven
2024-06-27 16:26 ` [PATCH v5 4/7] spi: Make of_find_spi_controller_by_node() available Ayush Singh
2024-06-27 16:26 ` [PATCH v5 5/7] spi: Make of_register_spi_device() available Ayush Singh
2024-06-27 16:26 ` [PATCH v5 6/7] mikrobus: Add mikroBUS driver Ayush Singh
2024-07-04 13:06 ` Greg Kroah-Hartman
2024-07-04 13:11 ` Mark Brown
2024-07-04 13:29 ` Ayush Singh
2024-06-27 16:26 ` [PATCH v5 7/7] dts: ti: k3-am625-beagleplay: Add mikroBUS Ayush Singh
2024-06-27 16:42 ` Nishanth Menon
2024-06-27 17:07 ` Ayush Singh
2024-06-27 17:07 ` Andrew Davis
2024-06-27 17:16 ` Ayush Singh
2024-06-27 17:50 ` Andrew Davis
2024-06-27 18:16 ` Ayush Singh
2024-06-27 18:53 ` Andrew Lunn
2024-06-28 17:27 ` Rob Herring
2024-06-27 17:21 ` Michael Walle
2024-06-27 17:43 ` Ayush Singh
2024-07-05 8:01 ` Geert Uytterhoeven
2024-07-05 8:19 ` Geert Uytterhoeven
2024-07-05 16:34 ` Andrew Davis
2024-07-05 17:36 ` Geert Uytterhoeven
2024-06-28 15:14 ` Conor Dooley
2024-06-28 6:31 ` [PATCH v5 0/7] misc: Add mikroBUS driver Ayush Singh
2024-06-28 13:52 ` Andrew Lunn
2024-06-28 18:05 ` Ayush Singh
2024-06-28 15:41 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2AYUH4XY0SK.1SYOUCT0PLAKT@kernel.org \
--to=mwalle@kernel.org \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=ayush@beagleboard.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=jkridner@beagleboard.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nm@ti.com \
--cc=robertcnelson@beagleboard.org \
--cc=robh@kernel.org \
--cc=vaishnav@beagleboard.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.