All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Barros Pena, Belen" <belen.barros.pena@intel.com>
To: "Smith, Elliot" <elliot.smith@intel.com>, sujith h <sujith.h@gmail.com>
Cc: "toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: Re: Review for #9071 ( issue with non-ascii characters)
Date: Wed, 9 Mar 2016 12:24:48 +0000	[thread overview]
Message-ID: <D305C5FC.760DB%belen.barros.pena@intel.com> (raw)
In-Reply-To: <CA+1hgUiNErCq_TdmtPPQR5BNw1+VeWJzQnSTd88zrenchtmwtQ@mail.gmail.com>



On 08/03/2016 18:09, "toaster-bounces@yoctoproject.org on behalf of Smith,
Elliot" <toaster-bounces@yoctoproject.org on behalf of
elliot.smith@intel.com> wrote:

>Thanks for the patch. Reviewed, sent upstream to bitbake-devel, added to
>poky-contrib/toaster-next.

I might be too late, but this patch seems to fix the build form, but
clicking the 'rebuild' button still fails to start a build if you have
non-ascii characters in the project name. After you click the 'rebuild'
button, the js console shows

Uncaught SyntaxError: Unexpected token ILLEGAL

The button works fine in projects without funny characters.

Cheers

Belén

>
>
>Elliot
>
>
>On 8 March 2016 at 14:24, sujith h <sujith.h@gmail.com> wrote:
>
>Hi,
>
>
>I have created couple of patches for review at:
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/text-
>encoding 
><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/text
>-encoding>
>
>
>This is for bug 
>https://bugzilla.yoctoproject.org/show_bug.cgi?id=9071
><https://bugzilla.yoctoproject.org/show_bug.cgi?id=9071>
>
>I have verified by adding non-ascii characters in the project name. And
>the build was successful.
>
>
>Thans,
>
>Sujith H
>
>-- 
>സുജിത് ഹരിദാസന്
>Bangalore
><Project>Contributor to KDE project
>
><Project>Contributor to Yocto project
>
>http://fci.wikia.com/wiki/Anti-DRM-Campaign
><Blog> http://sujithh.info
>
>
>
>
>
>
>
>
>
>
>
>--
>_______________________________________________
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
>
>
>
>
>-- 
>Elliot Smith
>Software Engineer
>Intel Open Source Technology Centre
>
>
>


  reply	other threads:[~2016-03-09 12:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08 14:24 Review for #9071 ( issue with non-ascii characters) sujith h
2016-03-08 18:09 ` Smith, Elliot
2016-03-09 12:24   ` Barros Pena, Belen [this message]
2016-03-09 12:26     ` Smith, Elliot
2016-03-09 12:32       ` Smith, Elliot
2016-03-09 13:26         ` Barros Pena, Belen
2016-03-09 14:38           ` Smith, Elliot
2016-03-09 14:44             ` Smith, Elliot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D305C5FC.760DB%belen.barros.pena@intel.com \
    --to=belen.barros.pena@intel.com \
    --cc=elliot.smith@intel.com \
    --cc=sujith.h@gmail.com \
    --cc=toaster@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.