From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 6D569E00AD8; Wed, 23 Mar 2016 07:39:27 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [192.55.52.88 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 29517E009D7 for ; Wed, 23 Mar 2016 07:39:23 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 23 Mar 2016 07:39:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,382,1455004800"; d="scan'208";a="674443911" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by FMSMGA003.fm.intel.com with ESMTP; 23 Mar 2016 07:39:22 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.10]) by irsmsx105.ger.corp.intel.com ([169.254.7.35]) with mapi id 14.03.0248.002; Wed, 23 Mar 2016 14:39:03 +0000 From: "Barros Pena, Belen" To: "Smith, Elliot" , "toaster@yoctoproject.org" Thread-Topic: [Toaster] [PATCH 0/2][v2] Show custom build dashboard for builds which fail early Thread-Index: AQHRhRG+Mjcj3/AqvE2pu2+1GF5pZg== Date: Wed, 23 Mar 2016 14:39:02 +0000 Message-ID: References: <1458590033-4724-1-git-send-email-elliot.smith@intel.com> In-Reply-To: <1458590033-4724-1-git-send-email-elliot.smith@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.6.2.160219 x-originating-ip: [10.237.224.41] MIME-Version: 1.0 Subject: Re: [PATCH 0/2][v2] Show custom build dashboard for builds which fail early X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 14:39:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable On 21/03/2016 19:53, "toaster-bounces@yoctoproject.org on behalf of Elliot Smith" wrote: >v2: > >Modifications for other templates which were missed in v1, as per Belen's >review. This one looks good: layout issues are fixed. Thanks! Bel=E9n > >v1: > >Builds which fail early at the "build request stage" (i.e. before the >BuildStarted >event happens) need a custom build dashboard, as they don't have any >buildstats >data, images, recipes etc., so the links in the left-hand menu are >irrelevant. > >Hide the build dashboard's left-hand menu if a build failed early (before >BuildStarted). Also remove the build time links for the failed builds, as >time data is not available. > >The state of the build as "started" or not is determined by looking for >build variables associated with a build. As these variables are only added >at the point when BuildStarted occurs, any Build object without these >variables hasn't triggered a BuildStarted event. > >(This is something of a work-around; in future we may have more >fine-grained >states on a build so that we can properly tell its state. When this >happens, the >Build.started() method could be modified to properly reflect this.) > >To test: > >1. Start a build with a bad target, e.g. "zzz". >2. When the build fails, go to the dashboard for the build. The left-hand >menu >should not be visible. >3. Go to the all builds page. The build time for the failed build should >not have a hyperlink on it. >4. Start a build with a bad MACHINE variable setting (either modify in >project >configuration or in conf/toaster.conf). >5. Repeat steps 2 and 3 for the failed build. >6. Start a build with a bad DISTRO variable setting (either modify in >project >configuration or in conf/toaster.conf). >7. Repeat steps 2 and 3 for the failed build. >8. Start a good build, e.g. "mpfr-native". >9. When the build completes (successfully), go to the dashboard. The >left-hand >menu should be visible and functioning. >10. Go to the all builds page. Links on the build time should be present >and >should point at the time page for the build. > >Note that I have some Selenium tests for testing these changes, but they >depend on a previous patchset which is not yet in toaster-next; see >https://lists.yoctoproject.org/pipermail/toaster/2016-March/004164.html. > >Changes since 358ba11b15f5182c4d667cf35565afc0c6ad4126 (toaster-next) are >in >git://git.yoctoproject.org/poky-contrib, >elliot/toaster/failed_builds_display-8443 >http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=3Delliot/toaster/= fa >iled_builds_display-8443 > >Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=3D8443 > >Elliot Smith (2): > toaster: adjust build dashboard for failed builds > toaster: remove links from time field on failed builds > > bitbake/lib/toaster/orm/models.py | 15 ++ > bitbake/lib/toaster/toastergui/tables.py | 8 +- > .../toastergui/templates/basebuildpage.html | 148 ++++++++-------- > .../lib/toaster/toastergui/templates/bpackage.html | 2 - > .../toastergui/templates/builddashboard.html | 186 >++++++++++--------- > .../toastergui/templates/configuration.html | 4 +- > .../toaster/toastergui/templates/configvars.html | 4 +- > .../lib/toaster/toastergui/templates/dirinfo.html | 105 ++++++----- > .../toaster/toastergui/templates/mrb_section.html | 7 +- > .../lib/toaster/toastergui/templates/recipes.html | 2 - > .../lib/toaster/toastergui/templates/target.html | 6 +- > .../lib/toaster/toastergui/templates/tasks.html | 196 >++++++++++----------- > bitbake/lib/toaster/toastergui/views.py | 1 + > 13 files changed, 354 insertions(+), 330 deletions(-) > >-- >Elliot Smith >Software Engineer >Intel OTC > >--------------------------------------------------------------------- >Intel Corporation (UK) Limited >Registered No. 1134945 (England) >Registered Office: Pipers Way, Swindon SN3 1RJ >VAT No: 860 2173 47 > >This e-mail and any attachments may contain confidential material for >the sole use of the intended recipient(s). Any review or distribution >by others is strictly prohibited. If you are not the intended >recipient, please contact the sender and delete all copies. > >--=20 >_______________________________________________ >toaster mailing list >toaster@yoctoproject.org >https://lists.yoctoproject.org/listinfo/toaster