From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91675C3DA4A for ; Mon, 5 Aug 2024 13:53:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 063D810E0E8; Mon, 5 Aug 2024 13:53:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="eQgCMXZ4"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3343010E0E8 for ; Mon, 5 Aug 2024 13:53:23 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 33CDE60C11; Mon, 5 Aug 2024 13:53:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 889E6C32782; Mon, 5 Aug 2024 13:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722866001; bh=qM0W3+uiHF24kyHGspvhQCNNR+HYuycNyzo1WKDpPvc=; h=Date:Subject:Cc:From:To:References:In-Reply-To:From; b=eQgCMXZ4M9VGbtC8ej7BFPktaug6jOsM7OzS0/Ob5J6CF7w4VMeMJ+p84PPwmwURO Y8MvYao20qoZ0q9KN9quDq4ryKE87H1AwDKKVYWj0wty5mIsRl0oFXGSv4j49jUeMY V7BV7EH3gNhUuhiU2AFU7gWyxzZ/UmE6QnAFXQeDRu7A3X1bROXtuq8OZn/pevrfWG 7GplHv4Inw6xikHvvosDGPUUPVTzNkp3DZSTUYApIhujzFKwQkLjqsR4OyalC2PbCV GCX1qG8UK/CZpWVBIQoiauu3uadZUcjbCVPVay/xoNWg5mfsYaqAUG0vJ1RhVsfLlg ykxx38WpVs//Q== Content-Type: multipart/signed; boundary=6e0a24126f65f65c33734dbb27c8b4c56556d1ee74b01984351e5fa3e521; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Mon, 05 Aug 2024 15:53:09 +0200 Message-Id: Subject: Re: [PATCH v2 1/2] drm: bridge: samsung-dsim: Initialize bridge on attach Cc: "Marek Vasut" , "Adam Ford" , "Andrzej Hajda" , "Daniel Vetter" , "David Airlie" , "Frieder Schrempf" , "Inki Dae" , "Jagan Teki" , "Jernej Skrabec" , "Jonas Karlman" , "Laurent Pinchart" , "Lucas Stach" , "Maarten Lankhorst" , "Marek Szyprowski" , "Maxime Ripard" , "Neil Armstrong" , "Robert Foss" , "Thomas Zimmermann" , , "Marek Vasut" From: "Michael Walle" To: "Alexander Stein" , X-Mailer: aerc 0.16.0 References: <20240625122824.148163-1-marex@denx.de> <5476416.LvFx2qVVIh@steina-w> In-Reply-To: <5476416.LvFx2qVVIh@steina-w> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --6e0a24126f65f65c33734dbb27c8b4c56556d1ee74b01984351e5fa3e521 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi, > with more and more patches for TC9595 support got meged into linux-next, > only a few remain on my patch stack. > > This is one of them and is necessary for DP support: > Tested-by: Alexander Stein As mentioned in [1] I expect a new version of this series with a proper documentation update that will then (hopefully) be acked by the maintainers. Apart from that, I'm still not convinced that the .attach() callback is the correct place to put the lanes into LP-11 mode. E.g. the MediaTek DSI host needs to already know the HS clock rate before configuring the D-PHY. Something which isn't available at the time .attach() is called. Marek mentioned, that one should start with lowest possible clock rate and later reconfigure it to the correct rate. I'm not sure this is possible without taking the clock lanes out of LP-11 mode again (i.e. disabling the PHY altogether to change its PLL). But doing so will violate the bridge requirements again. -michael [1] https://lore.kernel.org/dri-devel/D2R83VFPUWE3.3MBX3LQOCDFWA@kernel.org= / --6e0a24126f65f65c33734dbb27c8b4c56556d1ee74b01984351e5fa3e521 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCZrDZRxIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/jHQgGAz79ZPaRSILFzurmVLdDu5Z9+xzhOCAT3 pifRnlJtZIdcangOrfNYu7KlE8QBkNq/AYDlbKCFe3hYWemB39OnAmldirrT/gKI P8LYJveX5YDi8xPEMwAeQSyDuXN/b1jMMYA= =23LK -----END PGP SIGNATURE----- --6e0a24126f65f65c33734dbb27c8b4c56556d1ee74b01984351e5fa3e521--