All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Kurth <lars.kurth@citrix.com>
To: George Dunlap <George.Dunlap@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "committers@xenproject.org" <committers@xenproject.org>
Subject: Re: [PATCH] Remove ambiguities in the COPYING file; add CONTRIBUTING file
Date: Thu, 11 Aug 2016 11:05:04 +0000	[thread overview]
Message-ID: <D3D2181C.2CA10%lars.kurth@citrix.com> (raw)
In-Reply-To: <7bb44afe-9709-e27a-7c7a-abadd919d9f1@citrix.com>



On 11/08/2016 10:56, "George Dunlap" <george.dunlap@citrix.com> wrote:

>> +GPL v2 License
>> +--------------
>> +
>> +/*
>> + * <File name>
>> + *
>> + * <One line description of the file and what it does>
>> + * 
>> + * Copyright (C) <year>  <name of author and/or company>
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public
>> + * License v2 as published by the Free Software Foundation.
>
>Should this line have "only" in it somewhere?

I don't believe this is necessary. I couldn't find a single instance in
our codebase which says "version 2 only".

Most files have the following:

 * This program is free software; you can redistribute it and/or modify it
 * under the terms and conditions of the GNU General Public License,
 * version 2, as published by the Free Software Foundation.


which spells out the version with comma's and has slightly different line
breaks. I think it may be better to use that, as FOSSology creates less
noise with this variant of the header: it creates one GPLv2 entry, whereas
the previous one creates a GPL and a GPLv2 entry.

Regards
Lars

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-08-11 11:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10 11:30 [PATCH] Remove ambiguities in the COPYING file; add CONTRIBUTING file Lars Kurth
2016-08-11  0:51 ` Stefano Stabellini
2016-08-11  9:49   ` George Dunlap
2016-08-11 10:52     ` Lars Kurth
2016-08-11 18:57     ` Stefano Stabellini
2016-08-12  9:15       ` Lars Kurth
2016-08-11 10:39   ` Lars Kurth
2016-08-11 18:59     ` Stefano Stabellini
2016-08-12  9:13       ` Lars Kurth
2016-08-12 21:45         ` Stefano Stabellini
2016-08-11  9:56 ` George Dunlap
2016-08-11 11:05   ` Lars Kurth [this message]
2016-08-11 13:33     ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D3D2181C.2CA10%lars.kurth@citrix.com \
    --to=lars.kurth@citrix.com \
    --cc=George.Dunlap@citrix.com \
    --cc=committers@xenproject.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.